From: Richard Lewis <richard.lewis.debian@googlemail.com>
Date: Wed, 16 Oct 2024 09:29:37 +0100
Subject: chkrootkit: chk_chsh

Forwarded: yes
(Forwarded by email: 21 Dec 2024)
---
 chkrootkit | 39 +++++++++++++++++++++------------------
 1 file changed, 21 insertions(+), 18 deletions(-)

diff --git a/chkrootkit b/chkrootkit
index 0d0508a..7137152 100755
--- a/chkrootkit
+++ b/chkrootkit
@@ -1472,16 +1472,16 @@ chk_chfn () {
 
 chk_chsh () {
     STATUS=${NOT_INFECTED}
-    CMD=`loc chsh chsh $pth`
-    [ ${?} -ne 0 ] && return ${NOT_FOUND}
+    CMD=$(loc chsh chsh "$pth")
+    [ ${?} -ne 0 ] && return "${NOT_FOUND}"
 
     REDHAT_PAM_LABEL="*NOT*"
-    GENERIC_ROOTKIT_FEDORA=${GENERIC_ROOTKIT_LABEL} 
-    if [ -f  /etc/system-release ]; then 
-       v="0"`${egrep} -i fedora /etc/system-release | cut -d " " -f 3`
-       if [ "$v" -gt "32" ]; then 
-          GENERIC_ROOTKIT_FEDORA="bash|elite$|vejeta|\.ark|iroffer"
-       fi  
+    GENERIC_ROOTKIT_FEDORA=${GENERIC_ROOTKIT_LABEL}
+    if [ -f  "${ROOTDIR}etc/system-release" ]; then
+        v="0"$(${egrep} -i fedora "${ROOTDIR}etc/system-release" | "${cut}" -d " " -f 3)
+        if [ "$v" -gt "32" ]; then
+            GENERIC_ROOTKIT_FEDORA="bash|elite$|vejeta|\.ark|iroffer"
+        fi
     fi
 
     if [ "${EXPERT}" = "t" ]; then
@@ -1491,25 +1491,28 @@ chk_chsh () {
 
     case "${SYSTEM}" in
        Linux)
-          if ${strings} -a ${CMD} | ${egrep} "${GENERIC_ROOTKIT_FEDORA}" \
+          if "${strings}" -a "${CMD}" | ${egrep} "${GENERIC_ROOTKIT_FEDORA}" \
           >/dev/null 2>&1
-             then
-             if ${strings} -a ${CMD} | ${egrep} "${REDHAT_PAM_LABEL}" \
+          then
+             if "${strings}" -a "${CMD}" | ${egrep} "${REDHAT_PAM_LABEL}" \
              >/dev/null 2>&1
-                then
+             then
                 :
              else
                 STATUS=${INFECTED}
              fi
           fi;;
        FreeBSD)
-          [ `echo $V | ${awk} '{ if ($1 >= 5.0) print 1; else print 0}'` -eq 1 ] && n=1 || n=2
-          if [ `${strings} -a ${CMD} | ${egrep} -c "${GENERIC_ROOTKIT_LABEL}"` -ne $n ]
-             then
-             STATUS=${INFECTED}
-          fi;;
+           if [ "$("${echo}" "$V" | "${awk}" '{ if ($1 >= 5.0) print 1; else print 0}')" -eq 1 ]; then
+               n=1
+           else
+               n=2
+           fi
+           if [ "$("${strings}" -a "${CMD}" | ${egrep} -c "${GENERIC_ROOTKIT_LABEL}")" -ne "$n" ]; then
+               STATUS=${INFECTED}
+           fi;;
     esac
-    return ${STATUS}
+    return "${STATUS}"
 }
 
 chk_login () {