#!/usr/bin/env python # Copyright (c) 2012 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. import os.path import subprocess import unittest import PRESUBMIT from PRESUBMIT_test_mocks import MockFile, MockAffectedFile from PRESUBMIT_test_mocks import MockInputApi, MockOutputApi _TEST_DATA_DIR = 'base/test/data/presubmit' class VersionControlConflictsTest(unittest.TestCase): def testTypicalConflict(self): lines = ['<<<<<<< HEAD', ' base::ScopedTempDir temp_dir_;', '=======', ' ScopedTempDir temp_dir_;', '>>>>>>> master'] errors = PRESUBMIT._CheckForVersionControlConflictsInFile( MockInputApi(), MockFile('some/path/foo_platform.cc', lines)) self.assertEqual(3, len(errors)) self.assertTrue('1' in errors[0]) self.assertTrue('3' in errors[1]) self.assertTrue('5' in errors[2]) def testIgnoresReadmes(self): lines = ['A First Level Header', '====================', '', 'A Second Level Header', '---------------------'] errors = PRESUBMIT._CheckForVersionControlConflictsInFile( MockInputApi(), MockFile('some/polymer/README.md', lines)) self.assertEqual(0, len(errors)) class UmaHistogramChangeMatchedOrNotTest(unittest.TestCase): def testTypicalCorrectlyMatchedChange(self): diff_cc = ['UMA_HISTOGRAM_BOOL("Bla.Foo.Dummy", true)'] diff_java = [ 'RecordHistogram.recordBooleanHistogram("Bla.Foo.Dummy", true)'] diff_xml = [' '] mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', diff_cc), MockFile('some/path/foo.java', diff_java), MockFile('tools/metrics/histograms/histograms.xml', diff_xml), ] warnings = PRESUBMIT._CheckUmaHistogramChanges(mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testTypicalNotMatchedChange(self): diff_cc = ['UMA_HISTOGRAM_BOOL("Bla.Foo.Dummy", true)'] diff_java = [ 'RecordHistogram.recordBooleanHistogram("Bla.Foo.Dummy", true)'] mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', diff_cc), MockFile('some/path/foo.java', diff_java), ] warnings = PRESUBMIT._CheckUmaHistogramChanges(mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual('warning', warnings[0].type) self.assertTrue('foo.cc' in warnings[0].items[0]) self.assertTrue('foo.java' in warnings[0].items[1]) def testTypicalNotMatchedChangeViaSuffixes(self): diff_cc = ['UMA_HISTOGRAM_BOOL("Bla.Foo.Dummy", true)'] diff_java = [ 'RecordHistogram.recordBooleanHistogram("Bla.Foo.Dummy", true)'] diff_xml = ['', ' ', ' ', ''] mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', diff_cc), MockFile('some/path/foo.java', diff_java), MockFile('tools/metrics/histograms/histograms.xml', diff_xml), ] warnings = PRESUBMIT._CheckUmaHistogramChanges(mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual('warning', warnings[0].type) self.assertTrue('foo.cc' in warnings[0].items[0]) self.assertTrue('foo.java' in warnings[0].items[1]) def testTypicalCorrectlyMatchedChangeViaSuffixes(self): diff_cc = ['UMA_HISTOGRAM_BOOL("Bla.Foo.Dummy", true)'] diff_java = [ 'RecordHistogram.recordBooleanHistogram("Bla.Foo.Dummy", true)'] diff_xml = ['', ' ', ' ', ''] mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', diff_cc), MockFile('some/path/foo.java', diff_java), MockFile('tools/metrics/histograms/histograms.xml', diff_xml), ] warnings = PRESUBMIT._CheckUmaHistogramChanges(mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testTypicalCorrectlyMatchedChangeViaSuffixesWithSeparator(self): diff_cc = ['UMA_HISTOGRAM_BOOL("Snafu_Dummy", true)'] diff_java = ['RecordHistogram.recordBooleanHistogram("Snafu_Dummy", true)'] diff_xml = ['', ' ', ' ', ''] mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', diff_cc), MockFile('some/path/foo.java', diff_java), MockFile('tools/metrics/histograms/histograms.xml', diff_xml), ] warnings = PRESUBMIT._CheckUmaHistogramChanges(mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testNameMatch(self): # Check that the detected histogram name is "Dummy" and not, e.g., # "Dummy\", true); // The \"correct" diff_cc = ['UMA_HISTOGRAM_BOOL("Dummy", true); // The "correct" histogram'] diff_java = [ 'RecordHistogram.recordBooleanHistogram("Dummy", true);' + ' // The "correct" histogram'] diff_xml = [' '] mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', diff_cc), MockFile('some/path/foo.java', diff_java), MockFile('tools/metrics/histograms/histograms.xml', diff_xml), ] warnings = PRESUBMIT._CheckUmaHistogramChanges(mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testSimilarMacroNames(self): diff_cc = ['PUMA_HISTOGRAM_COOL("Mountain Lion", 42)'] diff_java = [ 'FakeRecordHistogram.recordFakeHistogram("Mountain Lion", 42)'] mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', diff_cc), MockFile('some/path/foo.java', diff_java), ] warnings = PRESUBMIT._CheckUmaHistogramChanges(mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testMultiLine(self): diff_cc = ['UMA_HISTOGRAM_BOOLEAN(', ' "Multi.Line", true)'] diff_cc2 = ['UMA_HISTOGRAM_BOOLEAN(', ' "Multi.Line"', ' , true)'] diff_java = [ 'RecordHistogram.recordBooleanHistogram(', ' "Multi.Line", true);', ] mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', diff_cc), MockFile('some/path/foo2.cc', diff_cc2), MockFile('some/path/foo.java', diff_java), ] warnings = PRESUBMIT._CheckUmaHistogramChanges(mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual('warning', warnings[0].type) self.assertTrue('foo.cc' in warnings[0].items[0]) self.assertTrue('foo2.cc' in warnings[0].items[1]) class BadExtensionsTest(unittest.TestCase): def testBadRejFile(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', ''), MockFile('some/path/foo.cc.rej', ''), MockFile('some/path2/bar.h.rej', ''), ] results = PRESUBMIT._CheckPatchFiles(mock_input_api, MockOutputApi()) self.assertEqual(1, len(results)) self.assertEqual(2, len(results[0].items)) self.assertTrue('foo.cc.rej' in results[0].items[0]) self.assertTrue('bar.h.rej' in results[0].items[1]) def testBadOrigFile(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('other/path/qux.h.orig', ''), MockFile('other/path/qux.h', ''), MockFile('other/path/qux.cc', ''), ] results = PRESUBMIT._CheckPatchFiles(mock_input_api, MockOutputApi()) self.assertEqual(1, len(results)) self.assertEqual(1, len(results[0].items)) self.assertTrue('qux.h.orig' in results[0].items[0]) def testGoodFiles(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('other/path/qux.h', ''), MockFile('other/path/qux.cc', ''), ] results = PRESUBMIT._CheckPatchFiles(mock_input_api, MockOutputApi()) self.assertEqual(0, len(results)) class CheckSingletonInHeadersTest(unittest.TestCase): def testSingletonInArbitraryHeader(self): diff_singleton_h = ['base::subtle::AtomicWord ' 'base::Singleton::'] diff_foo_h = ['// base::Singleton in comment.', 'friend class base::Singleton'] diff_foo2_h = [' //Foo* bar = base::Singleton::get();'] diff_bad_h = ['Foo* foo = base::Singleton::get();'] mock_input_api = MockInputApi() mock_input_api.files = [MockAffectedFile('base/memory/singleton.h', diff_singleton_h), MockAffectedFile('foo.h', diff_foo_h), MockAffectedFile('foo2.h', diff_foo2_h), MockAffectedFile('bad.h', diff_bad_h)] warnings = PRESUBMIT._CheckSingletonInHeaders(mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual(1, len(warnings[0].items)) self.assertEqual('error', warnings[0].type) self.assertTrue('Found base::Singleton' in warnings[0].message) def testSingletonInCC(self): diff_cc = ['Foo* foo = base::Singleton::get();'] mock_input_api = MockInputApi() mock_input_api.files = [MockAffectedFile('some/path/foo.cc', diff_cc)] warnings = PRESUBMIT._CheckSingletonInHeaders(mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) class InvalidOSMacroNamesTest(unittest.TestCase): def testInvalidOSMacroNames(self): lines = ['#if defined(OS_WINDOWS)', ' #elif defined(OS_WINDOW)', ' # if defined(OS_MACOSX) || defined(OS_CHROME)', '# else // defined(OS_MAC)', '#endif // defined(OS_MACOS)'] errors = PRESUBMIT._CheckForInvalidOSMacrosInFile( MockInputApi(), MockFile('some/path/foo_platform.cc', lines)) self.assertEqual(len(lines), len(errors)) self.assertTrue(':1 OS_WINDOWS' in errors[0]) self.assertTrue('(did you mean OS_WIN?)' in errors[0]) def testValidOSMacroNames(self): lines = ['#if defined(%s)' % m for m in PRESUBMIT._VALID_OS_MACROS] errors = PRESUBMIT._CheckForInvalidOSMacrosInFile( MockInputApi(), MockFile('some/path/foo_platform.cc', lines)) self.assertEqual(0, len(errors)) class InvalidIfDefinedMacroNamesTest(unittest.TestCase): def testInvalidIfDefinedMacroNames(self): lines = ['#if defined(TARGET_IPHONE_SIMULATOR)', '#if !defined(TARGET_IPHONE_SIMULATOR)', '#elif defined(TARGET_IPHONE_SIMULATOR)', '#ifdef TARGET_IPHONE_SIMULATOR', ' # ifdef TARGET_IPHONE_SIMULATOR', '# if defined(VALID) || defined(TARGET_IPHONE_SIMULATOR)', '# else // defined(TARGET_IPHONE_SIMULATOR)', '#endif // defined(TARGET_IPHONE_SIMULATOR)'] errors = PRESUBMIT._CheckForInvalidIfDefinedMacrosInFile( MockInputApi(), MockFile('some/path/source.mm', lines)) self.assertEqual(len(lines), len(errors)) def testValidIfDefinedMacroNames(self): lines = ['#if defined(FOO)', '#ifdef BAR'] errors = PRESUBMIT._CheckForInvalidIfDefinedMacrosInFile( MockInputApi(), MockFile('some/path/source.cc', lines)) self.assertEqual(0, len(errors)) class CheckAddedDepsHaveTetsApprovalsTest(unittest.TestCase): def calculate(self, old_include_rules, old_specific_include_rules, new_include_rules, new_specific_include_rules): return PRESUBMIT._CalculateAddedDeps( os.path, 'include_rules = %r\nspecific_include_rules = %r' % ( old_include_rules, old_specific_include_rules), 'include_rules = %r\nspecific_include_rules = %r' % ( new_include_rules, new_specific_include_rules)) def testCalculateAddedDeps(self): old_include_rules = [ '+base', '-chrome', '+content', '-grit', '-grit/",', '+jni/fooblat.h', '!sandbox', ] old_specific_include_rules = { 'compositor\.*': { '+cc', }, } new_include_rules = [ '-ash', '+base', '+chrome', '+components', '+content', '+grit', '+grit/generated_resources.h",', '+grit/",', '+jni/fooblat.h', '+policy', '+' + os.path.join('third_party', 'WebKit'), ] new_specific_include_rules = { 'compositor\.*': { '+cc', }, 'widget\.*': { '+gpu', }, } expected = set([ os.path.join('chrome', 'DEPS'), os.path.join('gpu', 'DEPS'), os.path.join('components', 'DEPS'), os.path.join('policy', 'DEPS'), os.path.join('third_party', 'WebKit', 'DEPS'), ]) self.assertEqual( expected, self.calculate(old_include_rules, old_specific_include_rules, new_include_rules, new_specific_include_rules)) def testCalculateAddedDepsIgnoresPermutations(self): old_include_rules = [ '+base', '+chrome', ] new_include_rules = [ '+chrome', '+base', ] self.assertEqual(set(), self.calculate(old_include_rules, {}, new_include_rules, {})) class JSONParsingTest(unittest.TestCase): def testSuccess(self): input_api = MockInputApi() filename = 'valid_json.json' contents = ['// This is a comment.', '{', ' "key1": ["value1", "value2"],', ' "key2": 3 // This is an inline comment.', '}' ] input_api.files = [MockFile(filename, contents)] self.assertEqual(None, PRESUBMIT._GetJSONParseError(input_api, filename)) def testFailure(self): input_api = MockInputApi() test_data = [ ('invalid_json_1.json', ['{ x }'], 'Expecting property name:'), ('invalid_json_2.json', ['// Hello world!', '{ "hello": "world }'], 'Unterminated string starting at:'), ('invalid_json_3.json', ['{ "a": "b", "c": "d", }'], 'Expecting property name:'), ('invalid_json_4.json', ['{ "a": "b" "c": "d" }'], 'Expecting , delimiter:'), ] input_api.files = [MockFile(filename, contents) for (filename, contents, _) in test_data] for (filename, _, expected_error) in test_data: actual_error = PRESUBMIT._GetJSONParseError(input_api, filename) self.assertTrue(expected_error in str(actual_error), "'%s' not found in '%s'" % (expected_error, actual_error)) def testNoEatComments(self): input_api = MockInputApi() file_with_comments = 'file_with_comments.json' contents_with_comments = ['// This is a comment.', '{', ' "key1": ["value1", "value2"],', ' "key2": 3 // This is an inline comment.', '}' ] file_without_comments = 'file_without_comments.json' contents_without_comments = ['{', ' "key1": ["value1", "value2"],', ' "key2": 3', '}' ] input_api.files = [MockFile(file_with_comments, contents_with_comments), MockFile(file_without_comments, contents_without_comments)] self.assertEqual('No JSON object could be decoded', str(PRESUBMIT._GetJSONParseError(input_api, file_with_comments, eat_comments=False))) self.assertEqual(None, PRESUBMIT._GetJSONParseError(input_api, file_without_comments, eat_comments=False)) class IDLParsingTest(unittest.TestCase): def testSuccess(self): input_api = MockInputApi() filename = 'valid_idl_basics.idl' contents = ['// Tests a valid IDL file.', 'namespace idl_basics {', ' enum EnumType {', ' name1,', ' name2', ' };', '', ' dictionary MyType1 {', ' DOMString a;', ' };', '', ' callback Callback1 = void();', ' callback Callback2 = void(long x);', ' callback Callback3 = void(MyType1 arg);', ' callback Callback4 = void(EnumType type);', '', ' interface Functions {', ' static void function1();', ' static void function2(long x);', ' static void function3(MyType1 arg);', ' static void function4(Callback1 cb);', ' static void function5(Callback2 cb);', ' static void function6(Callback3 cb);', ' static void function7(Callback4 cb);', ' };', '', ' interface Events {', ' static void onFoo1();', ' static void onFoo2(long x);', ' static void onFoo2(MyType1 arg);', ' static void onFoo3(EnumType type);', ' };', '};' ] input_api.files = [MockFile(filename, contents)] self.assertEqual(None, PRESUBMIT._GetIDLParseError(input_api, filename)) def testFailure(self): input_api = MockInputApi() test_data = [ ('invalid_idl_1.idl', ['//', 'namespace test {', ' dictionary {', ' DOMString s;', ' };', '};'], 'Unexpected "{" after keyword "dictionary".\n'), # TODO(yoz): Disabled because it causes the IDL parser to hang. # See crbug.com/363830. # ('invalid_idl_2.idl', # (['namespace test {', # ' dictionary MissingSemicolon {', # ' DOMString a', # ' DOMString b;', # ' };', # '};'], # 'Unexpected symbol DOMString after symbol a.'), ('invalid_idl_3.idl', ['//', 'namespace test {', ' enum MissingComma {', ' name1', ' name2', ' };', '};'], 'Unexpected symbol name2 after symbol name1.'), ('invalid_idl_4.idl', ['//', 'namespace test {', ' enum TrailingComma {', ' name1,', ' name2,', ' };', '};'], 'Trailing comma in block.'), ('invalid_idl_5.idl', ['//', 'namespace test {', ' callback Callback1 = void(;', '};'], 'Unexpected ";" after "(".'), ('invalid_idl_6.idl', ['//', 'namespace test {', ' callback Callback1 = void(long );', '};'], 'Unexpected ")" after symbol long.'), ('invalid_idl_7.idl', ['//', 'namespace test {', ' interace Events {', ' static void onFoo1();', ' };', '};'], 'Unexpected symbol Events after symbol interace.'), ('invalid_idl_8.idl', ['//', 'namespace test {', ' interface NotEvent {', ' static void onFoo1();', ' };', '};'], 'Did not process Interface Interface(NotEvent)'), ('invalid_idl_9.idl', ['//', 'namespace test {', ' interface {', ' static void function1();', ' };', '};'], 'Interface missing name.'), ] input_api.files = [MockFile(filename, contents) for (filename, contents, _) in test_data] for (filename, _, expected_error) in test_data: actual_error = PRESUBMIT._GetIDLParseError(input_api, filename) self.assertTrue(expected_error in str(actual_error), "'%s' not found in '%s'" % (expected_error, actual_error)) class TryServerMasterTest(unittest.TestCase): def testTryServerMasters(self): bots = { 'master.tryserver.chromium.android': [ 'android_archive_rel_ng', 'android_arm64_dbg_recipe', 'android_blink_rel', 'android_clang_dbg_recipe', 'android_compile_dbg', 'android_compile_x64_dbg', 'android_compile_x86_dbg', 'android_coverage', 'android_cronet_tester' 'android_swarming_rel', 'cast_shell_android', 'linux_android_dbg_ng', 'linux_android_rel_ng', ], 'master.tryserver.chromium.mac': [ 'ios_dbg_simulator', 'ios_rel_device', 'ios_rel_device_ninja', 'mac_asan', 'mac_asan_64', 'mac_chromium_compile_dbg', 'mac_chromium_compile_rel', 'mac_chromium_dbg', 'mac_chromium_rel', 'mac_nacl_sdk', 'mac_nacl_sdk_build', 'mac_rel_naclmore', 'mac_x64_rel', 'mac_xcodebuild', ], 'master.tryserver.chromium.linux': [ 'chromium_presubmit', 'linux_arm_cross_compile', 'linux_arm_tester', 'linux_chromeos_asan', 'linux_chromeos_browser_asan', 'linux_chromeos_valgrind', 'linux_chromium_chromeos_dbg', 'linux_chromium_chromeos_rel', 'linux_chromium_compile_dbg', 'linux_chromium_compile_rel', 'linux_chromium_dbg', 'linux_chromium_gn_dbg', 'linux_chromium_gn_rel', 'linux_chromium_rel', 'linux_chromium_trusty32_dbg', 'linux_chromium_trusty32_rel', 'linux_chromium_trusty_dbg', 'linux_chromium_trusty_rel', 'linux_clang_tsan', 'linux_ecs_ozone', 'linux_layout', 'linux_layout_asan', 'linux_layout_rel', 'linux_layout_rel_32', 'linux_nacl_sdk', 'linux_nacl_sdk_bionic', 'linux_nacl_sdk_bionic_build', 'linux_nacl_sdk_build', 'linux_redux', 'linux_rel_naclmore', 'linux_rel_precise32', 'linux_valgrind', 'tools_build_presubmit', ], 'master.tryserver.chromium.win': [ 'win8_aura', 'win8_chromium_dbg', 'win8_chromium_rel', 'win_chromium_compile_dbg', 'win_chromium_compile_rel', 'win_chromium_dbg', 'win_chromium_rel', 'win_chromium_rel', 'win_chromium_x64_dbg', 'win_chromium_x64_rel', 'win_nacl_sdk', 'win_nacl_sdk_build', 'win_rel_naclmore', ], } for master, bots in bots.iteritems(): for bot in bots: self.assertEqual(master, PRESUBMIT.GetTryServerMasterForBot(bot), 'bot=%s: expected %s, computed %s' % ( bot, master, PRESUBMIT.GetTryServerMasterForBot(bot))) class UserMetricsActionTest(unittest.TestCase): def testUserMetricsActionInActions(self): input_api = MockInputApi() file_with_user_action = 'file_with_user_action.cc' contents_with_user_action = [ 'base::UserMetricsAction("AboutChrome")' ] input_api.files = [MockFile(file_with_user_action, contents_with_user_action)] self.assertEqual( [], PRESUBMIT._CheckUserActionUpdate(input_api, MockOutputApi())) def testUserMetricsActionNotAddedToActions(self): input_api = MockInputApi() file_with_user_action = 'file_with_user_action.cc' contents_with_user_action = [ 'base::UserMetricsAction("NotInActionsXml")' ] input_api.files = [MockFile(file_with_user_action, contents_with_user_action)] output = PRESUBMIT._CheckUserActionUpdate(input_api, MockOutputApi()) self.assertEqual( ('File %s line %d: %s is missing in ' 'tools/metrics/actions/actions.xml. Please run ' 'tools/metrics/actions/extract_actions.py to update.' % (file_with_user_action, 1, 'NotInActionsXml')), output[0].message) class PydepsNeedsUpdatingTest(unittest.TestCase): class MockSubprocess(object): CalledProcessError = subprocess.CalledProcessError def setUp(self): mock_all_pydeps = ['A.pydeps', 'B.pydeps'] self.old_ALL_PYDEPS_FILES = PRESUBMIT._ALL_PYDEPS_FILES PRESUBMIT._ALL_PYDEPS_FILES = mock_all_pydeps self.mock_input_api = MockInputApi() self.mock_output_api = MockOutputApi() self.mock_input_api.subprocess = PydepsNeedsUpdatingTest.MockSubprocess() self.checker = PRESUBMIT.PydepsChecker(self.mock_input_api, mock_all_pydeps) self.checker._file_cache = { 'A.pydeps': '# Generated by:\n# CMD A\nA.py\nC.py\n', 'B.pydeps': '# Generated by:\n# CMD B\nB.py\nC.py\n', } def tearDown(self): PRESUBMIT._ALL_PYDEPS_FILES = self.old_ALL_PYDEPS_FILES def _RunCheck(self): return PRESUBMIT._CheckPydepsNeedsUpdating(self.mock_input_api, self.mock_output_api, checker_for_tests=self.checker) def testAddedPydep(self): # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android. if self.mock_input_api.platform != 'linux2': return [] self.mock_input_api.files = [ MockAffectedFile('new.pydeps', [], action='A'), ] self.mock_input_api.CreateMockFileInPath( [x.LocalPath() for x in self.mock_input_api.AffectedFiles( include_deletes=True)]) results = self._RunCheck() self.assertEqual(1, len(results)) self.assertTrue('PYDEPS_FILES' in str(results[0])) def testPydepNotInSrc(self): self.mock_input_api.files = [ MockAffectedFile('new.pydeps', [], action='A'), ] self.mock_input_api.CreateMockFileInPath([]) results = self._RunCheck() self.assertEqual(0, len(results)) def testRemovedPydep(self): # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android. if self.mock_input_api.platform != 'linux2': return [] self.mock_input_api.files = [ MockAffectedFile(PRESUBMIT._ALL_PYDEPS_FILES[0], [], action='D'), ] self.mock_input_api.CreateMockFileInPath( [x.LocalPath() for x in self.mock_input_api.AffectedFiles( include_deletes=True)]) results = self._RunCheck() self.assertEqual(1, len(results)) self.assertTrue('PYDEPS_FILES' in str(results[0])) def testRandomPyIgnored(self): # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android. if self.mock_input_api.platform != 'linux2': return [] self.mock_input_api.files = [ MockAffectedFile('random.py', []), ] results = self._RunCheck() self.assertEqual(0, len(results), 'Unexpected results: %r' % results) def testRelevantPyNoChange(self): # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android. if self.mock_input_api.platform != 'linux2': return [] self.mock_input_api.files = [ MockAffectedFile('A.py', []), ] def mock_check_output(cmd, shell=False, env=None): self.assertEqual('CMD A --output ""', cmd) return self.checker._file_cache['A.pydeps'] self.mock_input_api.subprocess.check_output = mock_check_output results = self._RunCheck() self.assertEqual(0, len(results), 'Unexpected results: %r' % results) def testRelevantPyOneChange(self): # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android. if self.mock_input_api.platform != 'linux2': return [] self.mock_input_api.files = [ MockAffectedFile('A.py', []), ] def mock_check_output(cmd, shell=False, env=None): self.assertEqual('CMD A --output ""', cmd) return 'changed data' self.mock_input_api.subprocess.check_output = mock_check_output results = self._RunCheck() self.assertEqual(1, len(results)) self.assertTrue('File is stale' in str(results[0])) def testRelevantPyTwoChanges(self): # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android. if self.mock_input_api.platform != 'linux2': return [] self.mock_input_api.files = [ MockAffectedFile('C.py', []), ] def mock_check_output(cmd, shell=False, env=None): return 'changed data' self.mock_input_api.subprocess.check_output = mock_check_output results = self._RunCheck() self.assertEqual(2, len(results)) self.assertTrue('File is stale' in str(results[0])) self.assertTrue('File is stale' in str(results[1])) class IncludeGuardTest(unittest.TestCase): def testIncludeGuardChecks(self): mock_input_api = MockInputApi() mock_output_api = MockOutputApi() mock_input_api.files = [ MockAffectedFile('content/browser/thing/foo.h', [ '// Comment', '#ifndef CONTENT_BROWSER_THING_FOO_H_', '#define CONTENT_BROWSER_THING_FOO_H_', 'struct McBoatFace;', '#endif // CONTENT_BROWSER_THING_FOO_H_', ]), MockAffectedFile('content/browser/thing/bar.h', [ '#ifndef CONTENT_BROWSER_THING_BAR_H_', '#define CONTENT_BROWSER_THING_BAR_H_', 'namespace content {', '#endif // CONTENT_BROWSER_THING_BAR_H_', '} // namespace content', ]), MockAffectedFile('content/browser/test1.h', [ 'namespace content {', '} // namespace content', ]), MockAffectedFile('content\\browser\\win.h', [ '#ifndef CONTENT_BROWSER_WIN_H_', '#define CONTENT_BROWSER_WIN_H_', 'struct McBoatFace;', '#endif // CONTENT_BROWSER_WIN_H_', ]), MockAffectedFile('content/browser/test2.h', [ '// Comment', '#ifndef CONTENT_BROWSER_TEST2_H_', 'struct McBoatFace;', '#endif // CONTENT_BROWSER_TEST2_H_', ]), MockAffectedFile('content/browser/internal.h', [ '// Comment', '#ifndef CONTENT_BROWSER_INTERNAL_H_', '#define CONTENT_BROWSER_INTERNAL_H_', '// Comment', '#ifndef INTERNAL_CONTENT_BROWSER_INTERNAL_H_', '#define INTERNAL_CONTENT_BROWSER_INTERNAL_H_', 'namespace internal {', '} // namespace internal', '#endif // INTERNAL_CONTENT_BROWSER_THING_BAR_H_', 'namespace content {', '} // namespace content', '#endif // CONTENT_BROWSER_THING_BAR_H_', ]), MockAffectedFile('content/browser/thing/foo.cc', [ '// This is a non-header.', ]), MockAffectedFile('content/browser/disabled.h', [ '// no-include-guard-because-multiply-included', 'struct McBoatFace;', ]), # New files don't allow misspelled include guards. MockAffectedFile('content/browser/spleling.h', [ '#ifndef CONTENT_BROWSER_SPLLEING_H_', '#define CONTENT_BROWSER_SPLLEING_H_', 'struct McBoatFace;', '#endif // CONTENT_BROWSER_SPLLEING_H_', ]), # New files don't allow + in include guards. MockAffectedFile('content/browser/foo+bar.h', [ '#ifndef CONTENT_BROWSER_FOO+BAR_H_', '#define CONTENT_BROWSER_FOO+BAR_H_', 'struct McBoatFace;', '#endif // CONTENT_BROWSER_FOO+BAR_H_', ]), # Old files allow misspelled include guards (for now). MockAffectedFile('chrome/old.h', [ '// New contents', '#ifndef CHROME_ODL_H_', '#define CHROME_ODL_H_', '#endif // CHROME_ODL_H_', ], [ '// Old contents', '#ifndef CHROME_ODL_H_', '#define CHROME_ODL_H_', '#endif // CHROME_ODL_H_', ]), # Using a Blink style include guard outside Blink is wrong. MockAffectedFile('content/NotInBlink.h', [ '#ifndef NotInBlink_h', '#define NotInBlink_h', 'struct McBoatFace;', '#endif // NotInBlink_h', ]), # Using a Blink style include guard in Blink is no longer ok. MockAffectedFile('third_party/blink/InBlink.h', [ '#ifndef InBlink_h', '#define InBlink_h', 'struct McBoatFace;', '#endif // InBlink_h', ]), # Using a bad include guard in Blink is not ok. MockAffectedFile('third_party/blink/AlsoInBlink.h', [ '#ifndef WrongInBlink_h', '#define WrongInBlink_h', 'struct McBoatFace;', '#endif // WrongInBlink_h', ]), # Using a bad include guard in Blink is not accepted even if # it's an old file. MockAffectedFile('third_party/blink/StillInBlink.h', [ '// New contents', '#ifndef AcceptedInBlink_h', '#define AcceptedInBlink_h', 'struct McBoatFace;', '#endif // AcceptedInBlink_h', ], [ '// Old contents', '#ifndef AcceptedInBlink_h', '#define AcceptedInBlink_h', 'struct McBoatFace;', '#endif // AcceptedInBlink_h', ]), # Using a non-Chromium include guard in third_party # (outside blink) is accepted. MockAffectedFile('third_party/foo/some_file.h', [ '#ifndef REQUIRED_RPCNDR_H_', '#define REQUIRED_RPCNDR_H_', 'struct SomeFileFoo;', '#endif // REQUIRED_RPCNDR_H_', ]), ] msgs = PRESUBMIT._CheckForIncludeGuards( mock_input_api, mock_output_api) expected_fail_count = 8 self.assertEqual(expected_fail_count, len(msgs), 'Expected %d items, found %d: %s' % (expected_fail_count, len(msgs), msgs)) self.assertEqual(msgs[0].items, ['content/browser/thing/bar.h']) self.assertEqual(msgs[0].message, 'Include guard CONTENT_BROWSER_THING_BAR_H_ ' 'not covering the whole file') self.assertEqual(msgs[1].items, ['content/browser/test1.h']) self.assertEqual(msgs[1].message, 'Missing include guard CONTENT_BROWSER_TEST1_H_') self.assertEqual(msgs[2].items, ['content/browser/test2.h:3']) self.assertEqual(msgs[2].message, 'Missing "#define CONTENT_BROWSER_TEST2_H_" for ' 'include guard') self.assertEqual(msgs[3].items, ['content/browser/spleling.h:1']) self.assertEqual(msgs[3].message, 'Header using the wrong include guard name ' 'CONTENT_BROWSER_SPLLEING_H_') self.assertEqual(msgs[4].items, ['content/browser/foo+bar.h']) self.assertEqual(msgs[4].message, 'Missing include guard CONTENT_BROWSER_FOO_BAR_H_') self.assertEqual(msgs[5].items, ['content/NotInBlink.h:1']) self.assertEqual(msgs[5].message, 'Header using the wrong include guard name ' 'NotInBlink_h') self.assertEqual(msgs[6].items, ['third_party/blink/InBlink.h:1']) self.assertEqual(msgs[6].message, 'Header using the wrong include guard name ' 'InBlink_h') self.assertEqual(msgs[7].items, ['third_party/blink/AlsoInBlink.h:1']) self.assertEqual(msgs[7].message, 'Header using the wrong include guard name ' 'WrongInBlink_h') class AndroidDeprecatedTestAnnotationTest(unittest.TestCase): def testCheckAndroidTestAnnotationUsage(self): mock_input_api = MockInputApi() mock_output_api = MockOutputApi() mock_input_api.files = [ MockAffectedFile('LalaLand.java', [ 'random stuff' ]), MockAffectedFile('CorrectUsage.java', [ 'import android.support.test.filters.LargeTest;', 'import android.support.test.filters.MediumTest;', 'import android.support.test.filters.SmallTest;', ]), MockAffectedFile('UsedDeprecatedLargeTestAnnotation.java', [ 'import android.test.suitebuilder.annotation.LargeTest;', ]), MockAffectedFile('UsedDeprecatedMediumTestAnnotation.java', [ 'import android.test.suitebuilder.annotation.MediumTest;', ]), MockAffectedFile('UsedDeprecatedSmallTestAnnotation.java', [ 'import android.test.suitebuilder.annotation.SmallTest;', ]), MockAffectedFile('UsedDeprecatedSmokeAnnotation.java', [ 'import android.test.suitebuilder.annotation.Smoke;', ]) ] msgs = PRESUBMIT._CheckAndroidTestAnnotationUsage( mock_input_api, mock_output_api) self.assertEqual(1, len(msgs), 'Expected %d items, found %d: %s' % (1, len(msgs), msgs)) self.assertEqual(4, len(msgs[0].items), 'Expected %d items, found %d: %s' % (4, len(msgs[0].items), msgs[0].items)) self.assertTrue('UsedDeprecatedLargeTestAnnotation.java:1' in msgs[0].items, 'UsedDeprecatedLargeTestAnnotation not found in errors') self.assertTrue('UsedDeprecatedMediumTestAnnotation.java:1' in msgs[0].items, 'UsedDeprecatedMediumTestAnnotation not found in errors') self.assertTrue('UsedDeprecatedSmallTestAnnotation.java:1' in msgs[0].items, 'UsedDeprecatedSmallTestAnnotation not found in errors') self.assertTrue('UsedDeprecatedSmokeAnnotation.java:1' in msgs[0].items, 'UsedDeprecatedSmokeAnnotation not found in errors') class AndroidDeprecatedJUnitFrameworkTest(unittest.TestCase): def testCheckAndroidTestJUnitFramework(self): mock_input_api = MockInputApi() mock_output_api = MockOutputApi() mock_input_api.files = [ MockAffectedFile('LalaLand.java', [ 'random stuff' ]), MockAffectedFile('CorrectUsage.java', [ 'import org.junit.ABC', 'import org.junit.XYZ;', ]), MockAffectedFile('UsedDeprecatedJUnit.java', [ 'import junit.framework.*;', ]), MockAffectedFile('UsedDeprecatedJUnitAssert.java', [ 'import junit.framework.Assert;', ]), ] msgs = PRESUBMIT._CheckAndroidTestJUnitFrameworkImport( mock_input_api, mock_output_api) self.assertEqual(1, len(msgs), 'Expected %d items, found %d: %s' % (1, len(msgs), msgs)) self.assertEqual(2, len(msgs[0].items), 'Expected %d items, found %d: %s' % (2, len(msgs[0].items), msgs[0].items)) self.assertTrue('UsedDeprecatedJUnit.java:1' in msgs[0].items, 'UsedDeprecatedJUnit.java not found in errors') self.assertTrue('UsedDeprecatedJUnitAssert.java:1' in msgs[0].items, 'UsedDeprecatedJUnitAssert not found in errors') class AndroidJUnitBaseClassTest(unittest.TestCase): def testCheckAndroidTestJUnitBaseClass(self): mock_input_api = MockInputApi() mock_output_api = MockOutputApi() mock_input_api.files = [ MockAffectedFile('LalaLand.java', [ 'random stuff' ]), MockAffectedFile('CorrectTest.java', [ '@RunWith(ABC.class);' 'public class CorrectTest {', '}', ]), MockAffectedFile('HistoricallyIncorrectTest.java', [ 'public class Test extends BaseCaseA {', '}', ], old_contents=[ 'public class Test extends BaseCaseB {', '}', ]), MockAffectedFile('CorrectTestWithInterface.java', [ '@RunWith(ABC.class);' 'public class CorrectTest implement Interface {', '}', ]), MockAffectedFile('IncorrectTest.java', [ 'public class IncorrectTest extends TestCase {', '}', ]), MockAffectedFile('IncorrectWithInterfaceTest.java', [ 'public class Test implements X extends BaseClass {', '}', ]), MockAffectedFile('IncorrectMultiLineTest.java', [ 'public class Test implements X, Y, Z', ' extends TestBase {', '}', ]), ] msgs = PRESUBMIT._CheckAndroidTestJUnitInheritance( mock_input_api, mock_output_api) self.assertEqual(1, len(msgs), 'Expected %d items, found %d: %s' % (1, len(msgs), msgs)) self.assertEqual(3, len(msgs[0].items), 'Expected %d items, found %d: %s' % (3, len(msgs[0].items), msgs[0].items)) self.assertTrue('IncorrectTest.java:1' in msgs[0].items, 'IncorrectTest not found in errors') self.assertTrue('IncorrectWithInterfaceTest.java:1' in msgs[0].items, 'IncorrectWithInterfaceTest not found in errors') self.assertTrue('IncorrectMultiLineTest.java:2' in msgs[0].items, 'IncorrectMultiLineTest not found in errors') class LogUsageTest(unittest.TestCase): def testCheckAndroidCrLogUsage(self): mock_input_api = MockInputApi() mock_output_api = MockOutputApi() mock_input_api.files = [ MockAffectedFile('RandomStuff.java', [ 'random stuff' ]), MockAffectedFile('HasAndroidLog.java', [ 'import android.util.Log;', 'some random stuff', 'Log.d("TAG", "foo");', ]), MockAffectedFile('HasExplicitUtilLog.java', [ 'some random stuff', 'android.util.Log.d("TAG", "foo");', ]), MockAffectedFile('IsInBasePackage.java', [ 'package org.chromium.base;', 'private static final String TAG = "cr_Foo";', 'Log.d(TAG, "foo");', ]), MockAffectedFile('IsInBasePackageButImportsLog.java', [ 'package org.chromium.base;', 'import android.util.Log;', 'private static final String TAG = "cr_Foo";', 'Log.d(TAG, "foo");', ]), MockAffectedFile('HasBothLog.java', [ 'import org.chromium.base.Log;', 'some random stuff', 'private static final String TAG = "cr_Foo";', 'Log.d(TAG, "foo");', 'android.util.Log.d("TAG", "foo");', ]), MockAffectedFile('HasCorrectTag.java', [ 'import org.chromium.base.Log;', 'some random stuff', 'private static final String TAG = "cr_Foo";', 'Log.d(TAG, "foo");', ]), MockAffectedFile('HasOldTag.java', [ 'import org.chromium.base.Log;', 'some random stuff', 'private static final String TAG = "cr.Foo";', 'Log.d(TAG, "foo");', ]), MockAffectedFile('HasDottedTag.java', [ 'import org.chromium.base.Log;', 'some random stuff', 'private static final String TAG = "cr_foo.bar";', 'Log.d(TAG, "foo");', ]), MockAffectedFile('HasNoTagDecl.java', [ 'import org.chromium.base.Log;', 'some random stuff', 'Log.d(TAG, "foo");', ]), MockAffectedFile('HasIncorrectTagDecl.java', [ 'import org.chromium.base.Log;', 'private static final String TAHG = "cr_Foo";', 'some random stuff', 'Log.d(TAG, "foo");', ]), MockAffectedFile('HasInlineTag.java', [ 'import org.chromium.base.Log;', 'some random stuff', 'private static final String TAG = "cr_Foo";', 'Log.d("TAG", "foo");', ]), MockAffectedFile('HasUnprefixedTag.java', [ 'import org.chromium.base.Log;', 'some random stuff', 'private static final String TAG = "rubbish";', 'Log.d(TAG, "foo");', ]), MockAffectedFile('HasTooLongTag.java', [ 'import org.chromium.base.Log;', 'some random stuff', 'private static final String TAG = "21_charachers_long___";', 'Log.d(TAG, "foo");', ]), ] msgs = PRESUBMIT._CheckAndroidCrLogUsage( mock_input_api, mock_output_api) self.assertEqual(5, len(msgs), 'Expected %d items, found %d: %s' % (5, len(msgs), msgs)) # Declaration format nb = len(msgs[0].items) self.assertEqual(2, nb, 'Expected %d items, found %d: %s' % (2, nb, msgs[0].items)) self.assertTrue('HasNoTagDecl.java' in msgs[0].items) self.assertTrue('HasIncorrectTagDecl.java' in msgs[0].items) # Tag length nb = len(msgs[1].items) self.assertEqual(1, nb, 'Expected %d items, found %d: %s' % (1, nb, msgs[1].items)) self.assertTrue('HasTooLongTag.java' in msgs[1].items) # Tag must be a variable named TAG nb = len(msgs[2].items) self.assertEqual(1, nb, 'Expected %d items, found %d: %s' % (1, nb, msgs[2].items)) self.assertTrue('HasInlineTag.java:4' in msgs[2].items) # Util Log usage nb = len(msgs[3].items) self.assertEqual(2, nb, 'Expected %d items, found %d: %s' % (2, nb, msgs[3].items)) self.assertTrue('HasAndroidLog.java:3' in msgs[3].items) self.assertTrue('IsInBasePackageButImportsLog.java:4' in msgs[3].items) # Tag must not contain nb = len(msgs[4].items) self.assertEqual(2, nb, 'Expected %d items, found %d: %s' % (2, nb, msgs[4].items)) self.assertTrue('HasDottedTag.java' in msgs[4].items) self.assertTrue('HasOldTag.java' in msgs[4].items) class GoogleAnswerUrlFormatTest(unittest.TestCase): def testCatchAnswerUrlId(self): input_api = MockInputApi() input_api.files = [ MockFile('somewhere/file.cc', ['char* host = ' ' "https://support.google.com/chrome/answer/123456";']), MockFile('somewhere_else/file.cc', ['char* host = ' ' "https://support.google.com/chrome/a/answer/123456";']), ] warnings = PRESUBMIT._CheckGoogleSupportAnswerUrl( input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual(2, len(warnings[0].items)) def testAllowAnswerUrlParam(self): input_api = MockInputApi() input_api.files = [ MockFile('somewhere/file.cc', ['char* host = ' ' "https://support.google.com/chrome/?p=cpn_crash_reports";']), ] warnings = PRESUBMIT._CheckGoogleSupportAnswerUrl( input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) class HardcodedGoogleHostsTest(unittest.TestCase): def testWarnOnAssignedLiterals(self): input_api = MockInputApi() input_api.files = [ MockFile('content/file.cc', ['char* host = "https://www.google.com";']), MockFile('content/file.cc', ['char* host = "https://www.googleapis.com";']), MockFile('content/file.cc', ['char* host = "https://clients1.google.com";']), ] warnings = PRESUBMIT._CheckHardcodedGoogleHostsInLowerLayers( input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual(3, len(warnings[0].items)) def testAllowInComment(self): input_api = MockInputApi() input_api.files = [ MockFile('content/file.cc', ['char* host = "https://www.aol.com"; // google.com']) ] warnings = PRESUBMIT._CheckHardcodedGoogleHostsInLowerLayers( input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) class ForwardDeclarationTest(unittest.TestCase): def testCheckHeadersOnlyOutsideThirdParty(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('somewhere/file.cc', [ 'class DummyClass;' ]), MockAffectedFile('third_party/header.h', [ 'class DummyClass;' ]) ] warnings = PRESUBMIT._CheckUselessForwardDeclarations(mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testNoNestedDeclaration(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('somewhere/header.h', [ 'class SomeClass {', ' protected:', ' class NotAMatch;', '};' ]) ] warnings = PRESUBMIT._CheckUselessForwardDeclarations(mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testSubStrings(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('somewhere/header.h', [ 'class NotUsefulClass;', 'struct SomeStruct;', 'UsefulClass *p1;', 'SomeStructPtr *p2;' ]) ] warnings = PRESUBMIT._CheckUselessForwardDeclarations(mock_input_api, MockOutputApi()) self.assertEqual(2, len(warnings)) def testUselessForwardDeclaration(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('somewhere/header.h', [ 'class DummyClass;', 'struct DummyStruct;', 'class UsefulClass;', 'std::unique_ptr p;' ]) ] warnings = PRESUBMIT._CheckUselessForwardDeclarations(mock_input_api, MockOutputApi()) self.assertEqual(2, len(warnings)) def testBlinkHeaders(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('third_party/blink/header.h', [ 'class DummyClass;', 'struct DummyStruct;', ]), MockAffectedFile('third_party\\blink\\header.h', [ 'class DummyClass;', 'struct DummyStruct;', ]) ] warnings = PRESUBMIT._CheckUselessForwardDeclarations(mock_input_api, MockOutputApi()) self.assertEqual(4, len(warnings)) class RelativeIncludesTest(unittest.TestCase): def testThirdPartyNotWebKitIgnored(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('third_party/test.cpp', '#include "../header.h"'), MockAffectedFile('third_party/test/test.cpp', '#include "../header.h"'), ] mock_output_api = MockOutputApi() errors = PRESUBMIT._CheckForRelativeIncludes( mock_input_api, mock_output_api) self.assertEqual(0, len(errors)) def testNonCppFileIgnored(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('test.py', '#include "../header.h"'), ] mock_output_api = MockOutputApi() errors = PRESUBMIT._CheckForRelativeIncludes( mock_input_api, mock_output_api) self.assertEqual(0, len(errors)) def testInnocuousChangesAllowed(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('test.cpp', '#include "header.h"'), MockAffectedFile('test2.cpp', '../'), ] mock_output_api = MockOutputApi() errors = PRESUBMIT._CheckForRelativeIncludes( mock_input_api, mock_output_api) self.assertEqual(0, len(errors)) def testRelativeIncludeNonWebKitProducesError(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('test.cpp', ['#include "../header.h"']), ] mock_output_api = MockOutputApi() errors = PRESUBMIT._CheckForRelativeIncludes( mock_input_api, mock_output_api) self.assertEqual(1, len(errors)) def testRelativeIncludeWebKitProducesError(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('third_party/blink/test.cpp', ['#include "../header.h']), ] mock_output_api = MockOutputApi() errors = PRESUBMIT._CheckForRelativeIncludes( mock_input_api, mock_output_api) self.assertEqual(1, len(errors)) class NewHeaderWithoutGnChangeTest(unittest.TestCase): def testAddHeaderWithoutGn(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', ''), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertTrue('base/stuff.h' in warnings[0].items) def testModifyHeader(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', '', action='M'), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testDeleteHeader(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', '', action='D'), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testAddHeaderWithGn(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', ''), MockAffectedFile('base/BUILD.gn', 'stuff.h'), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testAddHeaderWithGni(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', ''), MockAffectedFile('base/files.gni', 'stuff.h'), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testAddHeaderWithOther(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', ''), MockAffectedFile('base/stuff.cc', 'stuff.h'), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) def testAddHeaderWithWrongGn(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', ''), MockAffectedFile('base/BUILD.gn', 'stuff_h'), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) def testAddHeadersWithGn(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', ''), MockAffectedFile('base/another.h', ''), MockAffectedFile('base/BUILD.gn', 'another.h\nstuff.h'), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testAddHeadersWithWrongGn(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', ''), MockAffectedFile('base/another.h', ''), MockAffectedFile('base/BUILD.gn', 'another_h\nstuff.h'), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertFalse('base/stuff.h' in warnings[0].items) self.assertTrue('base/another.h' in warnings[0].items) def testAddHeadersWithWrongGn2(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('base/stuff.h', ''), MockAffectedFile('base/another.h', ''), MockAffectedFile('base/BUILD.gn', 'another_h\nstuff_h'), ] warnings = PRESUBMIT._CheckNewHeaderWithoutGnChange( mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertTrue('base/stuff.h' in warnings[0].items) self.assertTrue('base/another.h' in warnings[0].items) class CorrectProductNameInMessagesTest(unittest.TestCase): def testProductNameInDesc(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('chrome/app/google_chrome_strings.grd', [ '', ' Welcome to Chrome!', '', ]), MockAffectedFile('chrome/app/chromium_strings.grd', [ '', ' Welcome to Chromium!', '', ]), ] warnings = PRESUBMIT._CheckCorrectProductNameInMessages( mock_input_api, MockOutputApi()) self.assertEqual(0, len(warnings)) def testChromeInChromium(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('chrome/app/google_chrome_strings.grd', [ '', ' Welcome to Chrome!', '', ]), MockAffectedFile('chrome/app/chromium_strings.grd', [ '', ' Welcome to Chrome!', '', ]), ] warnings = PRESUBMIT._CheckCorrectProductNameInMessages( mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertTrue('chrome/app/chromium_strings.grd' in warnings[0].items[0]) def testChromiumInChrome(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('chrome/app/google_chrome_strings.grd', [ '', ' Welcome to Chromium!', '', ]), MockAffectedFile('chrome/app/chromium_strings.grd', [ '', ' Welcome to Chromium!', '', ]), ] warnings = PRESUBMIT._CheckCorrectProductNameInMessages( mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertTrue( 'chrome/app/google_chrome_strings.grd:2' in warnings[0].items[0]) def testMultipleInstances(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('chrome/app/chromium_strings.grd', [ '', ' Welcome to Chrome!', '', '', ' Chromium is the software you are using.', '', '', ' Google Chrome is the software you are using.', '', ]), ] warnings = PRESUBMIT._CheckCorrectProductNameInMessages( mock_input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertTrue( 'chrome/app/chromium_strings.grd:2' in warnings[0].items[0]) self.assertTrue( 'chrome/app/chromium_strings.grd:8' in warnings[0].items[1]) def testMultipleWarnings(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('chrome/app/chromium_strings.grd', [ '', ' Welcome to Chrome!', '', '', ' Chromium is the software you are using.', '', '', ' Google Chrome is the software you are using.', '', ]), MockAffectedFile('components/components_google_chrome_strings.grd', [ '', ' Welcome to Chrome!', '', '', ' Chromium is the software you are using.', '', '', ' Google Chrome is the software you are using.', '', ]), ] warnings = PRESUBMIT._CheckCorrectProductNameInMessages( mock_input_api, MockOutputApi()) self.assertEqual(2, len(warnings)) self.assertTrue( 'components/components_google_chrome_strings.grd:5' in warnings[0].items[0]) self.assertTrue( 'chrome/app/chromium_strings.grd:2' in warnings[1].items[0]) self.assertTrue( 'chrome/app/chromium_strings.grd:8' in warnings[1].items[1]) class ServiceManifestOwnerTest(unittest.TestCase): def testServiceManifestJsonChangeNeedsSecurityOwner(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('services/goat/manifest.json', [ '{', ' "name": "teleporter",', ' "display_name": "Goat Teleporter",' ' "interface_provider_specs": {', ' }', '}', ]) ] mock_output_api = MockOutputApi() errors = PRESUBMIT._CheckIpcOwners( mock_input_api, mock_output_api) self.assertEqual(1, len(errors)) self.assertEqual( 'Found OWNERS files that need to be updated for IPC security review ' + 'coverage.\nPlease update the OWNERS files below:', errors[0].message) # No warning if already covered by an OWNERS rule. def testNonManifestJsonChangesDoNotRequireSecurityOwner(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('services/goat/species.json', [ '[', ' "anglo-nubian",', ' "angora"', ']', ]) ] mock_output_api = MockOutputApi() errors = PRESUBMIT._CheckIpcOwners( mock_input_api, mock_output_api) self.assertEqual([], errors) def testServiceManifestChangeNeedsSecurityOwner(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('services/goat/public/cpp/manifest.cc', [ '#include "services/goat/public/cpp/manifest.h"', 'const service_manager::Manifest& GetManifest() {}', ])] mock_output_api = MockOutputApi() errors = PRESUBMIT._CheckIpcOwners( mock_input_api, mock_output_api) self.assertEqual(1, len(errors)) self.assertEqual( 'Found OWNERS files that need to be updated for IPC security review ' + 'coverage.\nPlease update the OWNERS files below:', errors[0].message) def testNonServiceManifestSourceChangesDoNotRequireSecurityOwner(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockAffectedFile('some/non/service/thing/foo_manifest.cc', [ 'const char kNoEnforcement[] = "not a manifest!";', ])] mock_output_api = MockOutputApi() errors = PRESUBMIT._CheckIpcOwners( mock_input_api, mock_output_api) self.assertEqual([], errors) class BannedFunctionCheckTest(unittest.TestCase): def testBannedIosObcjFunctions(self): input_api = MockInputApi() input_api.files = [ MockFile('some/ios/file.mm', ['TEST(SomeClassTest, SomeInteraction) {', '}']), MockFile('some/mac/file.mm', ['TEST(SomeClassTest, SomeInteraction) {', '}']), MockFile('another/ios_file.mm', ['class SomeTest : public testing::Test {};']), ] errors = PRESUBMIT._CheckNoBannedFunctions(input_api, MockOutputApi()) self.assertEqual(1, len(errors)) self.assertTrue('some/ios/file.mm' in errors[0].message) self.assertTrue('another/ios_file.mm' in errors[0].message) self.assertTrue('some/mac/file.mm' not in errors[0].message) class NoProductionCodeUsingTestOnlyFunctionsTest(unittest.TestCase): def testTruePositives(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', ['foo_for_testing();']), MockFile('some/path/foo.mm', ['FooForTesting();']), MockFile('some/path/foo.cxx', ['FooForTests();']), MockFile('some/path/foo.cpp', ['foo_for_test();']), ] results = PRESUBMIT._CheckNoProductionCodeUsingTestOnlyFunctions( mock_input_api, MockOutputApi()) self.assertEqual(1, len(results)) self.assertEqual(4, len(results[0].items)) self.assertTrue('foo.cc' in results[0].items[0]) self.assertTrue('foo.mm' in results[0].items[1]) self.assertTrue('foo.cxx' in results[0].items[2]) self.assertTrue('foo.cpp' in results[0].items[3]) def testFalsePositives(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.h', ['foo_for_testing();']), MockFile('some/path/foo.mm', ['FooForTesting() {']), MockFile('some/path/foo.cc', ['::FooForTests();']), MockFile('some/path/foo.cpp', ['// foo_for_test();']), ] results = PRESUBMIT._CheckNoProductionCodeUsingTestOnlyFunctions( mock_input_api, MockOutputApi()) self.assertEqual(0, len(results)) class NoProductionJavaCodeUsingTestOnlyFunctionsTest(unittest.TestCase): def testTruePositives(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('dir/java/src/foo.java', ['FooForTesting();']), MockFile('dir/java/src/bar.java', ['FooForTests(x);']), MockFile('dir/java/src/baz.java', ['FooForTest(', 'y', ');']), MockFile('dir/java/src/mult.java', [ 'int x = SomethingLongHere()', ' * SomethingLongHereForTesting();' ]) ] results = PRESUBMIT._CheckNoProductionCodeUsingTestOnlyFunctionsJava( mock_input_api, MockOutputApi()) self.assertEqual(1, len(results)) self.assertEqual(4, len(results[0].items)) self.assertTrue('foo.java' in results[0].items[0]) self.assertTrue('bar.java' in results[0].items[1]) self.assertTrue('baz.java' in results[0].items[2]) self.assertTrue('mult.java' in results[0].items[3]) def testFalsePositives(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('dir/java/src/foo.xml', ['FooForTesting();']), MockFile('dir/java/src/foo.java', ['FooForTests() {']), MockFile('dir/java/src/bar.java', ['// FooForTest();']), MockFile('dir/java/src/bar2.java', ['x = 1; // FooForTest();']), MockFile('dir/javatests/src/baz.java', ['FooForTest(', 'y', ');']), MockFile('dir/junit/src/baz.java', ['FooForTest(', 'y', ');']), MockFile('dir/junit/src/javadoc.java', [ '/** Use FooForTest(); to obtain foo in tests.' ' */' ]), MockFile('dir/junit/src/javadoc2.java', [ '/** ', ' * Use FooForTest(); to obtain foo in tests.' ' */' ]), ] results = PRESUBMIT._CheckNoProductionCodeUsingTestOnlyFunctionsJava( mock_input_api, MockOutputApi()) self.assertEqual(0, len(results)) class CheckUniquePtrTest(unittest.TestCase): def testTruePositivesNullptr(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('dir/baz.cc', ['std::unique_ptr()']), MockFile('dir/baz-p.cc', ['std::unique_ptr>()']), ] results = PRESUBMIT._CheckUniquePtr(mock_input_api, MockOutputApi()) self.assertEqual(1, len(results)) self.assertTrue('nullptr' in results[0].message) self.assertEqual(2, len(results[0].items)) self.assertTrue('baz.cc' in results[0].items[0]) self.assertTrue('baz-p.cc' in results[0].items[1]) def testTruePositivesConstructor(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('dir/foo.cc', ['return std::unique_ptr(foo);']), MockFile('dir/bar.mm', ['bar = std::unique_ptr(foo)']), MockFile('dir/mult.cc', [ 'return', ' std::unique_ptr(barVeryVeryLongFooSoThatItWouldNotFitAbove);' ]), MockFile('dir/mult2.cc', [ 'barVeryVeryLongLongBaaaaaarSoThatTheLineLimitIsAlmostReached =', ' std::unique_ptr(foo);' ]), MockFile('dir/mult3.cc', [ 'bar = std::unique_ptr(', ' fooVeryVeryVeryLongStillGoingWellThisWillTakeAWhileFinallyThere);' ]), MockFile('dir/multi_arg.cc', [ 'auto p = std::unique_ptr>(new std::pair(T, D));']), ] results = PRESUBMIT._CheckUniquePtr(mock_input_api, MockOutputApi()) self.assertEqual(1, len(results)) self.assertTrue('std::make_unique' in results[0].message) self.assertEqual(6, len(results[0].items)) self.assertTrue('foo.cc' in results[0].items[0]) self.assertTrue('bar.mm' in results[0].items[1]) self.assertTrue('mult.cc' in results[0].items[2]) self.assertTrue('mult2.cc' in results[0].items[3]) self.assertTrue('mult3.cc' in results[0].items[4]) self.assertTrue('multi_arg.cc' in results[0].items[5]) def testFalsePositives(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('dir/foo.cc', ['return std::unique_ptr(foo);']), MockFile('dir/bar.mm', ['bar = std::unique_ptr(foo)']), MockFile('dir/file.cc', ['std::unique_ptr p = Foo();']), MockFile('dir/baz.cc', [ 'std::unique_ptr result = std::make_unique();' ]), MockFile('dir/baz2.cc', [ 'std::unique_ptr result = std::make_unique(' ]), MockFile('dir/nested.cc', ['set>();']), MockFile('dir/nested2.cc', ['map>();']), # Two-argument invocation of std::unique_ptr is exempt because there is # no equivalent using std::make_unique. MockFile('dir/multi_arg.cc', [ 'auto p = std::unique_ptr(new T(), D());']), ] results = PRESUBMIT._CheckUniquePtr(mock_input_api, MockOutputApi()) self.assertEqual(0, len(results)) class CheckNoDirectIncludesHeadersWhichRedefineStrCat(unittest.TestCase): def testBlocksDirectIncludes(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('dir/foo_win.cc', ['#include "shlwapi.h"']), MockFile('dir/bar.h', ['#include ']), MockFile('dir/baz.h', ['#include ']), MockFile('dir/jumbo.h', ['#include "sphelper.h"']), ] results = PRESUBMIT._CheckNoStrCatRedefines(mock_input_api, MockOutputApi()) self.assertEquals(1, len(results)) self.assertEquals(4, len(results[0].items)) self.assertTrue('StrCat' in results[0].message) self.assertTrue('foo_win.cc' in results[0].items[0]) self.assertTrue('bar.h' in results[0].items[1]) self.assertTrue('baz.h' in results[0].items[2]) self.assertTrue('jumbo.h' in results[0].items[3]) def testAllowsToIncludeWrapper(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('dir/baz_win.cc', ['#include "base/win/shlwapi.h"']), MockFile('dir/baz-win.h', ['#include "base/win/atl.h"']), ] results = PRESUBMIT._CheckNoStrCatRedefines(mock_input_api, MockOutputApi()) self.assertEquals(0, len(results)) def testAllowsToCreateWrapper(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('base/win/shlwapi.h', [ '#include ', '#include "base/win/windows_defines.inc"']), ] results = PRESUBMIT._CheckNoStrCatRedefines(mock_input_api, MockOutputApi()) self.assertEquals(0, len(results)) class TranslationScreenshotsTest(unittest.TestCase): # An empty grd file. OLD_GRD_CONTENTS = """ """.splitlines() # A grd file with a single message. NEW_GRD_CONTENTS1 = """ Test string 1 """.splitlines() # A grd file with two messages. NEW_GRD_CONTENTS2 = """ Test string 1 Test string 2 """.splitlines() DO_NOT_UPLOAD_PNG_MESSAGE = ('Do not include actual screenshots in the ' 'changelist. Run ' 'tools/translate/upload_screenshots.py to ' 'upload them instead:') GENERATE_SIGNATURES_MESSAGE = ('You are adding or modifying UI strings.\n' 'To ensure the best translations, take ' 'screenshots of the relevant UI ' '(https://g.co/chrome/translation) and add ' 'these files to your changelist:') REMOVE_SIGNATURES_MESSAGE = ('You removed strings associated with these ' 'files. Remove:') def makeInputApi(self, files): input_api = MockInputApi() input_api.files = files return input_api def testNoScreenshots(self): # CL modified and added messages, but didn't add any screenshots. input_api = self.makeInputApi([ MockAffectedFile('test.grd', self.NEW_GRD_CONTENTS2, self.OLD_GRD_CONTENTS, action='M')]) warnings = PRESUBMIT._CheckTranslationScreenshots(input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual(self.GENERATE_SIGNATURES_MESSAGE, warnings[0].message) self.assertEqual([ os.path.join('test_grd', 'IDS_TEST1.png.sha1'), os.path.join('test_grd', 'IDS_TEST2.png.sha1') ], warnings[0].items) input_api = self.makeInputApi([ MockAffectedFile('test.grd', self.NEW_GRD_CONTENTS2, self.NEW_GRD_CONTENTS1, action='M')]) warnings = PRESUBMIT._CheckTranslationScreenshots(input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual(self.GENERATE_SIGNATURES_MESSAGE, warnings[0].message) self.assertEqual([os.path.join('test_grd', 'IDS_TEST2.png.sha1')], warnings[0].items) def testUnnecessaryScreenshots(self): # CL added a single message and added the png file, but not the sha1 file. input_api = self.makeInputApi([ MockAffectedFile( 'test.grd', self.NEW_GRD_CONTENTS1, self.OLD_GRD_CONTENTS, action='M'), MockAffectedFile( os.path.join('test_grd', 'IDS_TEST1.png'), 'binary', action='A') ]) warnings = PRESUBMIT._CheckTranslationScreenshots(input_api, MockOutputApi()) self.assertEqual(2, len(warnings)) self.assertEqual(self.DO_NOT_UPLOAD_PNG_MESSAGE, warnings[0].message) self.assertEqual([os.path.join('test_grd', 'IDS_TEST1.png')], warnings[0].items) self.assertEqual(self.GENERATE_SIGNATURES_MESSAGE, warnings[1].message) self.assertEqual([os.path.join('test_grd', 'IDS_TEST1.png.sha1')], warnings[1].items) # CL added two messages, one has a png. Expect two messages: # - One for the unnecessary png. # - Another one for missing .sha1 files. input_api = self.makeInputApi([ MockAffectedFile( 'test.grd', self.NEW_GRD_CONTENTS2, self.OLD_GRD_CONTENTS, action='M'), MockAffectedFile( os.path.join('test_grd', 'IDS_TEST1.png'), 'binary', action='A') ]) warnings = PRESUBMIT._CheckTranslationScreenshots(input_api, MockOutputApi()) self.assertEqual(2, len(warnings)) self.assertEqual(self.DO_NOT_UPLOAD_PNG_MESSAGE, warnings[0].message) self.assertEqual([os.path.join('test_grd', 'IDS_TEST1.png')], warnings[0].items) self.assertEqual(self.GENERATE_SIGNATURES_MESSAGE, warnings[1].message) self.assertEqual([ os.path.join('test_grd', 'IDS_TEST1.png.sha1'), os.path.join('test_grd', 'IDS_TEST2.png.sha1') ], warnings[1].items) def testScreenshotsWithSha1(self): # CL added two messages and their corresponding .sha1 files. No warnings. input_api = self.makeInputApi([ MockAffectedFile( 'test.grd', self.NEW_GRD_CONTENTS2, self.OLD_GRD_CONTENTS, action='M'), MockFile( os.path.join('test_grd', 'IDS_TEST1.png.sha1'), 'binary', action='A'), MockFile( os.path.join('test_grd', 'IDS_TEST2.png.sha1'), 'binary', action='A') ]) warnings = PRESUBMIT._CheckTranslationScreenshots(input_api, MockOutputApi()) self.assertEqual([], warnings) def testScreenshotsRemovedWithSha1(self): # Swap old contents with new contents, remove IDS_TEST1 and IDS_TEST2. The # sha1 files associated with the messages should also be removed by the CL. input_api = self.makeInputApi([ MockAffectedFile( 'test.grd', self.OLD_GRD_CONTENTS, self.NEW_GRD_CONTENTS2, action='M'), MockFile(os.path.join('test_grd', 'IDS_TEST1.png.sha1'), 'binary', ""), MockFile(os.path.join('test_grd', 'IDS_TEST2.png.sha1'), 'binary', "") ]) warnings = PRESUBMIT._CheckTranslationScreenshots(input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual(self.REMOVE_SIGNATURES_MESSAGE, warnings[0].message) self.assertEqual([ os.path.join('test_grd', 'IDS_TEST1.png.sha1'), os.path.join('test_grd', 'IDS_TEST2.png.sha1') ], warnings[0].items) # Same as above, but this time one of the .sha1 files is removed. input_api = self.makeInputApi([ MockAffectedFile( 'test.grd', self.OLD_GRD_CONTENTS, self.NEW_GRD_CONTENTS2, action='M'), MockFile(os.path.join('test_grd', 'IDS_TEST1.png.sha1'), 'binary', ''), MockAffectedFile( os.path.join('test_grd', 'IDS_TEST2.png.sha1'), '', 'old_contents', action='D') ]) warnings = PRESUBMIT._CheckTranslationScreenshots(input_api, MockOutputApi()) self.assertEqual(1, len(warnings)) self.assertEqual(self.REMOVE_SIGNATURES_MESSAGE, warnings[0].message) self.assertEqual([os.path.join('test_grd', 'IDS_TEST1.png.sha1')], warnings[0].items) # Remove both sha1 files. No presubmit warnings. input_api = self.makeInputApi([ MockAffectedFile( 'test.grd', self.OLD_GRD_CONTENTS, self.NEW_GRD_CONTENTS2, action='M'), MockFile( os.path.join('test_grd', 'IDS_TEST1.png.sha1'), 'binary', action='D'), MockFile( os.path.join('test_grd', 'IDS_TEST2.png.sha1'), 'binary', action='D') ]) warnings = PRESUBMIT._CheckTranslationScreenshots(input_api, MockOutputApi()) self.assertEqual([], warnings) class DISABLETypoInTest(unittest.TestCase): def testPositive(self): # Verify the typo "DISABLE_" instead of "DISABLED_" in various contexts # where the desire is to disable a test. tests = [ # Disabled on one platform: '#if defined(OS_WIN)\n' '#define MAYBE_FoobarTest DISABLE_FoobarTest\n' '#else\n' '#define MAYBE_FoobarTest FoobarTest\n' '#endif\n', # Disabled on one platform spread cross lines: '#if defined(OS_WIN)\n' '#define MAYBE_FoobarTest \\\n' ' DISABLE_FoobarTest\n' '#else\n' '#define MAYBE_FoobarTest FoobarTest\n' '#endif\n', # Disabled on all platforms: ' TEST_F(FoobarTest, DISABLE_Foo)\n{\n}', # Disabled on all platforms but multiple lines ' TEST_F(FoobarTest,\n DISABLE_foo){\n}\n', ] for test in tests: mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo_unittest.cc', test.splitlines()), ] results = PRESUBMIT._CheckNoDISABLETypoInTests(mock_input_api, MockOutputApi()) self.assertEqual( 1, len(results), msg=('expected len(results) == 1 but got %d in test: %s' % (len(results), test))) self.assertTrue( 'foo_unittest.cc' in results[0].message, msg=('expected foo_unittest.cc in message but got %s in test %s' % (results[0].message, test))) def testIngoreNotTestFiles(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', 'TEST_F(FoobarTest, DISABLE_Foo)'), ] results = PRESUBMIT._CheckNoDISABLETypoInTests(mock_input_api, MockOutputApi()) self.assertEqual(0, len(results)) def testIngoreDeletedFiles(self): mock_input_api = MockInputApi() mock_input_api.files = [ MockFile('some/path/foo.cc', 'TEST_F(FoobarTest, Foo)', action='D'), ] results = PRESUBMIT._CheckNoDISABLETypoInTests(mock_input_api, MockOutputApi()) self.assertEqual(0, len(results)) if __name__ == '__main__': unittest.main()