From 4b9f757cc261c0163ffaaad69b73826604f2360a Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Tue, 18 Feb 2025 16:51:36 +0000 Subject: gdatetime: Fix potential integer overflow in timezone offset handling This one is much harder to trigger than the one in the previous commit, but mixing `gssize` and `gsize` always runs the risk of the former overflowing for very (very very) long input strings. Avoid that possibility by not using the sign of the `tz_offset` to indicate its validity, and instead using the return value of the function. Signed-off-by: Philip Withnall --- glib/gdatetime.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/glib/gdatetime.c b/glib/gdatetime.c index 92a313418..5c4ad461d 100644 --- a/glib/gdatetime.c +++ b/glib/gdatetime.c @@ -1346,8 +1346,10 @@ parse_iso8601_date (const gchar *text, gsize length, return FALSE; } +/* Value returned in tz_offset is valid if and only if the function return value + * is non-NULL. */ static GTimeZone * -parse_iso8601_timezone (const gchar *text, gsize length, gssize *tz_offset) +parse_iso8601_timezone (const gchar *text, gsize length, size_t *tz_offset) { gint i, tz_length, offset_hours, offset_minutes; gint offset_sign = 1; @@ -1415,11 +1417,11 @@ static gboolean parse_iso8601_time (const gchar *text, gsize length, gint *hour, gint *minute, gdouble *seconds, GTimeZone **tz) { - gssize tz_offset = -1; + size_t tz_offset = 0; /* Check for timezone suffix */ *tz = parse_iso8601_timezone (text, length, &tz_offset); - if (tz_offset >= 0) + if (*tz != NULL) length = tz_offset; /* hh:mm:ss(.sss) */ -- 2.30.2