From: Shengjing Zhu Date: Thu, 8 Oct 2020 16:21:02 +0800 Subject: Skip TestDisasm on non x86 https://github.com/google/pprof/pull/561 https://github.com/google/pprof/pull/570 Upstream only disable one test `testDisasm(t, true)`, but the other test `testDisasm(t, false)` needs llvm-objdump. Let's disable both of them. Adding llvm to Build-Depends doesn't make sense. Forwarded: not-needed --- internal/binutils/binutils_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/binutils/binutils_test.go b/internal/binutils/binutils_test.go index 6cd96c8..c151144 100644 --- a/internal/binutils/binutils_test.go +++ b/internal/binutils/binutils_test.go @@ -217,8 +217,8 @@ func testDisasm(t *testing.T, intelSyntax bool) { } func TestDisasm(t *testing.T) { - if runtime.GOOS != "linux" && runtime.GOOS != "darwin" { - t.Skip("This test only works on Linux or Mac") + if runtime.GOARCH != "amd64" || (runtime.GOOS != "linux" && runtime.GOOS != "darwin") { + t.Skip("This test only works on x86-64 Linux or Mac") } testDisasm(t, true) testDisasm(t, false)