package Module::CPANTS::Kwalitee::FindModules; use warnings; use strict; use File::Spec::Functions qw(catfile); our $VERSION = '1.02'; $VERSION =~ s/_//; ## no critic sub order { 30 } ################################################################## # Analyse ################################################################## sub analyse { my $class = shift; my $me = shift; my $files = $me->d->{files_array} || []; if ($me->d->{meta_yml} && $me->d->{meta_yml}{provides}) { my $provides = $me->d->{meta_yml}{provides}; for my $module (sort keys %$provides) { my $data = $provides->{$module}; next unless ref $data eq ref {}; # ignore wrong format my $file = $data->{file} || ''; my $found = { module => $module, file => $file, in_basedir => 0, in_lib => 0, }; my $loc; if ($file =~ /^lib\W/) { $found->{in_lib} = 1; } elsif ($file !~ /\//) { $found->{in_basedir} = 1; } push @{$me->d->{modules}}, $found; if (exists $me->d->{files_hash}{$file}) { (my $path_part = $module) =~ s|::|/|g; if ($file =~ /\b$path_part\.pm$/) { $me->d->{files_hash}{$file}{module} = $module; } elsif ("$path_part.pm" =~ /\b$file$/) { $me->d->{files_hash}{$file}{module} ||= $module; } } else { $found->{not_exists} = 1; } } } else { my %in_basedir = map {$_ => 1} grep {/^[^\/]+\.pm$/} @$files; foreach my $file (@$files) { next unless $file =~ /\.pm$/; next if $file =~ m{^x?t/}; next if $file =~ m{^test/}; next if $file =~ m/^(bin|scripts?|ex|eg|examples?|samples?|demos?)\/\w/i; next if $file =~ m{^inc/}; # skip Module::Install stuff next if $file =~ m{^(local|perl5|fatlib)/}; # proper file in lib/ if ($file =~ m|^lib/(.*)\.pm$|) { my $module = $1; $module =~ s|/|::|g; push (@{$me->d->{modules}}, { module => $module, file => $file, in_basedir => 0, in_lib => 1, }); $me->d->{files_hash}{$file}{module} = $module; } else { # open file and find first package my ($basename) = $file =~ /(\w+)\.pm/; my $module; my $max_lines_to_look_at = 666; open (my $fh, "<", catfile($me->distdir, $file)) or die "__PACKAGE__: Cannot open $file to find package declaration: $!"; while (my $line = <$fh>) { next if $line =~ /^\s*#/; # ignore comments if ($line =~ /^\s*package\s*(.*?)\s*;/) { $module = $1; last if $basename and $module =~ /\b$basename$/; } last if $line =~ /^__(DATA|END)__/; $max_lines_to_look_at--; last unless $max_lines_to_look_at; } # try to guess from filename unless ($module) { $file =~ m|(.*)\.pm$|; $module = $1; $module =~ s|^[a-z]+/||; # remove lowercase prefixes which most likely are not part of the distname (but something like 'src/') $module =~ s|/|::|g; } if ($module) { push(@{$me->d->{modules}}, { module => $module, file => $file, in_basedir => $in_basedir{$file} ? 1 : 0, in_lib => 0, }); $me->d->{files_hash}{$file}{module} = $module; } } } } for my $file (keys %{$me->d->{files_hash}}) { next unless $file =~ /^inc\/(.+)\.pm/; my $module = $1; $module =~ s|/|::|g; push @{$me->d->{included_modules} ||= []}, $module; } if (exists $me->d->{modules}) { $me->d->{modules} = [sort {$a->{module} cmp $b->{module}} @{$me->d->{modules}}]; } if (exists $me->d->{included_modules}) { $me->d->{included_modules} = [sort @{$me->d->{included_modules}}]; } return 1; } ################################################################## # Kwalitee Indicators ################################################################## sub kwalitee_indicators { return [ { name => 'proper_libs', error => q{There is more than one .pm file in the base dir, or the .pm files are not in lib/ directory.}, remedy => q{Move your *.pm files in a directory named 'lib'. The directory structure should look like 'lib/Your/Module.pm' for a module named 'Your::Module'. If you need to provide additional files, e.g. for testing, that should not be considered for Kwalitee, then you should look at the 'provides' map in META.yml to limit the files scanned; or use the 'no_index' map to exclude parts of the distribution.}, is_extra => 1, code => sub { my $d = shift; my @modules = @{$d->{modules} || []}; return 1 unless @modules; my @not_in_lib = grep { !$_->{in_lib} } @modules; return 1 unless @not_in_lib; my @in_basedir = grep { $_->{in_basedir} } @not_in_lib; return 1 if @in_basedir == 1; $d->{error}{proper_libs} = join ', ', map {$_->{file}} @not_in_lib; return 0; }, details => sub { my $d = shift; my @modules = @{$d->{modules} || []}; return "No modules were found" unless @modules; return "The following files were found: ".$d->{error}{proper_libs}; }, }, { name => 'no_missing_files_in_provides', error => q{Provides field in the META.yml lists a file that does not found in the distribution.}, remedy => q{Use authoring tool like Dist::Zilla, Milla, and Minilla to generate correct provides.}, is_extra => 1, code => sub { my $d = shift; my @modules = @{$d->{modules} || []}; return 1 unless @modules; if (my @not_exists = grep { $_->{not_exists} } @modules) { $d->{error}{no_missing_files_in_provides} = join ', ', map {$_->{file}} @not_exists; return 0; } return 1; }, details => sub { my $d = shift; my @modules = @{$d->{modules} || []}; return "No modules were found" unless @modules; return "The following files were missing: ".$d->{error}{no_missing_files_in_provides}; }, }, ]; } q{Favourite record of the moment: Fat Freddys Drop: Based on a true story}; __END__ =encoding UTF-8 =head1 NAME Module::CPANTS::Kwalitee::FindModules - Find modules provided by a dist =head1 SYNOPSIS Finds and reports all modules (i.e. F<*.pm> files) in a distribution. =head1 DESCRIPTION =head2 Methods =head3 order Defines the order in which Kwalitee tests should be run. Returns C<30>, as data generated by C is used by other tests. =head3 analyse C first looks in C and F for C<*.pm> files. If it doesn't find any, it looks in the whole dist, but the C kwalitee point is only awarded if the modules are F or there's only one module in C. =head3 kwalitee_indicators Returns the Kwalitee Indicators data structure. =over =item * proper_libs =back =head1 SEE ALSO L =head1 AUTHOR L =head1 COPYRIGHT AND LICENSE Copyright © 2003–2006, 2009 L You may use and distribute this module according to the same terms that Perl is distributed under.