Subject: Running with sh makes libpulp confused
From: Gabriel F. T. Gomes <gabriel@inconstante.net.br>
Forwarded: not-needed

When the test program is executed with 'sh -c <test>', libpulp thinks
that the binary being executed is 'sh' instead of '<test>' and it can't
find the libraries <test> is linked against.

In the log file for the test run, a message related to a missing target
library will be displayed. For example, for the numserv test:

    error: could not apply .libs/libdozens_livepatch1.so to sh (pid <n>): Target library not loaded

diff --git a/tests/testsuite.py b/tests/testsuite.py
index 4e4ba4a..867dc17 100755
--- a/tests/testsuite.py
+++ b/tests/testsuite.py
@@ -102,8 +102,6 @@ class spawn(pexpect.spawn):
     if testname[0] != '/':
       testname = './' + testname
 
-    testname = '/usr/bin/sh -c ' + '\''+ testname + '\''
-
     # if TEST_THROUGH_VALGRIND environment variable is defined, append valgrind
     # call on testname. We actually call valgrind on the `sh` call, and it
     # still catch memory issues while avoiding libpulp problems regarding