Description: Adding final qualifier for some variables used by an inner class
Author: Pierre Gruet <pgtdebian@free.fr>
Last-Update: 2020-05-12
Forwarded: brinn@ethz.ch

--- a/source/java/ch/systemsx/cisd/hdf5/HDF5BaseWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5BaseWriter.java
@@ -1038,7 +1038,7 @@
      */
     HDF5DataSet createDataSet(final String objectPath, final long storageDataTypeId,
             final HDF5AbstractStorageFeatures features, final long[] dimensions,
-            final long[] chunkSizeOrNull, int elementLength)
+            final long[] chunkSizeOrNull, final int elementLength)
     {
         final ICallableWithCleanUp<HDF5DataSet> openDataSetCallable =
                 new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5IntWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5IntWriter.java
@@ -281,7 +281,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -659,7 +659,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDIntArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDIntArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -787,7 +787,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -824,7 +824,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5ShortWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5ShortWriter.java
@@ -281,7 +281,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -659,7 +659,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDShortArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDShortArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -787,7 +787,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -824,7 +824,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5ByteWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5ByteWriter.java
@@ -281,7 +281,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -659,7 +659,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDByteArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDByteArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -787,7 +787,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -824,7 +824,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5FloatWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5FloatWriter.java
@@ -280,7 +280,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -658,7 +658,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDFloatArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDFloatArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -786,7 +786,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -823,7 +823,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5UnsignedByteWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5UnsignedByteWriter.java
@@ -280,7 +280,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -658,7 +658,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDByteArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDByteArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -786,7 +786,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -823,7 +823,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5DoubleWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5DoubleWriter.java
@@ -280,7 +280,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -658,7 +658,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDDoubleArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDDoubleArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -786,7 +786,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -823,7 +823,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5LongWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5LongWriter.java
@@ -281,7 +281,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -659,7 +659,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDLongArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDLongArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -787,7 +787,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -824,7 +824,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5UnsignedShortWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5UnsignedShortWriter.java
@@ -280,7 +280,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -658,7 +658,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDShortArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDShortArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -786,7 +786,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -823,7 +823,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5UnsignedIntWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5UnsignedIntWriter.java
@@ -280,7 +280,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -658,7 +658,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDIntArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDIntArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -786,7 +786,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -823,7 +823,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()
--- a/source/java/ch/systemsx/cisd/hdf5/HDF5UnsignedLongWriter.java
+++ b/source/java/ch/systemsx/cisd/hdf5/HDF5UnsignedLongWriter.java
@@ -280,7 +280,7 @@
     }
 
     @Override
-    public void createArray(String objectPath, HDF5DataSetTemplate template)
+    public void createArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         assert objectPath != null;
 
@@ -658,7 +658,7 @@
     }
 
     @Override
-    public void writeMDArray(String objectPath, MDLongArray data, HDF5DataSetTemplate template)
+    public void writeMDArray(final String objectPath, final MDLongArray data, final HDF5DataSetTemplate template)
     {
         assert data != null;
         baseWriter.checkOpen();
@@ -786,7 +786,7 @@
     }
 
     @Override
-    public void createMDArray(String objectPath, HDF5DataSetTemplate template)
+    public void createMDArray(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<Void> createRunnable = new ICallableWithCleanUp<Void>()
@@ -823,7 +823,7 @@
     }
 
     @Override
-    public HDF5DataSet createMDArrayAndOpen(String objectPath, HDF5DataSetTemplate template)
+    public HDF5DataSet createMDArrayAndOpen(final String objectPath, final HDF5DataSetTemplate template)
     {
         baseWriter.checkOpen();
         final ICallableWithCleanUp<HDF5DataSet> createRunnable = new ICallableWithCleanUp<HDF5DataSet>()