Revision: libxml-ruby--dilinger--0--patch-2
Archive: dilinger@voxel.net--2004-public
Creator: Andres Salomon <dilinger@voxel.net>
Date: Wed Dec 29 07:46:21 EST 2004
Standard-date: 2004-12-29 12:46:21 GMT
Modified-files: ruby_xml_document.c ruby_xml_node_set.c
    ruby_xml_parser.c
New-patches: dilinger@voxel.net--2004-public/libxml-ruby--dilinger--0--patch-2
Summary: remove unnecessary (and invalid) casts
Keywords: 

Newer gccs don't like casting of lvalues; the rvalue cast was useless, as
well, since a void* is simply being assigned to a void*.  Casting to
intermediate struct*s doesn't do a damned thing.


* finding or making patch-1
* build reference tree for dilinger@voxel.net--2004-public/libxml-ruby--dilinger--0--patch-1
* from import revision: dilinger@voxel.net--2004-public/libxml-ruby--mainline--0--base-0
* patching for revision: dilinger@voxel.net--2004-public/libxml-ruby--dilinger--0--base-0
* patching for revision: dilinger@voxel.net--2004-public/libxml-ruby--dilinger--0--patch-1
* finding or making patch-2
* build reference tree for dilinger@voxel.net--2004-public/libxml-ruby--dilinger--0--patch-2
* from import revision: dilinger@voxel.net--2004-public/libxml-ruby--mainline--0--base-0
* patching for revision: dilinger@voxel.net--2004-public/libxml-ruby--dilinger--0--base-0
* patching for revision: dilinger@voxel.net--2004-public/libxml-ruby--dilinger--0--patch-1
* patching for revision: dilinger@voxel.net--2004-public/libxml-ruby--dilinger--0--patch-2
* computing changeset
A  {arch}/libxml-ruby/libxml-ruby--dilinger/libxml-ruby--dilinger--0/dilinger@voxel.net--2004-public/patch-log/patch-2
M  ruby_xml_document.c
M  ruby_xml_node_set.c
M  ruby_xml_parser.c
* changeset report
* added files

    {arch}/libxml-ruby/libxml-ruby--dilinger/libxml-ruby--dilinger--0/dilinger@voxel.net--2004-public/patch-log/patch-2

* modified files

--- orig/ruby_xml_document.c
+++ mod/ruby_xml_document.c
@@ -317,15 +317,15 @@
   case RUBY_LIBXML_SRC_TYPE_NULL:
     break;
   case RUBY_LIBXML_SRC_TYPE_FILE:
-    (rx_file_data *)data = (rx_file_data *)rxd->data;
+    data = rxd->data;
     free((rx_file_data *)data);
     break;
   case RUBY_LIBXML_SRC_TYPE_STRING:
-    (rx_string_data *)data = (rx_string_data *)rxd->data;
+    data = rxd->data;
     free((rx_string_data *)data);
     break;
   case RUBY_LIBXML_SRC_TYPE_IO:
-    (rx_io_data *)data = (rx_io_data *)rxd->data;
+    data = rxd->data;
     free((rx_io_data *)data);
     break;
   default:


--- orig/ruby_xml_node_set.c
+++ mod/ruby_xml_node_set.c
@@ -58,7 +58,7 @@
   case RUBY_LIBXML_SRC_TYPE_NULL:
     break;
   case RUBY_LIBXML_SRC_TYPE_XPATH:
-    (rx_xpath_data *)data = (rx_file_data *)rxnset->data;
+    data = rxnset->data;
     free((rx_xpath_data *)data);
   default:
     rb_fatal("Unknown data type, %d", rxnset->data_type);


--- orig/ruby_xml_parser.c
+++ mod/ruby_xml_parser.c
@@ -479,15 +479,15 @@
   case RUBY_LIBXML_SRC_TYPE_NULL:
     break;
   case RUBY_LIBXML_SRC_TYPE_FILE:
-    (rx_file_data *)data = (rx_file_data *)rxp->data;
+    data = rxp->data;
     free((rx_file_data *)data);
     break;
   case RUBY_LIBXML_SRC_TYPE_STRING:
-    (rx_string_data *)data = (rx_string_data *)rxp->data;
+    data = rxp->data;
     free((rx_string_data *)data);
     break;
   case RUBY_LIBXML_SRC_TYPE_IO:
-    (rx_io_data *)data = (rx_io_data *)rxp->data;
+    data = rxp->data;
     free((rx_io_data *)data);
     break;
   default: