From b13c11ee1838a1d68962b9c5a92c3c06fc02fa40 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Wed, 4 Dec 2019 15:54:43 +0100 Subject: coolkey: Make sure the object ID is unique when filling list Thanks to oss-fuzz https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19208 --- src/libopensc/card-coolkey.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libopensc/card-coolkey.c b/src/libopensc/card-coolkey.c index b97559cc..e5fd3795 100644 --- a/src/libopensc/card-coolkey.c +++ b/src/libopensc/card-coolkey.c @@ -1956,6 +1956,11 @@ coolkey_add_object(coolkey_private_data_t *priv, unsigned long object_id, const new_object.id = object_id; new_object.length = object_length; + /* The object ID needs to be unique */ + if (coolkey_find_object_by_id(&priv->objects_list, object_id) != NULL) { + return SC_ERROR_INTERNAL; + } + if (object_data) { new_object.data = malloc(object_length + add_v1_record); if (new_object.data == NULL) { -- 2.20.1