From 68d2e5b5da2da0a22e07c605ca4dccd57a0e3cb6 Mon Sep 17 00:00:00 2001 From: Thomas Goirand Date: Fri, 4 Aug 2017 21:47:18 +0200 Subject: Remove networking tests Upstream is attempting connection to 192.0.2.1 on port 80, and expects it to always timeout. However, some Debian users may well have a web server running on that IP address, meaning the test would fail in such setup (even if this is reserved IANA IPs). Therefore, removing such bad tests. . Also, these tests have been failing for a reason on my arm64 builder, probably because it's a slow machine. Forwarded: no Last-Update: 2016-07-19 --- tests/greenio_test.py | 20 -------------------- tests/socket_test.py | 7 ------- 2 files changed, 27 deletions(-) --- a/tests/greenio_test.py +++ b/tests/greenio_test.py @@ -75,18 +75,6 @@ # 3.x io write to closed file-like pbject raises ValueError self.assertRaises(ValueError, fd.write, b'a') - def test_connect_timeout(self): - s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) - s.settimeout(0.1) - gs = greenio.GreenSocket(s) - - try: - expect_socket_timeout(gs.connect, ('192.0.2.1', 80)) - except OSError as e: - # unreachable is also a valid outcome - if get_errno(e) not in (errno.EHOSTUNREACH, errno.ENETUNREACH): - raise - def test_accept_timeout(self): s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) s.bind(('', 0)) @@ -96,14 +84,6 @@ gs = greenio.GreenSocket(s) expect_socket_timeout(gs.accept) - def test_connect_ex_timeout(self): - s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) - s.settimeout(0.1) - gs = greenio.GreenSocket(s) - e = gs.connect_ex(('192.0.2.1', 80)) - if e not in (errno.EHOSTUNREACH, errno.ENETUNREACH): - self.assertEqual(e, errno.EAGAIN) - def test_recv_timeout(self): listener = greenio.GreenSocket(socket.socket()) listener.bind(('', 0)) --- a/tests/socket_test.py +++ b/tests/socket_test.py @@ -9,13 +9,6 @@ import tests -def test_create_connection_error(): - try: - socket.create_connection(('192.0.2.1', 80), timeout=0.1) - except OSError: - pass - - def test_recv_type(): # https://github.com/eventlet/eventlet/issues/245 # socket recv returning multiple data types