Description: disable `report_on_exception` causing test failures on ruby2.5
Author: Myron Marston <myron.marston@gmail.com>
Bug: https://github.com/rspec/rspec-expectations/issues/1031
Origin: https://github.com/rspec/rspec-expectations/commit/afcd9a294b65ebfff78976bebcf62d72385b5b4d.patch
Applied-Upstream: yes
Last-Update: 2018-02-05

--- a/rspec-expectations/spec/rspec/expectations/failure_aggregator_spec.rb
+++ b/rspec-expectations/spec/rspec/expectations/failure_aggregator_spec.rb
@@ -216,6 +216,19 @@ def expect_error_included_in_aggregated_failure(error)
     end
 
     context "when an expectation failure happens in another thread" do
+      # On Ruby 2.5+, the new `report_on_exception` causes the errors in the threads
+      # to print warnings, which our rspec-support test harness converts into a test
+      # failure since we want to enforce warnings-free code. To prevent the warning,
+      # we need to disable the setting here.
+      if Thread.respond_to?(:report_on_exception)
+        around do |example|
+          orig = Thread.report_on_exception
+          Thread.report_on_exception = false
+          example.run
+          Thread.report_on_exception = orig
+        end
+      end
+
       it "includes the failure in the failures array if there are other failures" do
         expect {
           aggregate_failures do