From: =?utf-8?q?Jeremy_B=C3=ADcha?= Date: Thu, 6 Nov 2025 13:38:35 -0500 Subject: Revert "Add Audit feature" This reverts commit d084c625ed1d41cd394c6f4f52c7406a75c7c130. This requires python3-pyhibp which is not yet in Debian --- data/gtk/database_settings_dialog.ui | 70 -------------- gsecrets/widgets/database_settings_dialog.py | 138 --------------------------- 2 files changed, 208 deletions(-) diff --git a/data/gtk/database_settings_dialog.ui b/data/gtk/database_settings_dialog.ui index 9d407d5..ed45fb5 100644 --- a/data/gtk/database_settings_dialog.ui +++ b/data/gtk/database_settings_dialog.ui @@ -212,75 +212,5 @@ - - - report_page - Audit - find-location-symbolic - - - Statistics - - - Unique Passwords - - - - - - Reused Passwords - - - - - - - - Weak Passwords - - - - - Check passwords for online breaches - Ask online whether your passwords have been hacked. The passwords won't be sent online! The following passwords have been leaked: - - - - - button - - - view-refresh-symbolic - center - - - - - - - - - spinner - - - center - - - - - - - - - - diff --git a/gsecrets/widgets/database_settings_dialog.py b/gsecrets/widgets/database_settings_dialog.py index 6e1a813..b81a994 100644 --- a/gsecrets/widgets/database_settings_dialog.py +++ b/gsecrets/widgets/database_settings_dialog.py @@ -7,12 +7,8 @@ import typing from gettext import gettext as _ from pathlib import Path, PurePath -import pyhibp -import requests from gi.repository import Adw, Gio, GLib, GObject, Gtk -from pyhibp import pwnedpasswords as pw -from gsecrets.password_generator import strength from gsecrets.utils import ( compare_passwords, format_time, @@ -23,10 +19,6 @@ if typing.TYPE_CHECKING: from gsecrets.provider.base_provider import BaseProvider -WEAK = 0.5 -MEDIUM = 1.5 - - @Gtk.Template(resource_path="/org/gnome/World/Secrets/gtk/database_settings_dialog.ui") class DatabaseSettingsDialog(Adw.PreferencesDialog): # pylint: disable=too-many-instance-attributes @@ -62,13 +54,6 @@ class DatabaseSettingsDialog(Adw.PreferencesDialog): current_password_entry = Gtk.Template.Child() provider_group = Gtk.Template.Child() banner = Gtk.Template.Child() - unique_passwords_row = Gtk.Template.Child() - reused_passwords_row = Gtk.Template.Child() - weak_password_group = Gtk.Template.Child() - hibp_group = Gtk.Template.Child() - hibp_stack = Gtk.Template.Child() - hibp_spinner = Gtk.Template.Child() - hibp_refresh_button = Gtk.Template.Child() confirm_password_entry = Gtk.Template.Child() new_password_entry = Gtk.Template.Child() @@ -103,129 +88,6 @@ class DatabaseSettingsDialog(Adw.PreferencesDialog): self.signals.append((show_id, key_provider)) self.signals.append((hide_id, key_provider)) - self._fill_audit() - - def _fill_audit(self): - passwords = [] - weak_passwords_found = False - - for entry in self.database_manager.db.find_entries(): - if entry.password: - passwords.append(entry.password) - - pwd_strength = strength(entry.password) - if pwd_strength < MEDIUM: - weak_passwords_found = True - - row = Adw.ActionRow() - if entry.title: - row.set_title(entry.title) - if entry.username: - row.set_subtitle(entry.username) - - score = Gtk.Label() - if pwd_strength < WEAK: - score.set_label(_("Insecure")) - else: - score.set_label(_("Weak")) - - row.add_suffix(score) - self.weak_password_group.add(row) - - if not weak_passwords_found: - row = Adw.ActionRow() - row.set_title(_("No weak passwords found")) - self.weak_password_group.add(row) - - # Statistics - reused_dict = { - pwd: passwords.count(pwd) for pwd in passwords if passwords.count(pwd) > 1 - } - self.reused_passwords_row.set_subtitle(str(len(reused_dict))) - - unique_dict = { - pwd: passwords.count(pwd) for pwd in passwords if passwords.count(pwd) == 1 - } - self.unique_passwords_row.set_subtitle(str(len(unique_dict))) - - thread = threading.Thread(target=self.check_network_access) - thread.daemon = True - thread.start() - - self.hibp_stack.set_visible_child_name("button") - - def check_network_access(self): - reachable = True - status_code_ok = True - - try: - check_url = requests.get("https://haveibeenpwned.com/", timeout=3) - except requests.exceptions.RequestException: - reachable = False - else: - status_code_ok = check_url.status_code == requests.codes.ok - - GLib.idle_add(self.update_hibp_ui, reachable, status_code_ok) - - def update_hibp_ui(self, reachable, status_code_ok): - if not reachable: - self.hibp_refresh_button.set_sensitive(False) - - row = Adw.ActionRow() - row.set_title("No Network Access Configured") - row.set_subtitle("Add --share=network to your Flatpak manifest") - self.hibp_group.add(row) - return - - self.hibp_refresh_button.set_sensitive(status_code_ok) - - @Gtk.Template.Callback() - def on_hibp_refresh_clicked(self, _entry: Gtk.Entry) -> None: - self.hibp_stack.set_visible_child_name("spinner") - self._hibp_refresh_async(self._on_hibp_refresh) - - def _hibp_refresh_async(self, callback: Gio.AsyncReadyCallback) -> None: - def lookup(task, _source_object, _task_data, _cancellable): - rows = [] - - for entry in self.database_manager.db.find_entries(): - pyhibp.set_user_agent(ua="Secrets") - if entry.password: - resp = pw.is_password_breached(password=entry.password) - if resp: - row = Adw.ActionRow() - if title := entry.title: - row.set_title(title) - - if username := entry.username: - row.set_subtitle(username) - - rows.append(row) - - task.return_value(rows) - - task = Gio.Task.new(self, None, callback) - task.run_in_thread(lookup) - - def _hibp_refresh_finish(self, result): - return result.propagate_value() - - def _on_hibp_refresh( - self, - _dialog: DatabaseSettingsDialog, - result: Gio.AsyncResult, - ) -> None: - self.hibp_stack.set_visible(False) - _success, rows = self._hibp_refresh_finish(result) - - if rows: - for row in rows: - self.hibp_group.add(row) - else: - row = Adw.ActionRow() - row.set_title(_("No records found")) - self.hibp_group.add(row) - def do_closed(self): for signal_id, obj in self.signals: obj.disconnect(signal_id)