From: =?utf-8?q?David_Pr=C3=A9vot?= Date: Wed, 29 Jan 2025 23:21:32 +0100 Subject: Group network for test failing without network Forwarded: no --- src/Symfony/Component/Cache/Tests/Traits/RedisTraitTest.php | 1 + .../Component/HtmlSanitizer/Tests/Reference/W3CReferenceTest.php | 3 +++ src/Symfony/Component/HttpClient/Tests/RetryableHttpClientTest.php | 2 ++ src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php | 2 ++ .../Component/Mailer/Tests/Transport/Smtp/Stream/SocketStreamTest.php | 2 ++ .../Bridge/Redis/Tests/Transport/RedisTransportFactoryTest.php | 1 + src/Symfony/Component/Process/Tests/ProcessTest.php | 2 ++ src/Symfony/Component/VarDumper/Tests/Caster/CurlCasterTest.php | 2 ++ 8 files changed, 15 insertions(+) diff --git a/src/Symfony/Component/Cache/Tests/Traits/RedisTraitTest.php b/src/Symfony/Component/Cache/Tests/Traits/RedisTraitTest.php index dea9cdf..d67c772 100644 --- a/src/Symfony/Component/Cache/Tests/Traits/RedisTraitTest.php +++ b/src/Symfony/Component/Cache/Tests/Traits/RedisTraitTest.php @@ -85,6 +85,7 @@ class RedisTraitTest extends TestCase * @see https://github.com/phpredis/phpredis/issues/1920 */ #[Group('integration')] + #[Group('network')] public function testPconnectSelectsCorrectDatabase() { if (!class_exists(\Redis::class)) { diff --git a/src/Symfony/Component/HtmlSanitizer/Tests/Reference/W3CReferenceTest.php b/src/Symfony/Component/HtmlSanitizer/Tests/Reference/W3CReferenceTest.php index 51a4a7d..af9642e 100644 --- a/src/Symfony/Component/HtmlSanitizer/Tests/Reference/W3CReferenceTest.php +++ b/src/Symfony/Component/HtmlSanitizer/Tests/Reference/W3CReferenceTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\HtmlSanitizer\Tests\Reference; +use PHPUnit\Framework\Attributes\Group; use PHPUnit\Framework\TestCase; use Symfony\Component\HtmlSanitizer\Reference\W3CReference; @@ -19,6 +20,7 @@ use Symfony\Component\HtmlSanitizer\Reference\W3CReference; */ class W3CReferenceTest extends TestCase { + #[Group('network')] public function testElements() { $referenceElements = array_values(array_merge(array_keys(W3CReference::HEAD_ELEMENTS), array_keys(W3CReference::BODY_ELEMENTS))); @@ -30,6 +32,7 @@ class W3CReferenceTest extends TestCase ); } + #[Group('network')] public function testAttributes() { $this->assertSame( diff --git a/src/Symfony/Component/HttpClient/Tests/RetryableHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/RetryableHttpClientTest.php index 6d61e93..fad7a9b 100644 --- a/src/Symfony/Component/HttpClient/Tests/RetryableHttpClientTest.php +++ b/src/Symfony/Component/HttpClient/Tests/RetryableHttpClientTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\HttpClient\Tests; +use PHPUnit\Framework\Attributes\Group; use PHPUnit\Framework\TestCase; use Symfony\Component\HttpClient\Exception\ServerException; use Symfony\Component\HttpClient\Exception\TransportException; @@ -149,6 +150,7 @@ class RetryableHttpClientTest extends TestCase } } + #[Group('network')] public function testRetryWithDnsIssue() { $client = new RetryableHttpClient( diff --git a/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php b/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php index f2eef23..4982e9b 100644 --- a/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php +++ b/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php @@ -110,6 +110,7 @@ class AdapterTest extends LdapTestCase $query->execute(); } + #[Group('network')] public function testLdapQueryScopeBase() { $ldap = new Adapter($this->getLdapConfig()); @@ -126,6 +127,7 @@ class AdapterTest extends LdapTestCase $this->assertEquals(['Fabien Potencier'], $entry->getAttribute('cn')); } + #[Group('network')] public function testLdapQueryScopeOneLevel() { $ldap = new Adapter($this->getLdapConfig()); diff --git a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/Stream/SocketStreamTest.php b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/Stream/SocketStreamTest.php index f06160d..5105fbb 100644 --- a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/Stream/SocketStreamTest.php +++ b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/Stream/SocketStreamTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\Mailer\Tests\Transport\Smtp\Stream; +use PHPUnit\Framework\Attributes\Group; use PHPUnit\Framework\TestCase; use Symfony\Component\Mailer\Exception\TransportException; use Symfony\Component\Mailer\Transport\Smtp\Stream\SocketStream; @@ -27,6 +28,7 @@ class SocketStreamTest extends TestCase $s->initialize(); } + #[Group('network')] public function testSocketErrorBeforeConnectError() { $this->expectException(TransportException::class); diff --git a/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/RedisTransportFactoryTest.php b/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/RedisTransportFactoryTest.php index 2095fc0..b2dba72 100644 --- a/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/RedisTransportFactoryTest.php +++ b/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/RedisTransportFactoryTest.php @@ -41,6 +41,7 @@ class RedisTransportFactoryTest extends TestCase #[DataProvider('createTransportProvider')] #[Group('integration')] + #[Group('network')] public function testCreateTransport(string $dsn, array $options = []) { $this->skipIfRedisUnavailable(); diff --git a/src/Symfony/Component/Process/Tests/ProcessTest.php b/src/Symfony/Component/Process/Tests/ProcessTest.php index 5bbfde0..db56c76 100644 --- a/src/Symfony/Component/Process/Tests/ProcessTest.php +++ b/src/Symfony/Component/Process/Tests/ProcessTest.php @@ -1651,6 +1651,7 @@ class ProcessTest extends TestCase $this->assertFalse($process->isRunning()); } + #[Group('network')] public function testIgnoringSignal() { if (!\function_exists('pcntl_signal')) { @@ -1667,6 +1668,7 @@ class ProcessTest extends TestCase } // This test ensure that the previous test is reliable, in case of the sleep command ignoring the SIGTERM signal + #[Group('network')] public function testNotIgnoringSignal() { if (!\function_exists('pcntl_signal')) { diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/CurlCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/CurlCasterTest.php index 903b82a..a05eff3 100644 --- a/src/Symfony/Component/VarDumper/Tests/Caster/CurlCasterTest.php +++ b/src/Symfony/Component/VarDumper/Tests/Caster/CurlCasterTest.php @@ -11,6 +11,7 @@ namespace Symfony\Component\VarDumper\Tests\Caster; +use PHPUnit\Framework\Attributes\Group; use PHPUnit\Framework\Attributes\RequiresPhpExtension; use PHPUnit\Framework\TestCase; use Symfony\Component\VarDumper\Test\VarDumperTestTrait; @@ -20,6 +21,7 @@ class CurlCasterTest extends TestCase { use VarDumperTestTrait; + #[Group('network')] public function testCastCurl() { $ch = curl_init('http://example.com');