From 242f32c3830a640ecfd2ef05193c71f1a0fd757d Mon Sep 17 00:00:00 2001 From: Daniel Fox Date: Fri, 15 Aug 2025 11:02:46 -0700 Subject: [PATCH] fix: Use static application ID for GTK Forwarded: https://github.com/transmission/transmission/pull/7669 --- gtk/Application.cc | 23 +++++++++++++++++++++++ gtk/transmission-gtk.desktop.in | 1 + 2 files changed, 24 insertions(+) --- transmission.git.orig/gtk/Application.cc 2025-11-06 14:14:08.064604707 +0100 +++ transmission.git/gtk/Application.cc 2025-11-06 14:14:08.064604707 +0100 @@ -704,10 +704,33 @@ namespace { +/* The application ID in GTK is used to identify "application uniqueness", + * to prevent things like inadvertently launching multiple instances of an + * application. We use the device and inode of the configuration directory + * to uniquely identify an instance of transmission-gtk, so that multiple + * instances are allowed as long as they're all using unique configuration + * directories. + * + * Unfortunately, this ID is also used in e.g. GNOME to identify which .desktop + * file an application is associated with, and thus which icon to show in the + * dock, which means that, at least on GNOME Wayland, no icon will appear. + * + * To work around this, solve for the common case of a user using the default + * configuration directory by returning a static string, while any other config + * directory results in the previous unique string. + */ std::string get_application_id(std::string const& config_dir) { struct stat sb = {}; (void)::stat(config_dir.c_str(), &sb); + + std::string default_config_dir = tr_getDefaultConfigDir("transmission"); + + if (config_dir == default_config_dir) + { + return "com.transmissionbt.transmission"; + } + return fmt::format("com.transmissionbt.transmission_{}_{}", sb.st_dev, sb.st_ino); } --- transmission.git.orig/gtk/transmission-gtk.desktop.in 2025-11-06 14:14:08.064604707 +0100 +++ transmission.git/gtk/transmission-gtk.desktop.in 2025-11-06 14:14:08.064604707 +0100 @@ -10,6 +10,7 @@ TryExec=transmission-gtk Type=Application StartupNotify=true +StartupWMClass=com.transmissionbt.transmission MimeType=application/x-bittorrent;x-scheme-handler/magnet; Categories=Network;FileTransfer;P2P;GTK; X-Ubuntu-Gettext-Domain=transmission