From: Yukiharu YABUKI Date: Mon, 15 Sep 2025 22:43:22 +0900 Subject: Fix compilation error due to very old style C code (Closes: #1114447) The build failed due to multiple `[-Wincompatible-pointer-types]` errors when passing destructor callback functions to `ObjList` manipulation routines. Functions like `ObjList_InsertObjToStart` and `ObjList_InsertObjToEnd` were declared in `Obj.h` with an old-style C function pointer syntax: `Obj (*destructor)()`. This style implicitly informs the compiler that the function takes no arguments, leading it to interpret the signature as `void * (*)(void)`. However, the actual destructor functions provided (e.g., `ColorGCInstance_Destroy`) are defined and intended to accept an `Obj` argument, which is typically a `void *`, matching a `void * (*)(void *)` signature. This mismatch between the declared and actual function pointer types caused the compiler errors. To resolve this, update the function pointer declarations in `Obj.h` to explicitly specify that the destructor takes an `Obj` argument. This changes the signature from `Obj (*destructor)()` to `Obj (*destructor)(Obj)`, aligning the declaration with the expected and provided function type and resolving the incompatible pointer type errors. Example error: ColorGC.c:160:30: error: passing argument 3 of 'ObjList_InsertObjToStart' from incompatible pointer type [-Wincompatible-pointer-types] 160 | (ObjDestructor)ColorGCInstance_Destroy); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Obj.h:41:44: note: expected 'void * (*)(void)' but argument is of type 'void * (*)(void *)' 41 | Obj (*destructor)()); | ~~~~~~^~~~~~~~~~~~~ Update function definitions in Obj.c to match the `destructor` function pointer signature declared in Obj.h. The definitions used an old-style declaration `Obj (*destructor)()`, which implied `void` parameters. This conflicted with the `Obj (*destructor)(Obj)` signature specified in the header file. This change resolves several `conflicting types` errors for the `ObjList_InsertObjToPrev`, `ObjList_InsertObjToNext`, `ObjList_InsertObjToStart`, and `ObjList_InsertObjToEnd` functions, and an `incompatible-pointer-types` error for `ObjListData_Create`, ensuring type consistency across declarations and definitions. Errors fixed: Obj.c:21:25: error: assignment to 'void * (*)(void *)' from incompatible pointer type 'void * (*)(void)' Obj.c:121:13: error: conflicting types for 'ObjList_InsertObjToPrev' Obj.c:141:13: error: conflicting types for 'ObjList_InsertObjToNext' Obj.c:161:13: error: conflicting types for 'ObjList_InsertObjToStart' Obj.c:169:13: error: conflicting types for 'ObjList_InsertObjToEnd' --- Obj.c | 10 +++++----- Obj.h | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Obj.c b/Obj.c index a8cc01e..39fc9d9 100644 --- a/Obj.c +++ b/Obj.c @@ -11,7 +11,7 @@ /* ObjListData ·¿¤ÎÁàºî */ /*****************************************************************************/ -static ObjListData ObjListData_Create(Obj obj, Obj (*destructor)()) +static ObjListData ObjListData_Create(Obj obj, Obj (*destructor)(Obj)) { ObjListData list_data; @@ -119,7 +119,7 @@ int ObjList_IsEnd(ObjList list, ObjListData data) } ObjListData ObjList_InsertObjToPrev(ObjList list, ObjListData current, - Obj obj, Obj (*destructor)()) + Obj obj, Obj (*destructor)(Obj)) { ObjListData data; @@ -139,7 +139,7 @@ ObjListData ObjList_InsertObjToPrev(ObjList list, ObjListData current, } ObjListData ObjList_InsertObjToNext(ObjList list, ObjListData current, - Obj obj, Obj (*destructor)()) + Obj obj, Obj (*destructor)(Obj)) { ObjListData data; @@ -159,7 +159,7 @@ ObjListData ObjList_InsertObjToNext(ObjList list, ObjListData current, } ObjListData ObjList_InsertObjToStart(ObjList list, Obj obj, - Obj (*destructor)()) + Obj (*destructor)(Obj)) { ObjListData current; current = ObjList_GetStart(list); @@ -167,7 +167,7 @@ ObjListData ObjList_InsertObjToStart(ObjList list, Obj obj, } ObjListData ObjList_InsertObjToEnd(ObjList list, Obj obj, - Obj (*destructor)()) + Obj (*destructor)(Obj)) { ObjListData current; current = ObjList_GetEnd(list); diff --git a/Obj.h b/Obj.h index 223b348..ba73fc4 100644 --- a/Obj.h +++ b/Obj.h @@ -34,13 +34,13 @@ int ObjList_IsEndEdge(ObjList list, ObjListData data); int ObjList_IsStart(ObjList list, ObjListData data); int ObjList_IsEnd(ObjList list, ObjListData data); ObjListData ObjList_InsertObjToPrev(ObjList list, ObjListData current, - Obj obj, Obj (*destructor)()); + Obj obj, Obj (*destructor)(Obj)); ObjListData ObjList_InsertObjToNext(ObjList list, ObjListData current, - Obj obj, Obj (*destructor)()); + Obj obj, Obj (*destructor)(Obj)); ObjListData ObjList_InsertObjToStart(ObjList list, Obj obj, - Obj (*destructor)()); + Obj (*destructor)(Obj)); ObjListData ObjList_InsertObjToEnd(ObjList list, Obj obj, - Obj (*destructor)()); + Obj (*destructor)(Obj)); ObjListData ObjList_DeleteObjToPrev(ObjList list, ObjListData current); ObjListData ObjList_DeleteObjToNext(ObjList list, ObjListData current); ObjListData ObjList_DeleteObjFromStart(ObjList list);