man/amanda.conf.5 | 2 1 + 1 - 0 !
man/disklist.5 | 2 1 + 1 - 0 !
man/entities/global.entities.in | 2 1 + 1 - 0 !
man/xml-source/amanda.conf.5.xml | 2 1 + 1 - 0 !
man/xml-source/disklist.5.xml | 2 1 + 1 - 0 !
5 files changed, 5 insertions(+), 5 deletions(-)

 make dumpdates path in docs match debian configuration

client-src/amandates.c | 4 2 + 2 - 0 !
client-src/selfcheck.c | 9 5 + 4 - 0 !
common-src/ammessage.c | 2 1 + 1 - 0 !
server-src/diskfile.h | 2 1 + 1 - 0 !
4 files changed, 9 insertions(+), 8 deletions(-)

 make dumpdates path in docs match debian configuration

example/amanda.conf.in | 6 3 + 3 - 0 !
example/template.d/dumptypes | 6 3 + 3 - 0 !
2 files changed, 6 insertions(+), 6 deletions(-)

 make dumpdates path in docs match debian configuration

server-src/amserverconfig.pl | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix amserverconfig path

example/amanda-client-postgresql.conf.in | 6 3 + 3 - 0 !
example/amandaclient.xml.in | 4 2 + 2 - 0 !
example/amandaserver.xml.in | 4 2 + 2 - 0 !
example/xinetd.amandaclient.in | 2 1 + 1 - 0 !
example/xinetd.amandaserver.in | 2 1 + 1 - 0 !
5 files changed, 9 insertions(+), 9 deletions(-)

 change user from amandabackup to backup

installcheck/Amanda_Config.pl | 2 1 + 1 - 0 !
installcheck/catalogs/chunker-partial.cat | 2 1 + 1 - 0 !
installcheck/catalogs/taper-parallel-write.cat | 2 1 + 1 - 0 !
3 files changed, 3 insertions(+), 3 deletions(-)

 change user from amandabackup to backup

man/amaddclient.8 | 4 2 + 2 - 0 !
man/amanda-auth.7 | 36 18 + 18 - 0 !
man/amgpgcrypt.8 | 8 4 + 4 - 0 !
man/amserverconfig.8 | 8 4 + 4 - 0 !
man/amsuntar.8 | 2 1 + 1 - 0 !
man/xml-source/amaddclient.8.xml | 4 2 + 2 - 0 !
man/xml-source/amanda-auth.7.xml | 36 18 + 18 - 0 !
man/xml-source/amgpgcrypt.8.xml | 8 4 + 4 - 0 !
man/xml-source/amserverconfig.8.xml | 8 4 + 4 - 0 !
man/xml-source/amsuntar.8.xml | 4 2 + 2 - 0 !
10 files changed, 59 insertions(+), 59 deletions(-)

 change user from amandabackup to backup

amar-src/Makefile.am | 6 4 + 2 - 0 !
ndmp-src/Makefile.am | 6 4 + 2 - 0 !
xfer-src/Makefile.am | 3 2 + 1 - 0 !
3 files changed, 10 insertions(+), 5 deletions(-)

 add missing libs to link.

server-src/amserverconfig.pl | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 adjust template path to work with debian 
Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=551564

common-src/conffile.c | 6 3 + 3 - 0 !
1 file changed, 3 insertions(+), 3 deletions(-)

 fix various lintian errors relating to man pages, including line breaks, non-standard fhs paths, etc.

man/amanda.conf.5 | 6 3 + 3 - 0 !
1 file changed, 3 insertions(+), 3 deletions(-)

 fix various lintian errors relating to man pages, including line breaks, non-standard fhs paths, etc.

common-src/Makefile.am | 3 2 + 1 - 0 !
1 file changed, 2 insertions(+), 1 deletion(-)

 bug#830725: amanda: please make the build reproducible

perl/Amanda/Changer/robot.pm | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 amanda-common: amanda::changer::robot::interface::mtx calls confess but does not use carp

amplot/amplot.sh | 2 1 + 1 - 0 !
client-src/patch-system.sh | 2 1 + 1 - 0 !
common-src/amaespipe.sh | 2 1 + 1 - 0 !
common-src/amcrypt-ossl-asym.sh | 2 1 + 1 - 0 !
common-src/amcrypt-ossl.sh | 2 1 + 1 - 0 !
common-src/amcrypt.sh | 2 1 + 1 - 0 !
server-src/amcheckdb.sh | 2 1 + 1 - 0 !
7 files changed, 7 insertions(+), 7 deletions(-)

 avoid using build-time shell in built scripts for reproducibility

common-src/protocol.c | 11 6 + 5 - 0 !
1 file changed, 6 insertions(+), 5 deletions(-)

---

server-src/driver.c | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

---

common-src/protocol.c | 2 2 + 0 - 0 !
1 file changed, 2 insertions(+)

---

perl/Amanda/Taper/Scan/lexical.pm | 18 17 + 1 - 0 !
1 file changed, 17 insertions(+), 1 deletion(-)

 fix, lexical.pm last_use_label ignores "storage" field on tapelist

perl/Amanda/Chunker/Controller.pm | 14 13 + 1 - 0 !
1 file changed, 13 insertions(+), 1 deletion(-)

 fix the update of internal database when dle is very small

Okay, I believe I have tracked down this "info on small DLEs not saved"
bug...


Summary:

The short-ish summary is that in Amanda 3.4 and 3.5, any dump which ends
but being shorter than 1024 bytes long (after compression) is treated as
not having happened at all, as far as Amanda's recording of "info"
statistics goes.

This is most significant for full dumps (i.e. of very small partitions),
because it causes Amanda to think that DLE has never been dumped (or,
that the last time it was dumped was on the final run made using Amanda
3.3 or older), and thus it schedules that DLE for a full dump on every
run.

However, the bug actually also affects incremental dumps (as we
discussed in the above-quoted message) -- so DLEs that don't change much
on a particular day and thus end up with very tiny incrementals end up
recording those dumps as having taken place on 1969/12/31 rather than
the day they actually occurred.


Neither of the above situations is "fatal" as far as preventing Amanda
from actually backup up your data, but for people (such as Gene) who are
effected, a workaround workaround is simply to make sure that the dump
on a particular day is at least 1024 bytes.

For full dumps, you can do this just by creating a "dummy" file on the
otherwise-very-empty partition in question, using data that's already
compressed so that the dump file is still big enough after Amanda
compresses it.  (In my tests, I just used the bytes off the front of the
amanda_3.4.2.orig.tar.gz file I happened to have sitting around.)

(For incrementals the trick is to make sure there is enough changing on
the partition that the incremental dump is over the cutoff size; the
best way to do that will depend on what data is on that partition, etc.)



Internal details and history:

The bug happens because the messages that the chunker and driver
processes use to communicate with each other specify the size of the
files transferred in integral units of "kb" (=1024 bytes), and thus the
size given for very small files is "0" -- but the code in the driver
that handles updating the info database has a specific check for
zero-length dumps and refuses to update the database in that case.
(This check is found in driverio.c:update_info_dumper() .)

It appears that the bug has existed since Amanda 3.4, when the old
chunker.c version of the chunker program was replaced with a new Perl
version.

Both server-src/chunker.c as found in Amanda 3.3 and server-src/dumper.c
as it exists in 3.5 take special care to round "kb" value passed for
files which are short-but-not-empty files up to "1" -- but that logic
was not implemented in the Perl chunker code when it was created..

(Interestingly, if I am reading the old chunker.c code correctly, it
used to round up not just very-small-but-not-empty files to 1 kb, but
actually rounded the kb figure up to count any trailing partial
kilobytes at the end of the file... while the new program seems to just

application-src/amsamba.pl | 2 2 + 0 - 0 !
1 file changed, 2 insertions(+)

 fix a problem found with samba on debian 10 aka buster.

Found on mailing-lists amanda-users

May need patch 36-*

application-src/amsamba.pl | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 fix a problem found with samba on debian 10 aka buster, part 2.

Found on mailing-list amanda-user:

Add the same pattern near line 757:
   return if $line =~ /^Unable to initialize messaging context/;

(...)

common-src/testutils.h | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix ftbfs with gcc-10

Added missing 'extern' keyword and changed type to be consistent
with common-src/testutils.c

Signed-off-by: Vclav Doleal <vdolezal@redhat.com>

example/quick/amanda.conf | 301 301 + 0 - 0 !
example/quick/disklist | 10 10 + 0 - 0 !
example/quick/dumptypes | 252 252 + 0 - 0 !
example/quick/tapetypes | 97 97 + 0 - 0 !
4 files changed, 660 insertions(+)

---

config/amanda/amanda_configure.m4 | 1 0 + 1 - 0 !
config/amanda/components.m4 | 16 15 + 1 - 0 !
config/amanda/libs.m4 | 38 38 + 0 - 0 !
configure.ac | 1 1 + 0 - 0 !
4 files changed, 54 insertions(+), 2 deletions(-)

---

common-src/Makefile.am | 5 1 + 4 - 0 !
1 file changed, 1 insertion(+), 4 deletions(-)

---

client-src/runtar.c | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 fix cve-2022-37705

client-src/runtar.c | 10 7 + 3 - 0 !
1 file changed, 7 insertions(+), 3 deletions(-)

 fix the fix for cve-2022-37705

client-src/rundump.c | 135 135 + 0 - 0 !
1 file changed, 135 insertions(+)

 fix cve-2022-37704

client-src/rundump.c | 18 18 + 0 - 0 !
1 file changed, 18 insertions(+)

 fix cve-2022-37704, second vector (rsh)

client-src/rundump.c | 7 5 + 2 - 0 !
1 file changed, 5 insertions(+), 2 deletions(-)

 update the fix for cve-2022-37704

In the case of xfsdump(8), the check for dump(8) options was invoked
instead of the check for the xfsdump(8). This broke legitimate use of
xfsdump, while leaving the vulnerability open.

client-src/calcsize.c | 1 0 + 1 - 0 !
1 file changed, 1 deletion(-)

 fix cve-2022-37703

client-src/runtar.c | 47 38 + 9 - 0 !
1 file changed, 38 insertions(+), 9 deletions(-)

 cve-2023-30577 - local privilege escalation.