Package: amanda / 1:3.5.1-5

Metadata

Package Version Patches format
amanda 1:3.5.1-5 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
01 debian fhs dumpdates path doc | (download)

man/amanda.conf.5 | 2 1 + 1 - 0 !
man/disklist.5 | 2 1 + 1 - 0 !
man/entities/global.entities.in | 2 1 + 1 - 0 !
man/xml-source/amanda.conf.5.xml | 2 1 + 1 - 0 !
man/xml-source/disklist.5.xml | 2 1 + 1 - 0 !
5 files changed, 5 insertions(+), 5 deletions(-)

 make dumpdates path in docs match debian configuration
02 debian fhs dumpdates path src | (download)

client-src/amandates.c | 4 2 + 2 - 0 !
client-src/selfcheck.c | 9 5 + 4 - 0 !
common-src/ammessage.c | 2 1 + 1 - 0 !
server-src/diskfile.h | 2 1 + 1 - 0 !
4 files changed, 9 insertions(+), 8 deletions(-)

 make dumpdates path in docs match debian configuration
03 debian fhs dumpdates path examples | (download)

example/amanda.conf.in | 6 3 + 3 - 0 !
example/template.d/dumptypes | 6 3 + 3 - 0 !
2 files changed, 6 insertions(+), 6 deletions(-)

 make dumpdates path in docs match debian configuration
fix amserverconfig path | (download)

server-src/amserverconfig.pl | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix amserverconfig path
07 debian change from amandabackup to backup example | (download)

example/amanda-client-postgresql.conf.in | 6 3 + 3 - 0 !
example/amandaclient.xml.in | 4 2 + 2 - 0 !
example/amandaserver.xml.in | 4 2 + 2 - 0 !
example/xinetd.amandaclient.in | 2 1 + 1 - 0 !
example/xinetd.amandaserver.in | 2 1 + 1 - 0 !
5 files changed, 9 insertions(+), 9 deletions(-)

 change user from amandabackup to backup
08 debian change from amandabackup to backup src | (download)

installcheck/Amanda_Config.pl | 2 1 + 1 - 0 !
installcheck/catalogs/chunker-partial.cat | 2 1 + 1 - 0 !
installcheck/catalogs/taper-parallel-write.cat | 2 1 + 1 - 0 !
3 files changed, 3 insertions(+), 3 deletions(-)

 change user from amandabackup to backup
09 debian change from amandabackup to backup doc | (download)

man/amaddclient.8 | 4 2 + 2 - 0 !
man/amanda-auth.7 | 36 18 + 18 - 0 !
man/amgpgcrypt.8 | 8 4 + 4 - 0 !
man/amserverconfig.8 | 8 4 + 4 - 0 !
man/amsuntar.8 | 2 1 + 1 - 0 !
man/xml-source/amaddclient.8.xml | 4 2 + 2 - 0 !
man/xml-source/amanda-auth.7.xml | 36 18 + 18 - 0 !
man/xml-source/amgpgcrypt.8.xml | 8 4 + 4 - 0 !
man/xml-source/amserverconfig.8.xml | 8 4 + 4 - 0 !
man/xml-source/amsuntar.8.xml | 4 2 + 2 - 0 !
10 files changed, 59 insertions(+), 59 deletions(-)

 change user from amandabackup to backup
missing libs ftbfs.patch | (download)

amar-src/Makefile.am | 6 4 + 2 - 0 !
ndmp-src/Makefile.am | 6 4 + 2 - 0 !
xfer-src/Makefile.am | 3 2 + 1 - 0 !
3 files changed, 10 insertions(+), 5 deletions(-)

 add missing libs to link.
fix amserverconfig template path | (download)

server-src/amserverconfig.pl | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 adjust template path to work with debian 
Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=551564
14 debian fix lintian manpage warnings conffile.c | (download)

common-src/conffile.c | 6 3 + 3 - 0 !
1 file changed, 3 insertions(+), 3 deletions(-)

 fix various lintian errors relating to man pages, including line breaks, non-standard fhs paths, etc.
15 debian fix lintian manpage warnings amanda.conf.5 | (download)

man/amanda.conf.5 | 6 3 + 3 - 0 !
1 file changed, 3 insertions(+), 3 deletions(-)

 fix various lintian errors relating to man pages, including line breaks, non-standard fhs paths, etc.
reproducible build | (download)

common-src/Makefile.am | 3 2 + 1 - 0 !
1 file changed, 2 insertions(+), 1 deletion(-)

 bug#830725: amanda: please make the build reproducible
20 fix robot.pm | (download)

perl/Amanda/Changer/robot.pm | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 amanda-common: amanda::changer::robot::interface::mtx calls confess but does not use carp
22 reproducible build fix shell capture | (download)

amplot/amplot.sh | 2 1 + 1 - 0 !
client-src/patch-system.sh | 2 1 + 1 - 0 !
common-src/amaespipe.sh | 2 1 + 1 - 0 !
common-src/amcrypt-ossl-asym.sh | 2 1 + 1 - 0 !
common-src/amcrypt-ossl.sh | 2 1 + 1 - 0 !
common-src/amcrypt.sh | 2 1 + 1 - 0 !
server-src/amcheckdb.sh | 2 1 + 1 - 0 !
7 files changed, 7 insertions(+), 7 deletions(-)

 avoid using build-time shell in built scripts for reproducibility
24 for jose server | (download)

common-src/protocol.c | 11 6 + 5 - 0 !
1 file changed, 6 insertions(+), 5 deletions(-)

---
26 driver fix crash | (download)

server-src/driver.c | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

---
28 protocol_check | (download)

common-src/protocol.c | 2 2 + 0 - 0 !
1 file changed, 2 insertions(+)

---
30 lexical | (download)

perl/Amanda/Taper/Scan/lexical.pm | 18 17 + 1 - 0 !
1 file changed, 17 insertions(+), 1 deletion(-)

 fix, lexical.pm last_use_label ignores "storage" field on tapelist
32 fix small DLE | (download)

perl/Amanda/Chunker/Controller.pm | 14 13 + 1 - 0 !
1 file changed, 13 insertions(+), 1 deletion(-)

 fix the update of internal database when dle is very small

Okay, I believe I have tracked down this "info on small DLEs not saved"
bug...


Summary:

The short-ish summary is that in Amanda 3.4 and 3.5, any dump which ends
but being shorter than 1024 bytes long (after compression) is treated as
not having happened at all, as far as Amanda's recording of "info"
statistics goes.

This is most significant for full dumps (i.e. of very small partitions),
because it causes Amanda to think that DLE has never been dumped (or,
that the last time it was dumped was on the final run made using Amanda
3.3 or older), and thus it schedules that DLE for a full dump on every
run.

However, the bug actually also affects incremental dumps (as we
discussed in the above-quoted message) -- so DLEs that don't change much
on a particular day and thus end up with very tiny incrementals end up
recording those dumps as having taken place on 1969/12/31 rather than
the day they actually occurred.


Neither of the above situations is "fatal" as far as preventing Amanda
from actually backup up your data, but for people (such as Gene) who are
effected, a workaround workaround is simply to make sure that the dump
on a particular day is at least 1024 bytes.

For full dumps, you can do this just by creating a "dummy" file on the
otherwise-very-empty partition in question, using data that's already
compressed so that the dump file is still big enough after Amanda
compresses it.  (In my tests, I just used the bytes off the front of the
amanda_3.4.2.orig.tar.gz file I happened to have sitting around.)

(For incrementals the trick is to make sure there is enough changing on
the partition that the incremental dump is over the cutoff size; the
best way to do that will depend on what data is on that partition, etc.)



Internal details and history:

The bug happens because the messages that the chunker and driver
processes use to communicate with each other specify the size of the
files transferred in integral units of "kb" (=1024 bytes), and thus the
size given for very small files is "0" -- but the code in the driver
that handles updating the info database has a specific check for
zero-length dumps and refuses to update the database in that case.
(This check is found in driverio.c:update_info_dumper() .)

It appears that the bug has existed since Amanda 3.4, when the old
chunker.c version of the chunker program was replaced with a new Perl
version.

Both server-src/chunker.c as found in Amanda 3.3 and server-src/dumper.c
as it exists in 3.5 take special care to round "kb" value passed for
files which are short-but-not-empty files up to "1" -- but that logic
was not implemented in the Perl chunker code when it was created..

(Interestingly, if I am reading the old chunker.c code correctly, it
used to round up not just very-small-but-not-empty files to 1 kb, but
actually rounded the kb figure up to count any trailing partial
kilobytes at the end of the file... while the new program seems to just
34 fix for samba on deb10 | (download)

application-src/amsamba.pl | 2 2 + 0 - 0 !
1 file changed, 2 insertions(+)

 fix a problem found with samba on debian 10 aka buster.

Found on mailing-lists amanda-users

May need patch 36-*

36 fix for samba on deb10 part 2 | (download)

application-src/amsamba.pl | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 fix a problem found with samba on debian 10 aka buster, part 2.

Found on mailing-list amanda-user:

Add the same pattern near line 757:
   return if $line =~ /^Unable to initialize messaging context/;

(...)

38 ftbfs with gcc 10 | (download)

common-src/testutils.h | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix ftbfs with gcc-10

Added missing 'extern' keyword and changed type to be consistent
with common-src/testutils.c

Signed-off-by: Václav Doležal <vdolezal@redhat.com>