ChangeLog | 10 5 + 5 - 0 !
qdevices/qdevice-net-msg-received.c | 2 1 + 1 - 0 !
qdevices/qnetd-log.c | 2 1 + 1 - 0 !
3 files changed, 7 insertions(+), 7 deletions(-)

 fix typo: occured -> occurred

man/corosync-qnetd.8 | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix typo: parantheses -> parentheses

ChangeLog | 2 1 + 1 - 0 !
man/quorum_initialize.3.in | 2 1 + 1 - 0 !
man/quorum_trackstart.3.in | 2 1 + 1 - 0 !
man/votequorum_trackstart.3.in | 2 1 + 1 - 0 !
4 files changed, 4 insertions(+), 4 deletions(-)

 fix typo: configuraton -> configuration

exec/main.c | 12 6 + 6 - 0 !
exec/util.h | 2 1 + 1 - 0 !
qdevices/corosync-qdevice.c | 2 1 + 1 - 0 !
3 files changed, 8 insertions(+), 8 deletions(-)

 fix typo: aquire -> acquire

qdevices/qdevice-instance.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix typo: retrive -> retrieve

man/corosync-qdevice.8 | 2 1 + 1 - 0 !
qdevices/qnetd-algo-ffsplit.c | 26 13 + 13 - 0 !
2 files changed, 14 insertions(+), 14 deletions(-)

 fix typo: prefered -> preferred

man/corosync.conf.5 | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix typo: recomended -> recommended

ChangeLog | 2 1 + 1 - 0 !
man/votequorum.5 | 2 1 + 1 - 0 !
2 files changed, 2 insertions(+), 2 deletions(-)

 fix typo: occours -> occurs

qdevices/corosync-qdevice.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix typo: destorying -> destroying

Doxyfile.in | 6 0 + 6 - 0 !
1 file changed, 6 deletions(-)

 remove deprecated doxygen flags

Running 'doxygen -u Doxyfile.in' in the source root produces the
following results:

 - SYMBOL_CACHE_SIZE at line 301 has become obsolete. This tag
   has been removed.
 - SHOW_DIRECTORIES at line 507 has become obsolete. This tag
   has been removed.
 - HTML_ALIGN_MEMBERS at line 881 has become obsolete. This tag
   has been removed.
 - USE_INLINE_TREES at line 1067 has become obsolete. This tag
   has been removed.
 - XML_SCHEMA at line 1311 has become obsolete. This tag has been
   removed.
 - XML_DTD at line 1317 has become obsolete. This tag has been
   removed.

init/corosync-notifyd.service.in | 1 1 + 0 - 0 !
init/corosync-qdevice.service.in | 1 1 + 0 - 0 !
init/corosync-qnetd.service.in | 1 1 + 0 - 0 !
init/corosync.service.in | 1 1 + 0 - 0 !
4 files changed, 4 insertions(+)

 add documentation uris to the systemd service files

These are used by systemctl help.

conf/corosync.conf.example | 81 0 + 81 - 0 !
conf/corosync.conf.example.in | 81 81 + 0 - 0 !
conf/corosync.conf.example.udpu | 58 0 + 58 - 0 !
conf/corosync.conf.example.udpu.in | 58 58 + 0 - 0 !
configure.ac | 2 2 + 0 - 0 !
5 files changed, 141 insertions(+), 139 deletions(-)

 substitute logdir into the example configs

Closes: #739730

configure.ac | 14 13 + 1 - 0 !
init/Makefile.am | 28 3 + 25 - 0 !
init/corosync-notifyd.in | 2 1 + 1 - 0 !
init/corosync-notifyd.service.in | 2 1 + 1 - 0 !
init/corosync-qdevice.in | 2 1 + 1 - 0 !
init/corosync-qnetd.in | 2 1 + 1 - 0 !
init/corosync-qnetd.service.in | 2 1 + 1 - 0 !
init/corosync.in | 2 1 + 1 - 0 !
pkgconfig/Makefile.am | 29 4 + 25 - 0 !
pkgconfig/corosync.pc.in | 10 5 + 5 - 0 !
pkgconfig/libtemplate.pc.in | 16 8 + 8 - 0 !
11 files changed, 39 insertions(+), 70 deletions(-)

 replace manual substitutions with ac_config_files

init/corosync-notifyd.conf.in | 6 3 + 3 - 0 !
init/corosync-notifyd.in | 8 4 + 4 - 0 !
init/corosync-qdevice.in | 12 6 + 6 - 0 !
init/corosync-qnetd.in | 14 7 + 7 - 0 !
init/corosync.conf.in | 6 3 + 3 - 0 !
init/corosync.in | 8 4 + 4 - 0 !
6 files changed, 27 insertions(+), 27 deletions(-)

 localstatedir is substituted in lower case

configure.ac | 3 3 + 0 - 0 !
tools/Makefile.am | 16 2 + 14 - 0 !
tools/corosync-blackbox.sh | 2 1 + 1 - 0 !
tools/corosync-xmlproc.sh | 2 1 + 1 - 0 !
4 files changed, 7 insertions(+), 16 deletions(-)

 replace manual substitutions in the tools directory as well

configure.ac | 8 8 + 0 - 0 !
init/corosync-notifyd.conf.in | 12 4 + 8 - 0 !
init/corosync-notifyd.in | 12 4 + 8 - 0 !
init/corosync-notifyd.service.in | 2 1 + 1 - 0 !
init/corosync-qdevice.in | 12 4 + 8 - 0 !
init/corosync-qnetd.in | 12 4 + 8 - 0 !
init/corosync-qnetd.service.in | 2 1 + 1 - 0 !
init/corosync.conf.in | 15 5 + 10 - 0 !
init/corosync.in | 12 4 + 8 - 0 !
9 files changed, 35 insertions(+), 52 deletions(-)

 add --with-configdir that defaults to /etc/sysconfig

And use the resulting CONFIGDIR to reduce duplication in init system
integration code.

init/corosync-notifyd.conf.in | 16 0 + 16 - 0 !
init/corosync-notifyd.in | 11 2 + 9 - 0 !
init/corosync-qdevice.in | 11 2 + 9 - 0 !
init/corosync-qnetd.in | 11 2 + 9 - 0 !
init/corosync.conf.in | 14 0 + 14 - 0 !
init/corosync.in | 11 2 + 9 - 0 !
6 files changed, 8 insertions(+), 66 deletions(-)

 eliminate lock_file from init system integration

I don't see any reason for locking the respecive subsystems.  I'm pretty
certain Debian derivatives don't even notice, and RedHat seems to provide
nothing but a cryptic status message if some daemon leaves behind such a
lockfile.

configure.ac | 2 2 + 0 - 0 !
exec/Makefile.am | 4 2 + 2 - 0 !
exec/main.c | 8 8 + 0 - 0 !
init/corosync.service.in | 6 3 + 3 - 0 !
4 files changed, 15 insertions(+), 5 deletions(-)

 send corosync startup notification to systemd
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

This enables starting the daemon directly in the service file, because
dependent units won't be started until initialization is complete.

Signed-off-by: Ferenc Wgner <wferi@niif.hu>

init/corosync-notifyd.service.in | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 make systemd stop and restart corosync-notifyd if corosync is
 restarted
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Otherwise is exits successfully (which should be fixed eventually), thus
it does not even get restarted by systemd.

Signed-off-by: Ferenc Wgner <wferi@niif.hu>

init/corosync-notifyd.service.in | 2 1 + 1 - 0 !
tools/Makefile.am | 3 2 + 1 - 0 !
tools/corosync-notifyd.c | 8 8 + 0 - 0 !
3 files changed, 11 insertions(+), 2 deletions(-)

 send corosync-notifyd startup notification to systemd
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Signed-off-by: Ferenc Wgner <wferi@niif.hu>

man/Makefile.am | 3 1 + 2 - 0 !
1 file changed, 1 insertion(+), 2 deletions(-)

 use debian/changelog timestamp for the build time of the manuals

Otherwise the manuals become arch-dependent, breaking co-installability of
the Multi-Arch: same development packages.

include/Makefile.am | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 totemip.h uses list.h

Until https://github.com/corosync/corosync/issues/81 is fixed by upstream,
partially revert d9a2110.

configure.ac | 8 8 + 0 - 0 !
1 file changed, 8 insertions(+)

 configure.ac

conf/tmpfiles.d/corosync-qnetd.conf | 2 1 + 1 - 0 !
init/corosync-qnetd.service.in | 3 1 + 2 - 0 !
2 files changed, 2 insertions(+), 3 deletions(-)

 run corosync-qnetd unprivileged

init/corosync-qdevice.service.in | 7 4 + 3 - 0 !
1 file changed, 4 insertions(+), 3 deletions(-)

 start corosync-qdevice directly

configure.ac | 19 15 + 4 - 0 !
1 file changed, 15 insertions(+), 4 deletions(-)

 fully expand substituted variables

conf/Makefile.am | 2 1 + 1 - 0 !
conf/tmpfiles.d/Makefile.am | 40 0 + 40 - 0 !
conf/tmpfiles.d/corosync-qnetd.conf | 1 0 + 1 - 0 !
configure.ac | 10 1 + 9 - 0 !
corosync.spec.in | 6 1 + 5 - 0 !
init/corosync-qdevice.service.in | 3 3 + 0 - 0 !
init/corosync-qnetd.service.in | 1 1 + 0 - 0 !
7 files changed, 7 insertions(+), 56 deletions(-)

 use runtimedirectory instead of tmpfiles.d

This reverts part of commit 32123f6bb2ebc4f9ac7865945cc85a9c9b903dc6.

A simple directive is a much lighter solution to the same problem, and
automatically follows the specified User.

init/corosync-qnetd.service.in | 2 1 + 1 - 0 !
qdevices/Makefile.am | 4 2 + 2 - 0 !
qdevices/corosync-qnetd.c | 7 7 + 0 - 0 !
3 files changed, 10 insertions(+), 3 deletions(-)

 corosync-qnetd: send startup notification to systemd

init/corosync-qdevice.service.in | 2 1 + 1 - 0 !
qdevices/Makefile.am | 5 3 + 2 - 0 !
qdevices/corosync-qdevice.c | 7 7 + 0 - 0 !
3 files changed, 11 insertions(+), 3 deletions(-)

 corosync-qdevice: send startup notification to systemd

exec/totemcrypto.c | 11 11 + 0 - 0 !
1 file changed, 11 insertions(+)

 totemcrypto: check length of the packet

Packet has to be longer than crypto_config_header and hash_len,
otherwise unallocated memory is passed into calculate_nss_hash function,
what may result in crash.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>

exec/totemsrp.c | 299 299 + 0 - 0 !
1 file changed, 299 insertions(+)

 totemsrp: implement sanity checks of received msgs

Sanity checkers are used to prevent crashing because of
accessing unallocated memory. Basic totemip addresses checking is also
implemented.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>

exec/totemsrp.c | 22 21 + 1 - 0 !
1 file changed, 21 insertions(+), 1 deletion(-)

 totemsrp: check join and leave msg length

If number of proc_list, failed_list or active members is too high it
may be impossible to put them into message, which is allocated on the
stack what results in stack corruption.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>

exec/totemcrypto.c | 8 7 + 1 - 0 !
exec/totemcrypto.h | 3 3 + 0 - 0 !
exec/totemudp.c | 12 12 + 0 - 0 !
exec/totemudpu.c | 12 12 + 0 - 0 !
4 files changed, 34 insertions(+), 1 deletion(-)

 totemudp: check lenght of message to sent

If message to sent is too long, encrypt and authentificate may overwrite
stack (buf_out). Check this condition and throw message if this happens.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>

qdevices/msgio.c | 71 14 + 57 - 0 !
1 file changed, 14 insertions(+), 57 deletions(-)

 qdevice msgio: fix reading of msg longer than i32

And also remove the unused msgio_send_blocking which was used in
the very early phases of qdevice development and it's not used
any longer, so it make sense to delete it.

Signed-off-by: Jan Friesse <jfriesse@redhat.com>