Package: enigmail / 2:2.1.3+ds1-4

Metadata

Package Version Patches format
enigmail 2:2.1.3+ds1-4 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
0001 avoid eslint during buildtest.patch | (download)

Makefile | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 avoid eslint during buildtest

eslint is not yet in debian (see https://bugs.debian.org/743404).
once it is packaged, we should remove this patch and allow the full
testsuite to run on the debian buildd infrastructure.

0002 Avoid auto download of pEpEngine Closes 891882.patch | (download)

package/prefs/defaultPrefs.js | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 avoid auto-download of pepengine (closes: #891882)

When pEpEngine is available in debian, enigmail should Depend: or
Recommend: it.  In the meantime, we should disable auto-download of
the pEp engine and prefer enigmail.

0003 avoid OpenPGP.js when building.patch | (download)

package/cryptoAPI/Makefile | 1 0 + 1 - 0 !
package/cryptoAPI/README.txt | 8 4 + 4 - 0 !
package/cryptoAPI/gnupg.js | 67 12 + 55 - 0 !
package/cryptoAPI/openpgp-js.js | 183 0 + 183 - 0 !
package/tests/main.js | 3 1 + 2 - 0 !
package/tests/openpgpjs-test.js | 77 0 + 77 - 0 !
stdlib/Makefile | 6 2 + 4 - 0 !
util/genxpi | 3 0 + 3 - 0 !
8 files changed, 19 insertions(+), 329 deletions(-)

 avoid openpgp.js when building

GnuPG should not depend on OpenPGP.js.

This is an attempt to strip out whatever dependency it had and make it
work with gpg alone.

There is no need for getStrippedKey at all -- it's never invoked in
the codebase outside of getMinimalPubKey, and it should not be
relevant there, since we are already filtering appropriately.

Since we explicitly depend on gnupg 2.2.8-2 or greater, we are fine
with these expectations.

We also don't want to try to test openpgp.js at all.

0004 copy enums.armor from OpenPGP.js.patch | (download)

package/openpgp.jsm | 33 15 + 18 - 0 !
1 file changed, 15 insertions(+), 18 deletions(-)

 copy enums.armor from openpgp.js

Since we use this in our own bytesToArmor(), we just copy the simple
table in here.

0005 add more logging to autocrypt test.patch | (download)

package/tests/autocrypt-test.js | 6 3 + 3 - 0 !
1 file changed, 3 insertions(+), 3 deletions(-)

 add more logging to autocrypt test


0006 enable the use of extra file descriptors and test th.patch | (download)

ipc/modules/enigmailprocess_common.jsm | 42 38 + 4 - 0 !
ipc/modules/enigmailprocess_main.jsm | 14 14 + 0 - 0 !
ipc/modules/enigmailprocess_worker_unix.js | 8 8 + 0 - 0 !
ipc/modules/subprocess.jsm | 48 48 + 0 - 0 !
ipc/tests/subprocess-test.js | 28 28 + 0 - 0 !
5 files changed, 136 insertions(+), 4 deletions(-)

 enable the use of extra file descriptors, and test them

 * add "infds" and "outfds" to the enigmailprocess_* implementation,
   passing the file descriptors back and forth between the threads as
   needed to permit additional (non-stdin/stdout/stderr) file
   descriptors to be passed to the subprocess.

 * NOTE: this presumably does not work on Windows at all!

 * use infds and outfds within subprocess.jsm

0007 add test to do symmetric encryption decryption with .patch | (download)

ipc/tests/subprocess-test.js | 95 95 + 0 - 0 !
1 file changed, 95 insertions(+)

 add test to do symmetric encryption/decryption with gpg


0008 use GnuPG instead of openpgp.js for symmetric encryp.patch | (download)

package/autocrypt.jsm | 92 46 + 46 - 0 !
package/gpg.jsm | 156 155 + 1 - 0 !
2 files changed, 201 insertions(+), 47 deletions(-)

 use gnupg instead of openpgp.js for symmetric encryption/decryption

This enables all the test suite to pass, and should enable proper use
of the Autocrypt setup message.

We need to handle PLAINTEXT status lines that include a possible
filename in them.  And sometimes GnuPG gets confused about the
0009 tests wrap individual tests in key test with withTes.patch | (download)

package/tests/key-test.js | 16 8 + 8 - 0 !
1 file changed, 8 insertions(+), 8 deletions(-)

 tests: wrap individual tests in key-test with withtestgpghome()

this helps ensure that we avoid working with someone else's keys.

0010 Avoid errors on validKeyserversExist.patch | (download)

package/keyserverUris.jsm | 3 2 + 1 - 0 !
1 file changed, 2 insertions(+), 1 deletion(-)

 avoid errors on validkeyserversexist()

This change is intended to clear these errors when running the unit
tests:

JavaScript error: chrome://enigmail/content/modules/keyserverUris.jsm, line 114: TypeError: EnigmailPrefs.getPref(...) is undefined

0011 drop unnecessary tests.patch | (download)

package/tests/keyObj-test.js | 17 1 + 16 - 0 !
1 file changed, 1 insertion(+), 16 deletions(-)

 drop unnecessary tests in keyobj-test.js

See Message-ID: <8736f1nfsd.fsf@fifthhorseman.net> (and followup
messages) on enigmail-users@enigmail.net for more discussion about why
these tests are bogus and irrelevant for debian.

0012 convert buildlist.py to unix style line endings no f.patch | (download)

util/buildlist.py | 84 42 + 42 - 0 !
1 file changed, 42 insertions(+), 42 deletions(-)

 convert buildlist.py to unix-style line-endings (no functional
 change)


0013 use py2to3 2.7 to convert to python3.patch | (download)

util/Expression.py | 8 4 + 4 - 0 !
util/JarMaker.py | 13 6 + 7 - 0 !
util/MozZipFile.py | 12 6 + 6 - 0 !
util/Preprocessor.py | 21 11 + 10 - 0 !
util/buildlist.py | 2 1 + 1 - 0 !
util/checkFiles.py | 2 1 + 1 - 0 !
util/run-tests.py | 2 1 + 1 - 0 !
util/utils.py | 8 4 + 4 - 0 !
8 files changed, 34 insertions(+), 34 deletions(-)

 use py2to3-2.7 to convert to python3


0014 fix shebang lines to use python3.patch | (download)

util/checkFiles.py | 2 1 + 1 - 0 !
util/run-tests.py | 2 1 + 1 - 0 !
2 files changed, 2 insertions(+), 2 deletions(-)

 fix shebang lines to use python3


0015 convert the rest of the build infrastructure to pyth.patch | (download)

COMPILING | 2 1 + 1 - 0 !
configure.ac | 6 3 + 3 - 0 !
provisioning/Dockerfile | 2 1 + 1 - 0 !
3 files changed, 5 insertions(+), 5 deletions(-)

 convert the rest of the build infrastructure to python3


0016 python3 treats objects as Unicode by default no need.patch | (download)

util/Preprocessor.py | 19 9 + 10 - 0 !
1 file changed, 9 insertions(+), 10 deletions(-)

 python3 treats objects as unicode by default,
 no need for explicit indicators


0016 always return a struct_time.patch | (download)

util/JarMaker.py | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 always return a struct_time


0017 avoid cmp in favor of __lt__.patch | (download)

util/MozZipFile.py | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 avoid cmp in favor of __lt__


0019 Avoid weird Preprocessor.py misbehavior.patch | (download)

ui/content/Makefile | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 avoid weird preprocessor.py misbehavior

Sometimes, when util/__pycache__ is not populated,
util/Preprocessor.py fails to produce any output.

I have not been able to diagnose why this happens, but this will
hopefully work around it.