tests/meson.build | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 revert "tests: fail on warnings too"

This reverts commit 207b9bb3c0a582b830218fd1b6e8760684adbc48.

meson.build | 1 1 + 0 - 0 !
src/tray/meson.build | 2 1 + 1 - 0 !
2 files changed, 2 insertions(+), 1 deletion(-)

 build: add explicit dependency on xfixes

We use the xfixes extensions in tray icons but we rely on the dependency
brought to us from other libraries as mutter but let's make it explicit

meson.build | 1 1 + 0 - 0 !
src/tray/meson.build | 2 1 + 1 - 0 !
src/tray/na-xembed.c | 15 15 + 0 - 0 !
3 files changed, 17 insertions(+), 1 deletion(-)

 tray/na-xembed: use xshape to remove input on socket window

We don't want this window to take any input as, a part from blocking the
events on the shell representation itself, they may potentially make the
plugged window to do anything with the event is processing (such as
showing tooltips). And we don't want this since we only want to send to
those windows only the synthetic events that we explicitly control.

This was already the case before of commit ab60902058 but a similar
approach was not replicated, leading to input events being fully
processed from tray icons plugs.

It requires adding an explicit build dependency on Xext, but this is
something that mutter already depends on so not really a new dependency

src/shell-tray-icon.c | 4 4 + 0 - 0 !
src/tray/na-xembed.c | 29 29 + 0 - 0 !
src/tray/na-xembed.h | 4 4 + 0 - 0 !
3 files changed, 37 insertions(+)

 shell-tray-icon: use available space when that's defined

src/shell-tray-icon.c | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 shell-tray: ensure that only a child can be added

src/shell-tray-icon.c | 4 4 + 0 - 0 !
src/tray/na-xembed.c | 18 18 + 0 - 0 !
src/tray/na-xembed.h | 1 1 + 0 - 0 !
3 files changed, 23 insertions(+)

 shell-tray-icon: trigger a relayout when the underneath xembeded
 size changes

src/tray/na-tray-child.c | 6 3 + 3 - 0 !
src/tray/na-xembed.c | 6 2 + 4 - 0 !
2 files changed, 5 insertions(+), 7 deletions(-)

 tray: zero-initialize the event structures on initialization

src/tray/na-xembed.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 tray/na-xembed: use proper indentation style header

src/tray/na-xembed.c | 39 38 + 1 - 0 !
1 file changed, 38 insertions(+), 1 deletion(-)

 tray/na-xembed: destroy socket window when ending the embedding

Currently when embedding a tray icon is ended we are leaving the X11
socket window around as we don't really destroy it, while we're just
listening for its child destruction.

So, when embedding is ending we need to make sure that:
 - If the plug window is still alive, move it back to its old parent
   (normally that's the root window, but we query for it, to be sure)
 - If the plug window has been already destroyed or reparented (by us or
   by something else), we've to just destroy the socket window

src/tray/na-tray-manager.c | 5 1 + 4 - 0 !
1 file changed, 1 insertion(+), 4 deletions(-)

 tray/na-tray-manager: remove outdated comment and return value

src/shell-app.c | 24 21 + 3 - 0 !
1 file changed, 21 insertions(+), 3 deletions(-)

 shell/app: warn instead of crashing if disposed before startup
 notification

This is currently easy to reproduce by launching and immediately closing
Chrome, then closing the shell. But automated crash reports show it can
also happen while using the shell, during a garbage collection run.

It's currently the top gnome-shell crasher in Ubuntu, and mostly with
Chromium/Electron apps. But regardless of the offender, we shouldn't
ever trust application behaviour to keep the shell alive.

Bug: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7045
Bug-Ubuntu: https://bugs.launchpad.net/bugs/2037055

src/st/st-theme-node-private.h | 2 1 + 1 - 0 !
src/st/st-theme-node.c | 17 15 + 2 - 0 !
2 files changed, 16 insertions(+), 3 deletions(-)

 st/theme-node: forget properties cache on stylesheet change

To avoid `node->properties` pointing to freed memory after each
`st_theme_unload_stylesheet`, flush the cache that is `node->properties`.
They will be reloaded as soon as they are required by `ensure_properties`.

And yes `node->stylesheets_changed_id` already existed, but was unused.

Why not just fix Croco? Croco does not use proper reference counting

data/default-apps/system-folder.txt | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 data: add im-config.desktop to system folder
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Debian installs this by default, but most users will only need to run
it once, or perhaps not at all.

Thanks: Jeremy Bcha
Helps: #1099579