Package: gtk+2.0 / 2.24.32-3

modules-other-gail-gailtreeview.c-Incorporate-review-sugg.patch Patch series | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
From: Brady Minardi <bradyminardi@fake-box.com>
Date: Sat, 14 Jul 2018 14:45:28 +0000
Subject: modules/other/gail/gailtreeview.c: Incorporate review suggestions

Incorporate review suggestions by Emmanuele Bassi.

Origin: upstream, 2.24.33, commit:8f8336cd9410c39ac53da40de69907a0844024d5
---
 modules/other/gail/gailtreeview.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/modules/other/gail/gailtreeview.c b/modules/other/gail/gailtreeview.c
index ee8fa00..23923c5 100644
--- a/modules/other/gail/gailtreeview.c
+++ b/modules/other/gail/gailtreeview.c
@@ -223,7 +223,7 @@ static void             adjustment_changed              (GtkAdjustment
 
 /* Misc */
 
-static void             set_iter_nth_row                (GtkTreeView            *tree_view,
+static gboolean         set_iter_nth_row                (GtkTreeView            *tree_view,
                                                          GtkTreeIter            *iter,
                                                          gint                   row);
 static gint             get_row_from_tree_path          (GtkTreeView            *tree_view,
@@ -1466,8 +1466,10 @@ gail_tree_view_add_row_selection (AtkTable *table,
         }
       else
         { 
-          set_iter_nth_row (tree_view, &iter_to_row, row);
-          gtk_tree_selection_select_iter (selection, &iter_to_row);
+          if (set_iter_nth_row (tree_view, &iter_to_row, row))
+            gtk_tree_selection_select_iter (selection, &iter_to_row);
+          else
+            return FALSE;
         }
     }
 
@@ -3236,7 +3238,7 @@ update_cell_value (GailRendererCell *renderer_cell,
   return gail_renderer_cell_update_cache (renderer_cell, emit_change_signal);
 }
 
-static void 
+static gboolean 
 set_iter_nth_row (GtkTreeView *tree_view, 
                   GtkTreeIter *iter, 
                   gint        row)
@@ -3245,7 +3247,10 @@ set_iter_nth_row (GtkTreeView *tree_view,
   
   tree_model = gtk_tree_view_get_model (tree_view);
   gtk_tree_model_get_iter_first (tree_model, iter);
-  iter = return_iter_nth_row (tree_view, tree_model, iter, 0 , row);
+  if (return_iter_nth_row (tree_view, tree_model, iter, 0 , row) != NULL)
+    return TRUE;
+    
+  return FALSE;
 }
 
 static gint