Package: ipv6toolkit / 2.0+ds.1-1

Metadata

Package Version Patches format
ipv6toolkit 2.0+ds.1-1 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
0001 Don t install OUI and use Debian provided.patch | (download)

GNUmakefile | 6 3 + 3 - 0 !
1 file changed, 3 insertions(+), 3 deletions(-)

 don't install oui and use debian-provided

We don't ship oui.txt, don't try to install
Debian has an ieee-data package which releases us from shipping
IEEE's oui.txt. We need to tweak GNUmakefile so it doesn't
attempt to install the file, or make install will fail.

Also, the ipv6toolkit.conf file should point to the file
provided by the ieee-data package, located in /var/lib/ieee-data.

0002 Fix scan6 loop undefined behavior.patch | (download)

tools/scan6.c | 8 4 + 4 - 0 !
1 file changed, 4 insertions(+), 4 deletions(-)

 fix scan6 loop undefined behavior

GCC detected an invocation of undefined behavior in scan6.c.
I think the error is caused because when j==16, memory
accessed falls outside of an s6_addr array.

0003 Fix misuse of hyphen in udp6.1 manpage.patch | (download)

manuals/udp6.1 | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix misuse of hyphen in udp6.1 manpage

Simple error reported by lintian.

0004 Allow compilation under GCC 10.patch | (download)

tools/libipv6.c | 10 5 + 5 - 0 !
tools/scan6.c | 4 2 + 2 - 0 !
2 files changed, 7 insertions(+), 7 deletions(-)

 allow compilation under gcc-10

This patch was cherry-picked from upstream:

> SHA-1: 2bde90f3845234490549640dc6ed5712d84969ba
> Declare variables as static where appropriate to avoid compile error:
> https://bugs.gentoo.org/706312

Upstream decided to go with static declarations.

0005 Silence compiler warnings.patch | (download)

GNUmakefile | 2 1 + 1 - 0 !
Makefile | 2 1 + 1 - 0 !
2 files changed, 2 insertions(+), 2 deletions(-)

 silence compiler warnings

Patches backported from these two upstream commits:

https://github.com/fgont/ipv6toolkit/commit/15215b29bd91a9baafabd1ca75dd2e1674e302fa
https://github.com/fgont/ipv6toolkit/commit/0cb96ae8ed5886aba060c7cbd97830a1b8306581

Upstream went with -fno-* options.

0006 Silence misleading indentation warnings.patch | (download)

GNUmakefile | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 silence misleading indentation warnings

It's too many warnings to pursue one by one and the upstream patch
was made over current code so backporting it may break our version
of the software.

Considering that upstream has already fixed this [1] for next release,
I am just going with -fno-misleading-indentation options.

[1] https://github.com/fgont/ipv6toolkit/commit/0cb96ae8ed5886aba060c7cbd97830a1b8306581

0007 strncpy len must include the terminating nul byte.patch | (download)

tools/libipv6.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 strncpy len must include the terminating nul byte

A mistake was spotted by -Wstringop-truncation: the length parameter
for strncpy() was set as if the null terminator on the string was not
to be included in the count. The manpage says otherwise:

> Warning: If there is no null byte among the first n bytes of src,
> the string placed in dest will not be null-terminated.

So, the correct way to go is to include the null-terminating character
in n.