Package: kcoreaddons / 5.28.0-2

Metadata

Package Version Patches format
kcoreaddons 5.28.0-2 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
Fix Bug 343275 1 added at the end of a hyperlink.patch | (download)

autotests/ktexttohtmltest.cpp | 5 5 + 0 - 0 !
src/lib/text/ktexttohtml.cpp | 6 6 + 0 - 0 !
2 files changed, 11 insertions(+)

 fix bug 343275 - [1] added at the end of a hyperlink

FIXED-IN: 5.29
BUG: 343275

Fix Bug 363427 unsafe characters incorrectly parsed as pa.patch | (download)

autotests/ktexttohtmltest.cpp | 8 8 + 0 - 0 !
src/lib/text/ktexttohtml.cpp | 2 2 + 0 - 0 !
2 files changed, 10 insertions(+)

 fix bug 363427 - unsafe characters incorrectly parsed as part of url

Fix [Please visit our booth 24-25 http://example.com/]
CCBUG:363427

KDirWatch fix memory leak on destruction.patch | (download)

src/lib/io/kdirwatch.cpp | 8 5 + 3 - 0 !
src/lib/io/kdirwatch_p.h | 3 2 + 1 - 0 !
2 files changed, 7 insertions(+), 4 deletions(-)

 kdirwatch: fix memory leak on destruction.

Summary:
The Entry class owns the Client instances, so it should delete the
remaining instances in its destructor, for the case where they haven't
been removed one by one. The line of code removeEntries(nullptr) was
probably means to remove them one by one, but it was a no-op (the code
for that method doesn't expect nullptr as argument) and it would be
slow anyway. We don't need to call inotify_remove for every path,
when we're just cleaning up in a global static after qApp destruction.

Detected by a clang-sanitizer build on http://ci-logs.kde.flaska.net
and reproduced locally with valgrind.

Test Plan:
./kdirwatch_*_unittest now passes in valgrind without memory
leaks being reported

Reviewers: aacid, mpyne

Reviewed By: aacid, mpyne

Subscribers: markg, #frameworks

Tags: #frameworks