providers/sqlite/Makefile.am | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 link sqlite provider against sqlite3
 The sqlite provider uses dlopen() to load the sqlite3 library.
 As a consequence, libgda-5.0-4 did not have a dependency on libsqlite3-0
 so it was not guaranteed that libsqlite3-0 was actually installed when
 applications, like anjuta, were using the sqlite provider.

libgda/sqlite/virtual/gda-vprovider-data-model.c | 3 3 + 0 - 0 !
1 file changed, 3 insertions(+)

 [patch 1/1] accept sqlite_index_constraint_like from sqlite

sqlite 3.10.0 added the SQLITE_INDEX_CONSTRAINT_LIKE,
SQLITE_INDEX_CONSTRAINT_GLOB and SQLITE_INDEX_CONSTRAINT_REGEXP
constraint operators to the list that xBestIndex can be supplied. See
https://www.sqlite.org/vtab.html for details.

Compiling against sqlite 3.11 (the current version in Ubuntu Xenial and
Debian stretch) causes a build failure because sqlite supplies
SQLITE_INDEX_CONSTRAINT_LIKE and libgda's implementation of xBestIndex
cannot understand it:

ERROR:gda-vprovider-data-model.c:1316:map_sqlite3_info_to_gda_filter: code should not be reached
FAIL check_vcnc (exit status: 134)

Since libgda already defines (and thus presumably implements)
GDA_SQL_OPERATOR_TYPE_LIKE, update the sqlite virtual provider to use
it.

With this change, libgda5 5.2.4 builds and passes tests again when built
against sqlite 3.11. However it may be necessary to implement
SQLITE_INDEX_CONSTRAINT_GLOB and SQLITE_INDEX_CONSTRAINT_REGEXP also to
cover all possible queries.

Though not necessary for Debian or Ubuntu, it may be necessary to make
this change conditional on >= 3.10 if it is required that builds against
older sqlite versions are still possible.

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=764860
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811068