Package: libvirt / 5.2.0-2

Metadata

Package Version Patches format
libvirt 5.2.0-2 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
debian/Debianize libvirt guests.patch | (download)

tools/libvirt-guests.sh.in | 45 28 + 17 - 0 !
tools/libvirt-guests.sysconf | 4 2 + 2 - 0 !
2 files changed, 30 insertions(+), 19 deletions(-)

 debianize libvirt-guests

debian/Debianize systemd service files.patch | (download)

src/remote/libvirtd.service.in | 4 2 + 2 - 0 !
tools/libvirt-guests.service.in | 2 1 + 1 - 0 !
2 files changed, 3 insertions(+), 3 deletions(-)

 debianize systemd service files


debian/Debianize virtlockd.patch | (download)

src/locking/virtlockd.service.in | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 debianize virtlockd


debian/Debianize virtlogd.patch | (download)

src/logging/virtlogd.service.in | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 debianize virtlogd


openpty Skip test if no pty is available.patch | (download)

gnulib/tests/test-openpty.c | 9 7 + 2 - 0 !
1 file changed, 7 insertions(+), 2 deletions(-)

 openpty: skip test if no pty is available

In chroots for package builds with recent debootstrap there may be
no ptys or they might not be accessible. This both manifests as ENOENT
on Linux.

Works around #817236

Disable gnulib s test nonplocking pipe.sh.patch | (download)

gnulib/tests/test-nonblocking-pipe.sh | 4 4 + 0 - 0 !
1 file changed, 4 insertions(+)

 disable gnulib's test-nonplocking-pipe.sh

since it fails on at least sparc and mips from time to time.

Issue reported upstresm.

Skip vircgrouptest.patch | (download)

tests/vircgrouptest.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 skip vircgrouptest

We don't have a mock for nodeGetCPUCount yet so we fail in a chroot
without sysfs mounted.

debian/Don t enable default network on boot.patch | (download)

src/Makefile.in | 3 1 + 2 - 0 !
src/network/Makefile.inc.am | 3 1 + 2 - 0 !
2 files changed, 2 insertions(+), 4 deletions(-)

 don't enable default network on boot

to not interfere with existing network configurations

test posix_openpt don t fail on EACCESS.patch | (download)

gnulib/tests/test-posix_openpt.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 test-posix_openpt: don't fail on eaccess

In chroots created with recent debootstrap /dev/ptmx might not be accessible.

Works around #817236

Reduce udevadm settle timeout to 10 seconds.patch | (download)

src/util/virutil.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 reduce udevadm settle timeout to 10 seconds

This isn't a proper fix but it will make virt-manager at least start.

Closes: #663931

debian/Use upstreams polkit rule.patch | (download)

src/Makefile.in | 4 2 + 2 - 0 !
src/remote/Makefile.inc.am | 4 2 + 2 - 0 !
2 files changed, 4 insertions(+), 4 deletions(-)

 use upstreams polkit rule

As of 1.2.16 upstream ships a Polkit rule like Debian does.

debian/apparmor_profiles_local_include.patch | (download)

src/security/apparmor/usr.lib.libvirt.virt-aa-helper | 1 1 + 0 - 0 !
src/security/apparmor/usr.sbin.libvirtd | 3 3 + 0 - 0 !
2 files changed, 4 insertions(+)

 apparmor_profiles_local_include

Include local apparmor profile

Set defaults for zfs tools.patch | (download)

m4/virt-storage-zfs.m4 | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 set defaults for zfs tools

so we don't have to build-depend on a program in contrib

Pass GPG_TTY env var to the ssh binary.patch | (download)

src/rpc/virnetsocket.c | 2 2 + 0 - 0 !
1 file changed, 2 insertions(+)

 pass gpg_tty env var to the ssh binary

gpg-agent(1) can emulate the OpenSSH Agent protocol (which provides
pubkey-authentication using an authentication-capable OpenPGP key, in
addition to the usual identity files).  However for a console-based
password prompt to work, the 'GPG_TTY' environment variable needs to be
set to the current TTY.  Furthermore, curses-based password prompts also
require the 'TERM' environment variable to be set to the terminal type.

apparmor Allow virt aa helper to access the name service .patch | (download)

src/security/apparmor/usr.lib.libvirt.virt-aa-helper | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 apparmor: allow virt-aa-helper to access the name service switch

Closes: #882979

debian/Prefer sbin over usr sbin.patch | (download)

configure.ac | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 prefer /sbin over /usr/sbin

If libvirt is built in a chroot with merged /usr it will otherwise
break on non /usr merged systems.

Closes: #895145

api disallow virDomainGetHostname for read only connectio.patch | (download)

src/libvirt-domain.c | 2 2 + 0 - 0 !
1 file changed, 2 insertions(+)

 api: disallow virdomaingethostname for read-only connections
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

The virDomainGetHostname API is fetching guest information and this may
involve use of an untrusted guest agent. As such its use must be
forbidden on a read-only connection to libvirt.

Fixes CVE-2019-3886
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

remote enforce ACL write permission for getting guest tim.patch | (download)

src/remote/remote_protocol.x | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 remote: enforce acl write permission for getting guest time &
 hostname
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Getting the guest time and hostname both require use of guest agent
commands. These must not be allowed for read-only users, so the
permissions check must validate "write" permission not "read".

Fixes CVE-2019-3886
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

tests Avoid writing into HOME during virsh snapshot.patch | (download)

tests/test-lib.sh | 13 13 + 0 - 0 !
tests/virsh-snapshot | 2 2 + 0 - 0 !
tests/virsh-uriprecedence | 12 1 + 11 - 0 !
3 files changed, 16 insertions(+), 11 deletions(-)

 tests: avoid writing into $home during virsh-snapshot
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

In a constrained CI environment, where it is intentional that attempts
to write outside the current directory will fail, virsh-snapshot was
failing:

 error: invalid argument: parent s3 for snapshot s2 not found
 error: marker
+error: Failed to create '/home/travis/.cache/libvirt/virsh': Permission denied
FAIL virsh-snapshot (exit status: 1)

But we've already solved the problem in virsh-uriprecedence: tell
virsh to use XDG locations pointing to somewhere we can write rather
than its default of falling back to $HOME with the test being at risk
of breaking due to the user's environment and/or unacceptably altering
the user's normal cache.  Hoist that solution into test-lib.sh, so
that all scripts can use it as needed. While at it, fix a latent typo
where XDG_RUNTIME_HOME was set to a literal relative directory name
"XDG_CACHE_HOME" (the typo did not affect virsh-uriprecedence, but
could matter to other clients).

Fixes: 280a2b41
Fixes: 398de147
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>

(cherry picked from commit b18866086516b6fb1dc5bcc45dcde7b8df324850)