src/winio.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 01/11] display: do not show the state flags in the help viewer
 or file browser

The state flags are relevant only when editing.

This fixes https://savannah.gnu.org/bugs/?59744.
Indirectly-reported-by: ObeliX <ObeliX-@gmx.de>

Bug existed since version 5.3, since --stateflags was introduced.

src/nano.c | 3 3 + 0 - 0 !
src/text.c | 2 1 + 1 - 0 !
2 files changed, 4 insertions(+), 1 deletion(-)

 [patch 02/11] speller: do an internal spell check when --speller is
 an empty string

This fixes https://savannah.gnu.org/bugs/?59855.
Indirectly-reported-by: Mike Frysinger <vapier@gentoo.org>

Bug existed since version 2.9.6, commit 94347f08.

src/nano.c | 6 4 + 2 - 0 !
1 file changed, 4 insertions(+), 2 deletions(-)

 [patch 03/11] mouse: update title bar (the m flag) when the click is
 on the cursor

Clicking on the cursor toggles the mark, meaning that the flags
in the title bar should be updated when --stateflags is active.

This fixes https://savannah.gnu.org/bugs/?59747.
Indirectly-reported-by: ObeliX <ObeliX-@gmx.de>

Signed-off-by: OIX <ObeliX-@gmx.de>

src/winio.c | 8 5 + 3 - 0 !
1 file changed, 5 insertions(+), 3 deletions(-)

 [patch 04/11] mouse: do not offset the shortcuts by 'margin' when
 using --linenumbers

The bottom window (the prompt bar and the shortcuts) does not shift
its position when line numbers are active, so mouse clicks in this
window should be not be compensated for the line-numbers margin.

This fixes https://savannah.gnu.org/bugs/?59749.
Indirectly-reported-by: ObeliX <ObeliX-@gmx.de>

Bug existed since version 2.7.0, since line numbers were introduced.

src/prompt.c | 6 6 + 0 - 0 !
1 file changed, 6 insertions(+)

 [patch 05/11] prompt: restore a workaround for a cursor misplacement
 bug in ncurses

When making small movements in the lower right corner, ncurses can
get confused about where the cursor actually is -- a double-width
character seems to throw its calculations off.

This addresses https://savannah.gnu.org/bugs/?59808.

Bug existed since version 5.4, commit 39705c60.

syntax/nanorc.nanorc | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 06/11] syntax: nanorc: colorize 'bookstyle' as a valid option

This fixes https://savannah.gnu.org/bugs/?59769.
Reported-by: Tiago Almeida <tjamadeira@gmail.com>

Bug existed since version 5.0, since --bookstyle was introduced.

src/text.c | 6 6 + 0 - 0 !
1 file changed, 6 insertions(+)

 [patch 07/11] undo: remove the added magic line when a replacement
 caused one

This fixes https://savannah.gnu.org/bugs/?59796.

Bug existed since before version 2.2.4.

src/prompt.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 08/11] prompt: suppress the ">" character always when exactly
 at the right edge

When the tail of the answer still fits exactly on the screen, the ">"
continuation character should not be shown -- also when the start of
the answer is "scrolled off" to the left.

This fixes https://savannah.gnu.org/bugs/?59816.

Bug existed in this form since version 4.0, commit 56181896.

doc/nano.texi | 10 5 + 5 - 0 !
1 file changed, 5 insertions(+), 5 deletions(-)

 [patch 09/11] tweaks: move 'set indicator' to its alphabetical place
 in the manual

syntax/sh.nanorc | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 10/11] syntax: sh: recognize shebangs with any shell after
 'env', not just 'sh'

(Inspired by a complaint seen somewhere on Stackoverflow.)

po/ca.po | 18 9 + 9 - 0 !
po/fr.po | 9 4 + 5 - 0 !
po/hr.po | 26 13 + 13 - 0 !
po/ko.po | 18 9 + 9 - 0 !
po/ms.po | 18 9 + 9 - 0 !
po/nb.po | 2 1 + 1 - 0 !
po/pl.po | 255 132 + 123 - 0 !
po/pt.po | 34 17 + 17 - 0 !
po/pt_BR.po | 17 9 + 8 - 0 !
po/ru.po | 954 501 + 453 - 0 !
po/sr.po | 26 13 + 13 - 0 !
po/sv.po | 165 87 + 78 - 0 !
po/zh_CN.po | 10 5 + 5 - 0 !
13 files changed, 809 insertions(+), 743 deletions(-)

 [patch 11/11] po: three substantial and several minor updates of
 translations for 5.4

Substantial updates for Polish, Russian, and Swedish.

src/text.c | 5 5 + 0 - 0 !
1 file changed, 5 insertions(+)

 [patch 12/34] linter: block the resizing signal while reading output
 from the linter
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This prevents read() from returning unexpectedly and causing a crash.

This fixes https://savannah.gnu.org/bugs/?60537.
Reported-by: Filips Romns <frfilips@gmail.com>

Bug existed since version 2.4.2, since the handling of SIGWINCH changed.

src/nano.c | 3 3 + 0 - 0 !
1 file changed, 3 insertions(+)

 [patch 13/34] editing: prevent the pointer for the top row from
 becoming dangling

When undoing several actions, it is possible for the line at the top
of the screen to be removed, leaving 'edittop' pointing to a structure
that has been freed.  Soon after, 'edittop' is referenced to determine
whether the cursor is offscreen...  Prevent this invalid reference by
stepping 'edittop' one line back in that special case.  This changes
the normal centering behavior of Undo when the cursor goes offscreen,
but... so be it.

When a single node is deleted, it is always possible to step one line
back, because a buffer contains always at least one line (even though
maybe empty), so if the current line could be deleted, there must be
one before it (when at the top of the screen).

This fixes https://savannah.gnu.org/bugs/?60436.

Bug existed since version 2.3.3, commit 60815461,
since undoing does not always center the cursor.

src/prompt.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 14/34] memory: move the correct number of bytes, and not one
 too many

We want to reduce the size of the answer by one byte,
not keep the full answer (plus terminating NUL).

This fixes https://savannah.gnu.org/bugs/?60764.

Bug existed since version 2.9.8, commit f304b9ae,
since piping text to an external command was introduced.

src/winio.c | 3 2 + 1 - 0 !
1 file changed, 2 insertions(+), 1 deletion(-)

 [patch 15/34] feedback: when not in curses mode, just skip displaying
 any message

Calling die() could trigger another call of emergency_save(), which
could fail and cause another call to statusline(), which would call
die() again...  Spiralling until stack space runs out.

This fixes https://savannah.gnu.org/bugs/?60853.

Bug existed since version 5.1, commit 7942dab0.

Original report was in https://bugzilla.redhat.com/1976410.
Reported-by: Souptik Dutta Roy <duttaroy.souptik@gmail.com>

src/winio.c | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 [patch 16/34] input: give up on the input stream only after millions
 of errors

This mitigates a problem seen sometimes among the Red Hat crash reports:
somehow wgetch() keeps returning ERR, as if it were in nodelay mode.
(I've seen this happen once after nano came out of suspension.)

Using a much larger error-count value gives the user a few seconds
to type something and hopefully get out of the error condition.

src/nano.c | 5 5 + 0 - 0 !
1 file changed, 5 insertions(+)

 [patch 17/34] general: prevent die() from getting recursed into

When something that is called from die() calls die() again,
there is nothing we can do any more but give up.

This would have prevented the spiralling as
seen in https://savannah.gnu.org/bugs/?60853.

src/files.c | 8 5 + 3 - 0 !
1 file changed, 5 insertions(+), 3 deletions(-)

 [patch 18/34] files: check the result of fdopen(), to avoid a
 possible crash

When safe_tempfile() returns a valid filename, it should also
return a valid open stream.

This fixes https://savannah.gnu.org/bugs/?61064.

Bug existed since version 1.3.8, commit 5e068c60.

src/files.c | 4 3 + 1 - 0 !
1 file changed, 3 insertions(+), 1 deletion(-)

 [patch 19/34] files: write a lock file also for a freshly saved
 buffer

This fixes https://savannah.gnu.org/bugs/?61146

Bug existed since version 2.3.2, since --locking was introduced,
and continued to exist since version 4.8 despite commit 497f126b
claiming to have fixed it.

src/winio.c | 5 5 + 0 - 0 !
1 file changed, 5 insertions(+)

 [patch 20/34] feedback: retain the correct help lines during verbatim
 Input with Slang

This fixes https://savannah.gnu.org/bugs/?61184.

Bug existed since version 5.3, commit b9a1a586.

src/global.c | 4 4 + 0 - 0 !
1 file changed, 4 insertions(+)

 [patch 21/34] help: show ^- when using slang instead of ^_ as the
 latter does nothing

This fixes https://savannah.gnu.org/bugs/?61185.

Bug existed since probably forever.

src/winio.c | 9 9 + 0 - 0 !
1 file changed, 9 insertions(+)

 [patch 22/34] display: work around a disappearing cursor when a line
 scrolled sideways

This fixes https://savannah.gnu.org/bugs/?61186.

Problem existed since probably forever.

src/winio.c | 4 4 + 0 - 0 !
1 file changed, 4 insertions(+)

 [patch 23/34] display: with slang, make a hidden cursor return upon
 the next keystroke

This mitigates https://savannah.gnu.org/bugs/?61189.

Problem existed since probably forever.

doc/nano.1 | 2 1 + 1 - 0 !
doc/nano.texi | 2 1 + 1 - 0 !
2 files changed, 2 insertions(+), 2 deletions(-)

 [patch 24/34] docs: correct the descriptions of how to invoke the
 spell checker

The keystrokes to invoke it changed in version 5.0.

doc/nano.texi | 2 1 + 1 - 0 !
doc/nanorc.5 | 2 1 + 1 - 0 !
2 files changed, 2 insertions(+), 2 deletions(-)

 [patch 25/34] docs: correct the default value of the errorcolor
 option

It should be "bold,white,red" instead of "brightwhite,red"
because "bright" is deprecated and not documented.

Signed-off-by: Hussam al-Homsi <sawuare@gmail.com>
Signed-off-by: Benno Schulenberg <bensberg@telfort.nl>

src/nano.c | 4 4 + 0 - 0 !
1 file changed, 4 insertions(+)

 [patch 26/34] startup: if term is unset, try falling back to vt220
 instead of failing

Curses cannot function if not informed via TERM which type of terminal
is being used.  As many terminals are mostly compatible with a VT220,
falling back to "vt220" when TERM is unset has a good chance of giving
the user a usable nano, instead of simply failing.

(Falling back to "vt100" is not good as it contains padding delays.)

This partially addresses https://bugs.debian.org/991982.

src/files.c | 3 2 + 1 - 0 !
1 file changed, 2 insertions(+), 1 deletion(-)

 [patch 27/34] files: do not call fsync() on a fifo, to avoid a
 spurious error message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This fixes https://savannah.gnu.org/bugs/?61234.

The original report was in:
  https://lists.gnu.org/archive/html/nano-devel/2021-09/msg00029.html
Reported-by: Andr Kugland <kugland@gmail.com>

Bug existed since version 5.0, commit a84cdaaa.

src/files.c | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 [patch 28/34] files: making a backup of a fifo makes no sense, so do
 not try that

This fixes https://savannah.gnu.org/bugs/?61235.

Bug existed since version 4.3, commit 1b2018e9,
since opening a fifo was made possible again.

src/files.c | 6 4 + 2 - 0 !
1 file changed, 4 insertions(+), 2 deletions(-)

 [patch 29/34] shutdown: when dying, do not install/restore a handler
 for Ctrl+C

First, we don't want the writing of an emergency file to be interrupted
by the user.  But more important: the routine for restoring the handler
also disables SIGINT, which would leave the terminal with a non-working
Ctrl+C.

Saving an emergency file calls write_file() in a unique manner: with
thefile == NULL, fullbuffer == FALSE (even though the entire buffer
will be saved, of course) and tmp == TRUE (even though it is not a
temporary file, as it will persist after nano exits).  But in fact
we want the handler for Ctrl+C installed only for normal files, not
for temporary files and not for emergency files -- the user should
not be able to interrupt the writing of those.

This fixes https://savannah.gnu.org/bugs/?61237.

Bug existed since version 4.3, commit 8550c6bd.

src/browser.c | 15 14 + 1 - 0 !
src/global.c | 6 0 + 6 - 0 !
src/prototypes.h | 4 2 + 2 - 0 !
3 files changed, 16 insertions(+), 9 deletions(-)

 [patch 30/34] browser: make the keystrokes ^w^y and ^w^v work again

The functions to_first_file() and to_last_file() can get called from
do_statusbar_input(), which is called indirectly from do_prompt(),
and are expected to make the corresponding adjustment.

This fixes https://savannah.gnu.org/bugs/?61273.

Bug existed since version 5.0, commit 07c1ac90.

src/global.c | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 [patch 31/34] help: make the keystrokes ^w^y and ^w^v work again

The keystrokes are not listed, but should work like
they do in a normal, editable buffer.

This fixes https://savannah.gnu.org/bugs/?61274.

Bug existed since version 4.0, commit bc98dbca.

src/prompt.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 32/34] prompt: keep a clear answer clear also after an
 excursion into history

When the answer at the prompt was clear before the user went up into
the history list, the answer should be cleared again when the user
comes back down to the present.

This fixes https://savannah.gnu.org/bugs/?61308.

Bug existed since before version 2.2.0.

src/global.c | 3 2 + 1 - 0 !
1 file changed, 2 insertions(+), 1 deletion(-)

 [patch 33/34] help: do not show ^s when --preserve is in effect

This fixes https://savannah.gnu.org/bugs/?61317.

Bug existed since version 5.0, since the Execute menu was overhauled.

syntax/email.nanorc | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 34/34] syntax: email: use a character class, as \s does not
 work inside brackets

This fixes https://savannah.gnu.org/bugs/?61347.

Bug existed since version 4.9.3, commit 4f9bebdd.

src/text.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 35/35] justify: correctly determine whether top-of-buffer has
 been reached

The text to be justified has been excised from the buffer and is now
in the cutbuffer, so we cannot compare any of its lines to 'filetop'.

This fixes https://savannah.gnu.org/bugs/?61438.

Bug existed since version 4.0, commit 14c08589.

src/winio.c | 3 2 + 1 - 0 !
1 file changed, 2 insertions(+), 1 deletion(-)

 [patch 36/38] input: ensure that no more bytes are consumed than are
 available

The value of 'consumed' may not exceed the given 'length'.

Bug existed since version 2.9.3, commit e739448c.

(Bug was found by studying Fedora crash reports.  Thank you, Fedora!)

src/text.c | 3 2 + 1 - 0 !
1 file changed, 2 insertions(+), 1 deletion(-)

 [patch 37/38] execute: don't crash when an empty buffer is piped
 through a command

That is, take into account that the cutbuffer could be NULL
(when updating the undo item).

This fixes https://savannah.gnu.org/bugs/?62107.

Bug existed since version 4.9, commit b15c5a7e.

src/text.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 38/38] text: upon enter, eat only lefthand blanks, not any
 other characters

Make sure that there is only whitespace to the left of the cursor
before setting 'allblanks' to TRUE, because this latter value will
cause these characters to be eaten (as a special case, to avoid
creating lines that contain only blanks when both --autoindent
and --breaklonglines are on).

This fixes https://savannah.gnu.org/bugs/?63407.
Reported-by: Tasos Papastylianou <tpapastylianou@hotmail.com>

Bug existed since version 2.9.8, commit d00ab406.