Package: nfswatch / 4.99.11-6

Metadata

Package Version Patches format
nfswatch 4.99.11-6 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
01 manpage.patch | (download)

nfslogsum.8 | 4 2 + 2 - 0 !
nfswatch.8 | 4 2 + 2 - 0 !
2 files changed, 4 insertions(+), 4 deletions(-)

 correct manpage sections.
fix typo in error message.patch | (download)

nfswatch.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix typo in error mesage when filelist is missing
Fix build failure major minor undefined in glibc 2.28.patch | (download)

util.c | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 fix build failure ('major'/'minor' undefined) in glibc 2.28
Bug-Debian: https://bugs.debian.org/916003

With glibc 2.28 nfswatch FTBFS with

	...
	util.c: In function 'setup_nfs_counters':
	util.c:557:27: warning: implicit declaration of function 'major' [-Wimplicit-function-declaration]
		nc->nc_dev.Major = major(st.st_dev);
				   ^~~~~
	util.c:558:27: warning: implicit declaration of function 'minor'; did you mean 'mknod'? [-Wimplicit-function-declaration]
		nc->nc_dev.Minor = minor(st.st_dev);
				   ^~~~~
				   mknod
	...
	cc -o nfswatch dlpi.o logfile.o netaddr.o nfswatch.o nit.o pfilt.o pktfilter.o rpcfilter.o rpcutil.o screen.o snoop.o util.o xdr.o parsenfsfh.o linux.o -lpcap -lncurses -lm
	/usr/bin/ld: util.o: in function `setup_nfs_counters':
	util.c:(.text+0x6d9): undefined reference to `major'
	/usr/bin/ld: util.c:(.text+0x6f6): undefined reference to `minor'
	/usr/bin/ld: util.c:(.text+0x910): undefined reference to `major'
	/usr/bin/ld: util.c:(.text+0x928): undefined reference to `minor'
	/usr/bin/ld: util.o: in function `setup_fil_counters':
	util.c:(.text+0xa5c): undefined reference to `major'
	/usr/bin/ld: util.c:(.text+0xa74): undefined reference to `minor'
	collect2: error: ld returned 1 exit status
	make[2]: *** [Makefile:165: nfswatch] Error 1

glibc 2.28 no longer defines 'major' and 'minor' in <sys/types.h> and
requires us to include <sys/sysmacros.h>. (glibc 2.25 starts
deprecating the macros in <sys/types.h>.)

Thanks: Adrian Bunk <bunk@debian.org>
Closes: #916003