Package: pdl / 1:2.019-5

fits-tilde-expansion.patch Patch series | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
Description: Fix tilde expansion tests for environments with non-existent $HOME.
Author: Bas Couwenberg <sebastic@debian.org>
Bug: https://github.com/PDLPorters/pdl/issues/238
Forwarded: https://github.com/PDLPorters/pdl/pull/240
Applied-Upstream: https://github.com/PDLPorters/pdl/commit/f5d0c3da907eaba1da35b0f098d48dc61226cf27

--- a/t/fits.t
+++ b/t/fits.t
@@ -3,6 +3,8 @@
 
 use strict;
 
+use File::Basename;
+
 use PDL::LiteF;
 
 use PDL::Core ':Internal'; # For howbig()
@@ -12,7 +14,7 @@ use PDL::Config;
 
 kill 'INT',$$  if $ENV{UNDER_DEBUGGER}; # Useful for debugging.
 
-use Test::More tests => 97;
+use Test::More;
 use Test::Exception;
 
 BEGIN {
@@ -318,10 +320,19 @@ SKIP:{
 
 ###############################
 # Check that tilde expansion works
+
 my $tildefile = cfile('~',"PDL-IO-FITS-test_$$.fits");
-lives_ok { sequence(3,5,2)->wfits($tildefile) } "wfits tilde expansion didn't fail";
-lives_ok { rfits($tildefile) } "rfits tilde expansion didn't fail";
-$tildefile =~ s/^(~)/glob($1)/e; #use the same trick as in FITS.pm to resolve this filename.
-unlink($tildefile) or warn "Could not delete $tildefile: $!\n"; #clean up.
+
+# Only read/write the tildefile if the directory is writable.
+# Some build environments, like the Debian pbuilder chroots, use a non-existent $HOME.
+# See: https://github.com/PDLPorters/pdl/issues/238
+if(-w dirname($tildefile)) {
+	lives_ok { sequence(3,5,2)->wfits($tildefile) } "wfits tilde expansion didn't fail";
+	lives_ok { rfits($tildefile) } "rfits tilde expansion didn't fail";
+	$tildefile =~ s/^(~)/glob($1)/e; #use the same trick as in FITS.pm to resolve this filename.
+	unlink($tildefile) or warn "Could not delete $tildefile: $!\n"; #clean up.
+}
+
+done_testing();
 
 1;