Package: ppc64-diag / 2.7.1-6

Metadata

Package Version Patches format
ppc64-diag 2.7.1-6 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
no upstream init.patch | (download)

scripts/Makefile | 7 5 + 2 - 0 !
scripts/opal_errd.service | 4 2 + 2 - 0 !
scripts/ppc64_diag_register | 11 11 + 0 - 0 !
scripts/rtas_errd.service | 5 3 + 2 - 0 !
4 files changed, 21 insertions(+), 6 deletions(-)

 don't install upstream systemd or sysvinit scripts for now.
   * Skip installing systemd units for now, since they also seem
     to depend on installing upstream's version of the init jobs.
systemd installdir.patch | (download)

rules.mk | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix path for systemd system services
 The location used is the one used on Fedora/Redhat and it is not the same on
 Debian/Ubuntu
honor compilation env variables.patch | (download)

diags/Makefile | 4 2 + 2 - 0 !
ela/Makefile | 6 3 + 3 - 0 !
lpd/Makefile | 6 3 + 3 - 0 !
opal_errd/Makefile | 4 2 + 2 - 0 !
opal_errd/opal-elog-parse/Makefile | 2 1 + 1 - 0 !
rtas_errd/Makefile | 6 3 + 3 - 0 !
rules.mk | 2 1 + 1 - 0 !
7 files changed, 15 insertions(+), 15 deletions(-)

 honor compilation environment variables
 On Debian, compilation process expects the upstream Makefile to take into
 account LDFLAGS, CPPFLAGS sent in the environment for hardening :
 https://wiki.debian.org/Hardening
 This patch enable the Makefile to take into account these variables.
 .
 ppc64-diag (2.7.0-1) unstable; urgency=medium
 .
   * Import from Ubuntu (Closes: #999999)
improve unit files.patch | (download)

scripts/opal_errd.service | 2 1 + 1 - 0 !
scripts/rtas_errd.service | 2 1 + 1 - 0 !
2 files changed, 2 insertions(+), 2 deletions(-)

 improve unit files
 On Debian at least, systemd service file refers to an obsolete target.
 Some targets are obsolete by now, e.g. syslog.target or dbus.target. For
 example, declaring After=syslog.target is unnecessary by now because
 syslog is socket-activated and will therefore be started when needed.
 Also, providing a Documentation key as we have man pages available.
 .
 ppc64-diag (2.7.0-1) unstable; urgency=medium
 .
   * Import from Ubuntu (Closes: #999999)
fix too many typos.patch | (download)

common/utils.c | 2 1 + 1 - 0 !
ela/message_catalog/e1000e | 4 2 + 2 - 0 !
ela/message_catalog/with_regex/e1000e | 4 2 + 2 - 0 !
lpd/files.c | 2 1 + 1 - 0 !
lpd/indicator.c | 4 2 + 2 - 0 !
lpd/indicator_rtas.c | 4 2 + 2 - 0 !
lpd/lp_diag.c | 2 1 + 1 - 0 !
lpd/test/lpd_ela_test.sh | 4 2 + 2 - 0 !
opal_errd/opal-elog-parse/opal-ei-scn.c | 2 1 + 1 - 0 !
opal_errd/opal-elog-parse/opal-event-data.c | 2 1 + 1 - 0 !
opal_errd/opal_errd.c | 2 1 + 1 - 0 !
opal_errd/run_tests | 2 1 + 1 - 0 !
rtas_errd/config.c | 2 1 + 1 - 0 !
rtas_errd/ela.c | 10 5 + 5 - 0 !
rtas_errd/ela_msg.h | 4 2 + 2 - 0 !
rtas_errd/epow.c | 2 1 + 1 - 0 !
rtas_errd/extract_platdump.c | 6 3 + 3 - 0 !
rtas_errd/files.c | 8 4 + 4 - 0 !
rtas_errd/prrn.c | 2 1 + 1 - 0 !
rtas_errd/update.c | 6 3 + 3 - 0 !
rules.mk | 2 1 + 1 - 0 !
21 files changed, 38 insertions(+), 38 deletions(-)

 fix typos
 Lot's of typo polluting the code and being detected when packaging for Debian.
manpage space character is not allowed in an escape name.patch | (download)

opal-dump-parse/opal-dump-parse.8 | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix manpage
 Fixed the "a space character is not allowed in an escape name" problem to avoid
 a lintian issue
CVE 2014 4038.patch | (download)

lpd/test/lpd_ela_test.sh | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fixes for cve-2014-4038
- rtas_errd/diag_support.c and /tmp/get_dt_files : was already fixed upstream
- scripts/ppc64_diag_mkrsrc and /tmp/diagSEsnap/snapH.tar.gz : snap is not
  supported and got removed from powerpc-ibm-utils : the tarball will never be
  created on Debian/Ubuntu
- lpd/test/lpd_ela_test.sh and /var/tmp/ras : patched 
CVE 2014 4039.patch | (download)

scripts/ppc64_diag_mkrsrc | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fixes for cve-2014-4039
- uses 0775 permissions for /tmp/diagSEsnap : patched
- does not properly restrict permissions for /tmp/diagSEsnap/snapH.tar.gz :
  snap is not supported and got removed from powerpc-ibm-utils : the tarball
  will never be created on Debian/Ubuntu
marvell leds 0001 add support.patch | (download)

lpd/Makefile | 2 1 + 1 - 0 !
lpd/indicator.h | 3 2 + 1 - 0 !
lpd/indicator_marvell.c | 543 543 + 0 - 0 !
lpd/indicator_marvell.h | 27 27 + 0 - 0 !
lpd/indicator_opal.c | 8 8 + 0 - 0 !
5 files changed, 581 insertions(+), 2 deletions(-)

 [patch 1/8] lpd: add support for marvell hdd leds on s822lc for hpc

This patch introduces support for the identification/fault LEDs of the
Marvell SATA HDD controller present in the IBM Power System S822LC for
HPC (a.k.a. Garrison/Minsky).

  indicator.h:        add the indicator type 'TYPE_MARVELL'.
  indicator_marvell.{h,c}:
                      implement the 'indicator' interface (get indices,
                      get/set indicator), and required hardware logic.
  indicator_opal.c:   call such interface on 'TYPE_MARVELL' devices.
  Makefile.c:         build and reference the indicator_marvell.o file.

The code for the hardware logic is based on a sample code written by
Douglas Miller <dougmill@us.ibm.com>, acknowledged in indicator_marvell.c.

Signed-off-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

marvell leds 0002 handle non unique loc.patch | (download)

lpd/usysident.c | 48 47 + 1 - 0 !
1 file changed, 47 insertions(+), 1 deletion(-)

 [patch 2/8] lpd: marvell: handle non-unique/duplicate location codes

marvell leds 0003 do not exit early sys class led.patch | (download)

lpd/indicator_opal.c | 55 51 + 4 - 0 !
1 file changed, 51 insertions(+), 4 deletions(-)

 [patch 3/8] lpd: marvell: do not exit early on empty /sys/class/leds
 dir (OPAL)

Some systems/conditions have no kernel LEDs present (thus nothing in
the /sys/class/leds directory), which would cause usysident to early
exit in the OPAL platform, and not give a chance for other LED types
(e.g., Marvell HDD LEDs) to be used.

This patch adds a check for that in the OPAL platform probe function,
and in case Marvell HDD devices are found, prevent usysident to exit
early, so they can be used.

Signed-off-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

marvell leds 0004 opal call all get_indices in opal_get_indicator.patch | (download)

lpd/indicator_opal.c | 25 11 + 14 - 0 !
1 file changed, 11 insertions(+), 14 deletions(-)

 [patch 4/8] lpd: opal: call all get_indices() in
 opal_get_indicator_list()

Dont return early in opal_get_indicator_list() in case any of
the get_indices() call happens to fail.  Let's go through all
the calls to ensure any other pending/possible indicator that
can work still goes into the list.

Signed-off-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
[ We do not support FRU fault indicator in Guiding Light Mode. All current
  OPAL systems supports Light Path Mode. Just to be safe I've reintroduced
  LED mode check - Vasant]
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

marvell leds 0005 validate get indicator for loc.patch | (download)

lpd/lp_diag.c | 8 8 + 0 - 0 !
1 file changed, 8 insertions(+)

 [patch 5/8] lpd: validate get_indicator_for_loc_code() return value

Just to be on safer side, validate get_indicator_for_loc_code() return
value.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

marvell leds 0006 remove warning.patch | (download)

lpd/indicator_opal.c | 2 0 + 2 - 0 !
1 file changed, 2 deletions(-)

 [patch 6/8] lpd: remove redundant warning message

We will be able to support indicators from other sources (like HDD)
even though OPAL platform indicators are not present.

Also leds_powernv driver is loaded automatically if we have platform
support.

Hence remove this message.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

marvell leds 0007 check for dt property.patch | (download)

lpd/indicator_opal.c | 7 7 + 0 - 0 !
1 file changed, 7 insertions(+)

 [patch 7/8] lpd: check for device tree property

Not all OPAL system supports OPAL leds. Check the existence of DT
property before using. Also if DT property doesn't exists, then
assume its in Light Path mode.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

marvell leds 0008 fix test case.patch | (download)

lpd/test/Makefile | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 8/8] lpd/test: fix test case

Commit 4c7400ba added Marvell HDD LED code, but forgot to update test
dir Makefile. Though we don't support fault LED on Marvell HDD, we
need to update test/Makefile, else compilation will fail.

I think we have to rewrite part of test code. But that's for some other day.

Fixes: 4c7400ba (lpd: Add support for Marvell HDD LEDs on S822LC for HPC)
CC: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

marvell leds 0009 volatile.patch | (download)

lpd/indicator_marvell.c | 8 4 + 4 - 0 !
1 file changed, 4 insertions(+), 4 deletions(-)

 [patch] lpd: marvell: mark the indirect-access registers as volatile

In optimization level -O3, a sequence of VSR read/write operations
can be incorrectly optimized away as the compiler doesn't know the
underlying memory locations can change and react to read/writes.

So, mark the pointers used to read/write to the indirect-access
registers which access the VSRs with the 'volatile' keyword.

Test-cases: