include/QtCrypto/qca_export.h | 2 2 + 0 - 0 !
1 file changed, 2 insertions(+)

 define qca_export as q_decl_export on non-windows systems so we
 can build with -fvisibility=hidden.

unittest/pipeunittest/pipeunittest.cpp | 32 16 + 16 - 0 !
1 file changed, 16 insertions(+), 16 deletions(-)

 pipeunittest: raise the qwait() times to 100ms
 In some cases 1ms can be too few to be able to actually read the data from
 pipes and propagating the events with signals and timeouts.
 Raise the waits to 100ms to give enough time without slowing the test too
 much.

src/botantools/botan/alloc_mmap/mmap_mem.cpp | 15 13 + 2 - 0 !
1 file changed, 13 insertions(+), 2 deletions(-)

 ignore enosys errors for msync() on hurd
 Due to mlock() issues the mmap allocator is used; that allocator uses msync(),
 which is not implemented yet in glibc for Hurd (thus returning ENOSYS).
 Temporarly ignore such failures, with the option to not fail on other errors
 (in case msync() gets implemented).

unittest/CMakeLists.txt | 1 0 + 1 - 0 !
1 file changed, 1 deletion(-)

 ignore test
 this test works locally but not in the buildd for some reason

plugins/qca-ossl/qca-ossl.cpp | 2 2 + 0 - 0 !
1 file changed, 2 insertions(+)

 qca-ossl: fix build without sslv3

src/qca_textfilter.cpp | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 fix base64 decoding on arm

This code was broken on ARM and other architectures where "char" is unsigned by
default.

First, it breaks with newer compilers with errors like:

  .../src/qca_textfilter.cpp:314:2: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

Second, if the compiler would just allow this conversion then the unsigned char
would hold 255, which would not be sign extended when cast to an int later, so
all the checks "< 0" will never trigger, and so invalid input characters cannot
be detected.

REVIEW:128295
BUG:364495