1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
|
From 674e458819c99ad7c06816045aad3eeb68cbac94 Mon Sep 17 00:00:00 2001
From: Andrew Ruthven <andrew@etc.gen.nz>
Date: Mon, 6 Jul 2020 21:30:54 +1200
Subject: Force use of IPv4 for LDAP test.
Net::LDAP::Server::Test binds to IPv6 by default, but Net::LDAP uses
'localhost' which resolves to an IPv4 address. Even when I switched
the call to Net::LDAP->new() to use ip6-localhost it failed elsewhere
due to RT using 127.0.0.1.
Patch-Name: fix_test_ldap_ipv4.diff
Forwarded: https://github.com/bestpractical/rt/pull/367
---
t/externalauth/ldap.t | 12 +++++++++---
t/externalauth/ldap_email_login.t | 11 +++++++++--
t/externalauth/ldap_escaping.t | 11 +++++++++--
t/externalauth/ldap_group.t | 11 +++++++++--
t/externalauth/ldap_privileged.t | 11 +++++++++--
t/ldapimport/group-callbacks.t | 11 +++++++++--
t/ldapimport/group-import.t | 11 +++++++++--
t/ldapimport/group-member-import.t | 11 +++++++++--
t/ldapimport/group-rename.t | 11 +++++++++--
t/ldapimport/user-import-cfs.t | 11 +++++++++--
t/ldapimport/user-import-privileged.t | 11 +++++++++--
t/ldapimport/user-import.t | 11 +++++++++--
12 files changed, 108 insertions(+), 25 deletions(-)
diff --git a/t/externalauth/ldap.t b/t/externalauth/ldap.t
index 7ec21081..0a0eb670 100644
--- a/t/externalauth/ldap.t
+++ b/t/externalauth/ldap.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -7,12 +8,17 @@ eval { require RT::Authen::ExternalAuth; require Net::LDAP::Server::Test; 1; } o
plan skip_all => 'Unable to test without Net::LDAP and Net::LDAP::Server::Test';
};
-
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port" );
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
my $username = "testuser";
my $base = "dc=bestpractical,dc=com";
diff --git a/t/externalauth/ldap_email_login.t b/t/externalauth/ldap_email_login.t
index ffb726f7..69e715a7 100644
--- a/t/externalauth/ldap_email_login.t
+++ b/t/externalauth/ldap_email_login.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -8,10 +9,16 @@ eval { require RT::Authen::ExternalAuth; require Net::LDAP::Server::Test; 1; } o
};
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port" );
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
my $base = 'dc=bestpractical,dc=com';
diff --git a/t/externalauth/ldap_escaping.t b/t/externalauth/ldap_escaping.t
index b46c3ffe..6f8b500f 100644
--- a/t/externalauth/ldap_escaping.t
+++ b/t/externalauth/ldap_escaping.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -9,10 +10,16 @@ eval { require RT::Authen::ExternalAuth; require Net::LDAP::Server::Test; 1; } o
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port" );
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
my $users_dn = "ou=users,dc=bestpractical,dc=com";
diff --git a/t/externalauth/ldap_group.t b/t/externalauth/ldap_group.t
index 168c37b0..3bb23ede 100644
--- a/t/externalauth/ldap_group.t
+++ b/t/externalauth/ldap_group.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
# This lets us change config during runtime without restarting
BEGIN {
@@ -14,10 +15,16 @@ eval { require RT::Authen::ExternalAuth; require Net::LDAP::Server::Test; 1; } o
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port" );
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
my $users_dn = "ou=users,dc=bestpractical,dc=com";
diff --git a/t/externalauth/ldap_privileged.t b/t/externalauth/ldap_privileged.t
index 02e760bf..7e1db471 100644
--- a/t/externalauth/ldap_privileged.t
+++ b/t/externalauth/ldap_privileged.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -8,10 +9,16 @@ eval { require RT::Authen::ExternalAuth; require Net::LDAP::Server::Test; 1; } o
};
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port" );
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
my $username = "testuser";
my $base = "dc=bestpractical,dc=com";
diff --git a/t/ldapimport/group-callbacks.t b/t/ldapimport/group-callbacks.t
index 272d3292..86901b31 100644
--- a/t/ldapimport/group-callbacks.t
+++ b/t/ldapimport/group-callbacks.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -11,9 +12,15 @@ my $importer = RT::LDAPImport->new;
isa_ok($importer,'RT::LDAPImport');
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port");
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
$ldap->add("dc=bestpractical,dc=com");
diff --git a/t/ldapimport/group-import.t b/t/ldapimport/group-import.t
index fc3f97bd..dddf3c6b 100644
--- a/t/ldapimport/group-import.t
+++ b/t/ldapimport/group-import.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -11,9 +12,15 @@ my $importer = RT::LDAPImport->new;
isa_ok($importer,'RT::LDAPImport');
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port");
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
$ldap->add("dc=bestpractical,dc=com");
diff --git a/t/ldapimport/group-member-import.t b/t/ldapimport/group-member-import.t
index 651f5ab6..9be83c54 100644
--- a/t/ldapimport/group-member-import.t
+++ b/t/ldapimport/group-member-import.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -11,9 +12,15 @@ my $importer = RT::LDAPImport->new;
isa_ok($importer,'RT::LDAPImport');
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port");
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
$ldap->add("dc=bestpractical,dc=com");
diff --git a/t/ldapimport/group-rename.t b/t/ldapimport/group-rename.t
index 786533ef..56967620 100644
--- a/t/ldapimport/group-rename.t
+++ b/t/ldapimport/group-rename.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -11,9 +12,15 @@ my $importer = RT::LDAPImport->new;
isa_ok($importer,'RT::LDAPImport');
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port");
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
$ldap->add("dc=bestpractical,dc=com");
diff --git a/t/ldapimport/user-import-cfs.t b/t/ldapimport/user-import-cfs.t
index a0c723ee..d7f47854 100644
--- a/t/ldapimport/user-import-cfs.t
+++ b/t/ldapimport/user-import-cfs.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -26,10 +27,16 @@ my $importer = RT::LDAPImport->new;
isa_ok($importer,'RT::LDAPImport');
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port");
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
$ldap->add("ou=foo,dc=bestpractical,dc=com");
diff --git a/t/ldapimport/user-import-privileged.t b/t/ldapimport/user-import-privileged.t
index 4b155eea..28ee9463 100644
--- a/t/ldapimport/user-import-privileged.t
+++ b/t/ldapimport/user-import-privileged.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -11,10 +12,16 @@ my $importer = RT::LDAPImport->new;
isa_ok($importer,'RT::LDAPImport');
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port");
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
$ldap->add("ou=foo,dc=bestpractical,dc=com");
diff --git a/t/ldapimport/user-import.t b/t/ldapimport/user-import.t
index c4f6a593..7b8ab2d1 100644
--- a/t/ldapimport/user-import.t
+++ b/t/ldapimport/user-import.t
@@ -1,5 +1,6 @@
use strict;
use warnings;
+use IO::Socket::INET;
use RT::Test tests => undef;
@@ -11,10 +12,16 @@ my $importer = RT::LDAPImport->new;
isa_ok($importer,'RT::LDAPImport');
my $ldap_port = RT::Test->find_idle_port;
-ok( my $server = Net::LDAP::Server::Test->new( $ldap_port, auto_schema => 1 ),
+my $ldap_socket = IO::Socket::INET->new(
+ Listen => 5,
+ Proto => 'tcp',
+ Reuse => 1,
+ LocalPort => $ldap_port,
+);
+ok( my $server = Net::LDAP::Server::Test->new( $ldap_socket, auto_schema => 1 ),
"spawned test LDAP server on port $ldap_port");
-my $ldap = Net::LDAP->new("localhost:$ldap_port");
+my $ldap = Net::LDAP->new("localhost:$ldap_port") || die "Failed to connect to LDAP server: $@";
$ldap->bind();
$ldap->add("ou=foo,dc=bestpractical,dc=com");
|
