source3/include/libsmbclient.h | 2 2 + 0 - 0 !
1 file changed, 2 insertions(+)

 ensure libsmbclient.h is being used with lfs enabled

lib/tevent/testsuite.c | 4 4 + 0 - 0 !
lib/util/tests/tfork.c | 3 3 + 0 - 0 !
2 files changed, 7 insertions(+)

 hurd compatibility changes

examples/LDAP/README | 3 3 + 0 - 0 !
1 file changed, 3 insertions(+)

 mention smbldap-tools package in examples/ldap/readme

Bug-Debian: http://bugs.debian.org/341934

source3/include/local.h | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 use the pager alternative as pager is pager is undefined

Bug-Debian: http://bugs.debian.org/135603

docs-xml/smbdotconf/misc/usersharemaxshares.xml | 2 1 + 1 - 0 !
lib/param/loadparm.c | 2 2 + 0 - 0 !
source3/param/loadparm.c | 2 1 + 1 - 0 !
3 files changed, 4 insertions(+), 2 deletions(-)

 enable net usershares by default at build time

Enable net usershares by default at build time, with a limit of 100, and update
the corresponding documentation.

Bug-Debian: http://bugs.debian.org/443230
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/128548

third_party/heimdal/lib/wind/rfc3454.txt-table | 7074 7074 + 0 - 0 !
third_party/heimdal_build/wscript_build | 6 3 + 3 - 0 !
2 files changed, 7077 insertions(+), 3 deletions(-)

 patch in symbol table from rfc3454, for heimdal scripts

buildtools/wafsamba/wafsamba.py | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 add so version number to private libraries for dpkg-shlibdeps

We also want dpkg-shlibdeps to generate correct dependency information
for the private libraries in our binary packages, but dpkg-shlibdeps
only works when the library has a version number.

packaging/systemd/smb.service.in | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 [patch] smbd.service: run update-apparmor-samba-profile before start

Bug-Debian: https://bugs.debian.org/896080

ctdb/config/events/legacy/06.nfs.script | 2 1 + 1 - 0 !
ctdb/config/events/legacy/60.nfs.script | 6 4 + 2 - 0 !
ctdb/config/nfs-linux-kernel-callout | 19 17 + 2 - 0 !
ctdb/config/statd-callout | 4 3 + 1 - 0 !
4 files changed, 25 insertions(+), 6 deletions(-)

 fix nfs related service names

Upstream defines nfs related service names based on the Linux
distribution. This patch fixes the names for Debian and derivatives.

Update by Andreas Hasenack <andreas@canonical.com> (LP: #1961840):
Use nfsconf(8) if it's available, instead of parsing the old config
files in /etc/default/nfs-*

Bug-Debian: https://bugs.debian.org/929931
Bug-Ubuntu: https://bugs.launchpad.net/bugs/722201

ctdb/config/ctdb.conf | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

---

lib/ldb/wscript | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch] force ldb as standalone

lib/replace/replace.h | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 use bzero() instead of memset_s()

lib/replace/replace.h header defines ZERO_STRUCT macro
which uses memset_s() function (which is similar to
memset() but can not be optimized out by the compiler).
Glibc has bzero() with similar property, while memset_s()
have is implemented in lib/replace/replace.c, - this way,
some binaries needlessly link with libreplace-samba4 just
to get rep_memset_s() symbol. By using bzero() instead,
this endless linkage is eliminated, so we can package,
for example, libldb (which uses ZERO_STRUCT) without it
linking to libreplace-samba4.

Note: actually using explicit_bzero() so it is not optimized
out by the compiler - this is the original goal of using
memset_s().

ctdb/doc/ctdb-etcd.7.xml | 2 1 + 1 - 0 !
ctdb/utils/etcd/ctdb_etcd_lock | 2 1 + 1 - 0 !
2 files changed, 2 insertions(+), 2 deletions(-)

 fix pathname for ctdb_etcd_lock

ctdb/config/ctdb.init | 1 1 + 0 - 0 !
packaging/systemd/ctdb.service.in | 1 1 + 0 - 0 !
2 files changed, 2 insertions(+)

 create ctdb pid directory

(which is /run/ctdb/). Create it in the systemd service
file (using RuntimeDirectory directive) and in the sysv-init
script.

buildtools/wafsamba/samba_waf18.py | 6 3 + 3 - 0 !
1 file changed, 3 insertions(+), 3 deletions(-)

 silence uselib_local warning produced by waf

source3/lib/util_sec.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 disable setuid configure checks

For some strange reason, when running reprotest test on salsa-ci,
which apparently is running as root, - on the *second* build only
the configure fails (after successfully built package the first
time). The configure test tries to change gid and verifies it
actually changed (not that the syscall exist), - and that fails.
Since it is extremely uncommon to configure the build process as
root, salsa-ci test environment details are quite deep down the line,
and we know the syscall actually works, just disable the probe,
pretending we are not root.

source3/lib/messages.c | 9 2 + 7 - 0 !
source4/lib/messaging/messaging.c | 2 1 + 1 - 0 !
2 files changed, 3 insertions(+), 8 deletions(-)

 move msg.sock from /var/lib/samba to /run/samba

This moves a socket directory from /var/lib/samba to /run/samba.

https://lists.samba.org/archive/samba-technical/2022-April/137322.html

python/samba/netcmd/testparm.py | 6 2 + 4 - 0 !
source3/utils/testparm.c | 6 2 + 4 - 0 !
2 files changed, 4 insertions(+), 8 deletions(-)

 testparm: do not fail if /run/samba does not exist

testparm explicitly fails if $piddir or $lockdir does not exist.
However, the daemons which actually use these directories, will
create it on demand, there is no need to fail even simple testparm
operations if the dirs are not there.

This change lets to (pre)configure samba without bothering to
pre-create the directories which are overwise needed only to fulfil
testparm criteria.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

lib/util/wscript_build | 2 1 + 1 - 0 !
source3/wscript_build | 4 2 + 2 - 0 !
2 files changed, 3 insertions(+), 3 deletions(-)

 add missing libs deps
Bug-Debian: https://bugs.debian.org/1010922

Lots of samba libraries has incomplete dependencies listed
in wscript files.  This usually is not a problem since the
link line includes dependencies of their dependencies of
their dependencies, and somewhere down that line all immediate
dependencies which are missing are actually present.  But
sometimes this becomes a problem when a library does not
declare direct dependency on at least one private library
which it actually uses: in case no private library is
listed as direct dependency, private library directory is
not put into RUNPATH of the resulting binary, so the binary
can not find its own dependencies.

Fix a few such places, including one library which is a part
of public abi (libsmbldap).

bootstrap/config.py | 2 1 + 1 - 0 !
ctdb/common/system.c | 2 1 + 1 - 0 !
ctdb/server/ctdb_recoverd.c | 2 1 + 1 - 0 !
docs-xml/manpages/vfs_fruit.8.xml | 2 1 + 1 - 0 !
lib/smbconf/pysmbconf.c | 2 1 + 1 - 0 !
source3/smbd/msdfs.c | 2 1 + 1 - 0 !
source3/smbd/smbXsrv_client.c | 4 2 + 2 - 0 !
source3/winbindd/wb_sids2xids.c | 2 1 + 1 - 0 !
source4/torture/smb2/ea.c | 2 1 + 1 - 0 !
source4/torture/smb2/session.c | 26 13 + 13 - 0 !
10 files changed, 23 insertions(+), 23 deletions(-)

 various spelling fixes

Various spelling fixes in the code which sneaks into binaries.

third_party/uid_wrapper/uid_wrapper.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 uwrap: fix getresgid wrapping typo
Bug: https://bugzilla.samba.org/show_bug.cgi?id=15227

This was making e.g. p11-kit crash on getresgid() call.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

source3/modules/vfs_fruit.c | 11 0 + 11 - 0 !
1 file changed, 11 deletions(-)

 [patch] fruit: disable useless size_t overflow check
Bug-Debian: http://bugs.debian.org/974868

As has been said several times in
https://bugzilla.samba.org/show_bug.cgi?id=13622 ,
the check 'bandsize > SIZE_MAX/nbands' is useless.  But it
is also wrong, in 2 ways: first, nbands might be 0 (when
no bands has been allocated yet), and second, there's no
point in comparing this with SIZE_MAX, since size_t on 32bit
platforms is a 32bit integer, while bandsize is off_t which
is 64bits (samba always enables LFS).

This check causes the module to fail when bandsize*nbands
exceeds 32bits, which has been reported for example at
https://bugs.debian.org/974868 .

Whole thing can't overflow because it is already guarded
by time_machine_max_size.  Or at the very least, by current
disk sizes... :)

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

python/samba/provision/common.py | 5 4 + 1 - 0 !
1 file changed, 4 insertions(+), 1 deletion(-)

 print meaningful error message if samba-ad-provision is not installed

python/samba/netcmd/domain.py | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 print meaningful error message if python3-markdown is not installed

ctdb/wscript | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 ctdb: use /run/ctdb instead of /var/run/ctdb

Whole upstream path assignment needs a review.

third_party/heimdal_build/wscript_build | 8 6 + 2 - 0 !
third_party/heimdal_build/wscript_configure | 2 2 + 0 - 0 !
2 files changed, 8 insertions(+), 2 deletions(-)

 configure builtin heimdal to support keyring ccache
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Organization: Samsung R&D Institute Poland

Signed-off-by: ukasz Stelmach <l.stelmach@samsung.com>