Package: solid / 5.54.0-1

Metadata

Package Version Patches format
solid 5.54.0-1 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
use_shortest_filepath.diff | (download)

src/solid/devices/backends/udisks2/udisksstorageaccess.cpp | 33 22 + 11 - 0 !
1 file changed, 22 insertions(+), 11 deletions(-)

 use_shortest_filepath


fix FTBFS on mipsel and m68k src solid predicate_parser.c.patch | (download)

src/solid/CMakeLists.txt | 2 2 + 0 - 0 !
src/solid/devices/CMakeLists.txt | 1 1 + 0 - 0 !
2 files changed, 3 insertions(+)

 fix ftbfs on mipsel and m68k - src/solid/predicate_parser.c: no such
 file or directory

In src/solid/CMakeLists.txt, the parser is generated using bison_target
which uses add_custom_command under the hood. The output file is then
added to the list of sources creating a file-level dependency from the
KF5Solid target to the bison/flex generation command. However, the list
of sources is later used as part of the KF5Solid_static target. Since
file-level dependencies cannot cross between targets, the bison
generation happens twice completely independently as part of the two
targets. If you are very unlucky, the generation in one target can
happen at the same time as the compilation of the parser in the other
target causing a collision.

This patch should fix that by putting the generation in a
separate target and manually adding a dependency on it. This forces the
parser to be generated before anything is compiled.

disable_halbasictest.diff | (download)

autotests/halbasictest.cpp | 1 1 + 0 - 0 !
1 file changed, 1 insertion(+)

 disable the halbasictest test
 This test is run on non-Linux architectures, where the hal backend is built.
 Since hal is long gone, testing this backend is not useful (and may fail),
 so disable this test.
 .
 A long term solution is to disable the hal backend altogether, making sure
 the related test is disabled too.