Package: starjava-util / 1.0+2019.01.04-1

Metadata

Package Version Patches format
starjava-util 1.0+2019.01.04-1 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
Fix build.xml for use outside of starjava.patch | (download)

build.xml | 52 22 + 30 - 0 !
1 file changed, 22 insertions(+), 30 deletions(-)

 fix build.xml for use outside of starjava

This includes the following changes:

 * Rename the `extclasspath` elements to `path`. With ant >= 1.6, there is no
Use commons compress instead of apache ant.patch | (download)

build.xml | 2 2 + 0 - 0 !
src/main/uk/ac/starlink/util/Compression.java | 10 2 + 8 - 0 !
src/testcases/uk/ac/starlink/util/DataSourceTest.java | 7 2 + 5 - 0 !
3 files changed, 6 insertions(+), 13 deletions(-)

 use commons-compress instead of apache ant


Fix possible threading bug in PipeReaderThread.patch | (download)

src/main/uk/ac/starlink/util/PipeReaderThread.java | 19 4 + 15 - 0 !
1 file changed, 4 insertions(+), 15 deletions(-)

 fix possible threading bug in pipereaderthread

Close the FastPipedInputStream in the finishReading method rather
than in the run() method.  finishReading executes a join(), so
it's guaranteed to run after run() has finished anyway.

I *think* this later close may avoid some occasionally seen
race conditions (manifesting as Debian astro build unit test
failures in SkeletonDOMBuilder.InlineFITSStreamHandler)
in which a write triggered from the output end stream close failed
because the input end had already been closed.
Though I still don't completely understand it, and was unable to
reproduce the failure locally.