Package: sysvinit / 2.88dsf-41+deb7u1

92_kfreebsd_ifdown.patch Patch series | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
--- a/src/ifdown.c
+++ b/src/ifdown.c
@@ -37,6 +37,23 @@
 
 #define MAX_IFS	64
 
+/* XXX: Ideally this would get detected at configure time... */
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || \
+    defined(__NetBSD__) || defined(__OpenBSD__)
+#define HAVE_SOCKADDR_SA_LEN 1
+#endif
+
+#ifndef _SIZEOF_ADDR_IFREQ
+#ifdef HAVE_SOCKADDR_SA_LEN
+#define _SIZEOF_ADDR_IFREQ(ifr) \
+	((ifr).ifr_addr.sa_len > sizeof(struct sockaddr) ? \
+	 (sizeof((ifr).ifr_name) + (ifr).ifr_addr.sa_len) : \
+	  sizeof(struct ifreq))
+#else
+#define _SIZEOF_ADDR_IFREQ(ifr) sizeof(struct ifreq)
+#endif
+#endif
+
 /*
  *	First, we find all shaper devices and down them. Then we
  *	down all real interfaces. This is because the comment in the
@@ -45,10 +62,10 @@
  */
 int ifdown(void)
 {
-	struct ifreq ifr[MAX_IFS];
+	char ifr_buf[sizeof(struct ifreq) * MAX_IFS];
+	char *ifr_end;
 	struct ifconf ifc;
-	int i, fd;
-	int numif;
+	int fd;
 	int shaper;
 
 	if ((fd = socket(AF_INET, SOCK_DGRAM, 0)) < 0) {
@@ -56,8 +73,8 @@
 		perror("socket");
 		return -1;
 	}
-	ifc.ifc_len = sizeof(ifr);
-	ifc.ifc_req = ifr;
+	ifc.ifc_len = sizeof(ifr_buf);
+	ifc.ifc_buf = ifr_buf;
 
 	if (ioctl(fd, SIOCGIFCONF, &ifc) < 0) {
 		fprintf(stderr, "ifdown: ");
@@ -65,42 +82,55 @@
 		close(fd);
 		return -1;
 	}
-	numif = ifc.ifc_len / sizeof(struct ifreq);
+	ifr_end = ifr_buf + ifc.ifc_len;
 
 	for (shaper = 1; shaper >= 0; shaper--) {
-		for (i = 0; i < numif; i++) {
+		char *ifr_next = ifr_buf;
+
+		while (ifr_next < ifr_end) {
+			struct ifreq *ifr;
+			int flags;
 
-			if ((strncmp(ifr[i].ifr_name, "shaper", 6) == 0)
+			ifr = (struct ifreq *)ifr_next;
+			ifr_next += _SIZEOF_ADDR_IFREQ(*ifr);
+
+			if ((strncmp(ifr->ifr_name, "shaper", 6) == 0)
 			    != shaper) continue;
 
-			if (strcmp(ifr[i].ifr_name, "lo") == 0)
+			if (strncmp(ifr->ifr_name, "lo", 2) == 0)
 				continue;
-			if (strchr(ifr[i].ifr_name, ':') != NULL)
+			if (strchr(ifr->ifr_name, ':') != NULL)
 				continue;
 
 			/* Read interface flags */
-			if (ioctl(fd, SIOCGIFFLAGS, &ifr[i]) < 0) {
+			if (ioctl(fd, SIOCGIFFLAGS, ifr) < 0) {
 				fprintf(stderr, "ifdown: shutdown ");
-				perror(ifr[i].ifr_name);
+				perror(ifr->ifr_name);
 				continue;
 			}
 			/*
 			 * Expected in <net/if.h> according to
 			 * "UNIX Network Programming".
 			 */
-#ifdef ifr_flags
-# define IRFFLAGS	ifr_flags
-#else	/* Present on kFreeBSD */
-# define IRFFLAGS	ifr_flagshigh
+#ifdef ifr_flagshigh
+			flags = (ifr->ifr_flags & 0xffff) |
+			        (ifr->ifr_flagshigh << 16);
+#else
+			flags = ifr->ifr_flags;
+#endif
+			if (flags & IFF_UP) {
+				flags &= ~(IFF_UP);
+#ifdef ifr_flagshigh
+				ifr->ifr_flags = flags & 0xffff;
+				ifr->ifr_flagshigh = flags >> 16;
+#else
+				ifr->ifr_flags = flags;
 #endif
-			if (ifr[i].IRFFLAGS & IFF_UP) {
-				ifr[i].IRFFLAGS &= ~(IFF_UP);
-				if (ioctl(fd, SIOCSIFFLAGS, &ifr[i]) < 0) {
+				if (ioctl(fd, SIOCSIFFLAGS, ifr) < 0) {
 					fprintf(stderr, "ifdown: shutdown ");
-					perror(ifr[i].ifr_name);
+					perror(ifr->ifr_name);
 				}
 			}
-#undef IRFFLAGS
 		}
 	}
 	close(fd);