Package: totem / 3.38.0-2

test-totem-Properly-handle-menu-text-for-undetermined-lan.patch Patch series | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
From: =?utf-8?b?Ik1hcmNvIFRyZXZpc2FuIChUcmV2acOxbyki?= <mail@3v1n0.net>
Date: Tue, 15 Sep 2020 02:08:48 +0200
Subject: test-totem: Properly handle menu text for undetermined language
 audio

As per get_language_name_no_und() code that is called when building the
menu labels, we explicitly set generic track name if no valid language
is set.
However to check this we verify if the string returned by
gst_tag_get_language_name() is set, but this value is now a translated
string in recent gstreamer versions.

So to ensure that the returned language name is a valid one let's
confirm it via calling gst_tag_check_language_code().

Origin: https://gitlab.gnome.org/GNOME/totem/-/merge_requests/179
---
 src/totem-menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/totem-menu.c b/src/totem-menu.c
index 20b9764..388db64 100644
--- a/src/totem-menu.c
+++ b/src/totem-menu.c
@@ -400,7 +400,7 @@ get_language_name_no_und (const char   *lang,
 	const char *ret;
 
 	ret =  gst_tag_get_language_name (lang);
-	if (ret != NULL)
+	if (ret != NULL && gst_tag_check_language_code (lang))
 		return ret;
 
 	switch (track_type) {