1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479
|
package solver
import (
"context"
"fmt"
"github.com/hlandau/acmetool/responder"
"github.com/hlandau/acmetool/util"
denet "github.com/hlandau/goutils/net"
"github.com/hlandau/xlog"
"gopkg.in/hlandau/acmeapi.v2"
"sync"
"time"
)
var log, Log = xlog.New("acmetool.solver")
type blacklist struct {
mutex sync.Mutex
m map[string]struct{}
}
func blacklistKey(hostname, challengeType string) string {
return challengeType + "\n" + hostname
}
func (b *blacklist) Check(hostname, challengeType string) bool {
b.mutex.Lock()
defer b.mutex.Unlock()
_, ok := b.m[blacklistKey(hostname, challengeType)]
return ok
}
func (b *blacklist) Add(hostname, challengeType string) {
b.mutex.Lock()
defer b.mutex.Unlock()
b.m[blacklistKey(hostname, challengeType)] = struct{}{}
}
// Creates, fulfils and finalises an order. Automatically tries different
// challenges to the extent possible, and creates orders again if necessary
// after challenge failure, until success or unrecoverable failure.
func Order(ctx context.Context, rc *acmeapi.RealmClient, acct *acmeapi.Account, orderTemplate *acmeapi.Order, csr []byte, ccfg *responder.ChallengeConfig) (*acmeapi.Order, error) {
// Make order.
// Progress the order. => result: Success | Retry | Fail
// Fulfil authorizations.
// Fulfil challenges by preference/previously failed info; keep prev. failed for (hostname, challenge type)
// Retry stuff
// Start again if authorization becomes permanently failed
// Have faith
// Finalise
bl := blacklist{m: map[string]struct{}{}}
for {
order := *orderTemplate
err := rc.NewOrder(ctx, acct, &order)
if err != nil {
return nil, err
}
shouldRetry, err := orderProcess(ctx, rc, acct, &order, csr, ccfg, &bl)
if err == nil {
return &order, nil
}
if !shouldRetry {
return nil, err
}
}
}
// Take a newly created order object as far as possible.
//
// Returns in one of three states:
// - Success: err == nil -- OK
// We're done.
// - Fail: shouldRetry == true, err != nil -- Order failed but keep making new orders
// Causes a new order to be made to start the process again.
// - Fatal: shouldRetry == false, err != nil -- Order failed and we will never succeed, so stop
// Stops the order process.
func orderProcess(ctx context.Context, rc *acmeapi.RealmClient, acct *acmeapi.Account, order *acmeapi.Order, csr []byte, ccfg *responder.ChallengeConfig, bl *blacklist) (shouldRetry bool, err error) {
// We just created the order, so it shouldn't be invalid. If it is, there's
// no way we can get anywhere no matter how many times we try..
switch order.Status {
case acmeapi.OrderPending:
case acmeapi.OrderReady:
break
default:
return false, fmt.Errorf("order (%q) was in state %q as soon as it was created, cannot continue", order.URL, order.Status)
}
if order.Status == acmeapi.OrderPending {
shouldRetry, err := orderAuthorizeAll(ctx, rc, acct, order, ccfg, bl)
if err != nil {
return shouldRetry, err
}
// Get a fresh picture of the order status. orderAuthorizeAll doesn't refresh it.
err = rc.LoadOrder(ctx, acct, order)
if err != nil {
return true, err
}
}
// TODO: REMOVE LET'S ENCRYPT WORKAROUND once they fix this
allowBoulderBugfix := true
if order.Status != acmeapi.OrderReady && (!allowBoulderBugfix || order.Status != acmeapi.OrderPending) {
return false, fmt.Errorf("finished authorizing order (%q) but status is not ready, got %q", order.URL, order.Status)
}
// Request issuance.
err = rc.Finalize(ctx, acct, order, csr)
if err != nil {
// If finalization failed, this suggests something wrong with the CSR and retrying will be
// pointless, so stop here.
return false, err
}
return false, nil
}
// Tries to complete all the authorizations on an order.
//
// Returns in one of three states:
// - Success: err == nil -- OK
// We're done
// - Fail: shouldRetry == true, err != nil -- One or more authorizations are dead, but subsequent orders might succeed
// Cause a new order to be made to start the process again.
// - Fatal: shouldRetry == false, err != nil -- One or more authorizations are unfulfillable and subsequent orders will never succeed
// Stops the order process.
func orderAuthorizeAll(ctx context.Context, rc *acmeapi.RealmClient, acct *acmeapi.Account, order *acmeapi.Order, ccfg *responder.ChallengeConfig, bl *blacklist) (shouldRetry bool, err error) {
type result struct {
isFatal bool
err error
}
ch := make(chan result, len(order.AuthorizationURLs))
for i := range order.AuthorizationURLs {
authURL := order.AuthorizationURLs[i]
go func() {
ctxAuth := ctx // TODO
isFatal, err := orderAuthorizeOne(ctxAuth, rc, acct, authURL, ccfg, bl)
ch <- result{isFatal, err}
}()
}
var errors util.MultiError
isFatal := false
for i := 0; i < len(order.AuthorizationURLs); i++ {
r := <-ch
if r.isFatal {
// CANCEL ALL
isFatal = true
}
if r.err != nil {
errors = append(errors, r.err)
}
}
if len(errors) > 0 {
return !isFatal, errors
}
return true, nil
}
// Tries to complete one authorization given the URL to it. Tries challenges in
// sequence until the authorization becomes invalid or it is determined that
// none of the challenges will work. Avoids challenges which are already
// blacklisted and blacklists challenges which fail for the given (hostname,
// challengeType).
//
// Returns in one of three states:
// - Success: err == nil -- OK
// We're done, authorization is now good
// - Fail: isFatal == false, err != nil -- Authorization is unfulfillable but subsequent orders might succeed
// Cause a new order to be made to start the process again. Challenge
// blacklisting means a different strategy to complete the authorization
// will be attempted next time.
// - Fatal: isFatal == true, err != nil -- Authorization is unfulfillable and subsequent orders will never succeed
// Authorization process failed and it has been determined that no
// corresponding successor authorization in a subsequent order could ever
// succeed either. Give up.
func orderAuthorizeOne(ctx context.Context, rc *acmeapi.RealmClient, acct *acmeapi.Account, authURL string, ccfg *responder.ChallengeConfig, bl *blacklist) (isFatal bool, err error) {
authz := &acmeapi.Authorization{
URL: authURL,
}
// Load authorization.
err = rc.LoadAuthorization(ctx, acct, authz)
if err != nil {
// Assume a transient problem, return FAIL. If there is e.g. a network
// issue, creation of a new order will fail and that will be fatal, so not
// checking for fatal errors here is of little consequence.
return
}
// If an authorization was invalid at the outset, consider this a fatal
// error, otherwise we will just retry with new orders forever but never be
// able to make any progress. We can only get here if the order is not
// invalid, so this should only happen if the server creates new orders with
// a non-final order status but an invalid authorization, which shouldn't
// happen. Guard against it just in case.
if authz.Status == acmeapi.AuthorizationInvalid {
// Return FATAL.
isFatal = true
err = fmt.Errorf("authorization %q is invalid from the outset, even though order isn't", authz.URL)
return
}
var challengeErrors util.MultiError
outOfChallenges := false
for {
// If authorization has come to have a final state, return.
//
// This will occur either because
// - this function has now successfully completed the authorization, or
// - because the authorization was created in a final state (e.g. valid)
// as soon as the order was created; this can happen if the server
// carries over previous successful authorizations, etc.
// This also handles cases where an authorization randomly transitions to
// valid, though these aren't expected.
if authz.Status.IsFinal() {
if authz.Status == acmeapi.AuthorizationValid {
// Return SUCCESS.
return
}
// Authorization is dead and cannot be recovered. Return FAIL,
// creating a new order and starting the process again.
isFatal = outOfChallenges
err = util.NewWrapError(challengeErrors, "authorization %q has non-valid final status %q", authz.URL, authz.Status)
return
}
// If any challenge is valid, WTF? Return FATAL.
for i := range authz.Challenges {
if authz.Challenges[i].Status == acmeapi.ChallengeValid {
err = fmt.Errorf("authorization %q has non-final status but contains a valid challenge: %q", authz.URL, authz.Status)
isFatal = true
return
}
}
// If the authorization is not for a DNS identifier, return FATAL.
if authz.Identifier.Type != acmeapi.IdentifierTypeDNS {
err = fmt.Errorf("unsupported authorization identifier type %q, value %q", authz.Identifier.Type, authz.Identifier.Value)
isFatal = true
return
}
// Sort challenges by preference.
preferenceOrder := SortChallenges(authz, PreferFast)
// Initiate most preferred non-invalid challenge.
preferred := ""
secondBestPreferred := ""
for _, i := range preferenceOrder {
ch := &authz.Challenges[i]
if !bl.Check(authz.Identifier.Value, ch.Type) && !ch.Status.IsFinal() {
if preferred == "" {
preferred = ch.URL
} else if secondBestPreferred == "" {
secondBestPreferred = ch.URL
} else {
break
}
}
}
// If we've blacklisted all challenges, return FATAL.
if preferred == "" {
err = util.NewWrapError(challengeErrors, "exhausted all possible challenges in authorization %q", authz.URL)
isFatal = true
return
}
// Try and complete our preferred challenge. If it fails, blacklist it.
// orderCompleteChallenge returns once the challenge has succeeded, or once
// it has been determined that it definitely cannot be completed, or once a
// reasonable effort has been made (e.g. retry limit reached) without
// success. In failure cases (err != nil), the authorization may or may not
// have entered a final-invalid state as a result of this, so don't assume
// the authorization has become final-invalid.
ch, ok := findChallengeByURL(authz, preferred)
if !ok {
panic("challenge disappeared")
}
var authWasLoaded bool
authWasLoaded, err = orderCompleteChallenge(ctx, rc, acct, authz, ch.URL, ccfg)
if err != nil {
// This (hostname, challengeType) failed, so blacklist it so we don't try
// it again for the duration of this ordering process.
bl.Add(authz.Identifier.Value, ch.Type)
// As an optimisation, return FATAL instead of FAIL if the challenge we
// just blacklisted was the final non-blacklisted challenge. This is an
// optimization; if we don't do this, we'll create another order and call
// this function, orderAuthorizeOne, again before bailing at "exhausted
// all possible challenges" above. We can avoid this unnecessary creation
// of an unused order by checking if this is the last non-blacklisted
// challenge we're blacklisting.
outOfChallenges = (secondBestPreferred == "")
// Record the error.
challengeErrors = append(challengeErrors, err)
}
// Whether or not orderCompleteChallenge thinks the challenge apparently
// failed or not, just reload the authorization to check its current state
// and take that as the actual source of truth (unless
// orderCompleteChallenge just loaded it). This should be the most reliable
// strategy. We check whether the authorization has gone final when we
// continue the loop.
if !authWasLoaded {
err = rc.LoadAuthorization(ctx, acct, authz)
if err != nil {
return
}
}
}
}
// Tries to complete a single challenge. Returns after it has been completed,
// after it has been determined that it can no longer be completed, or after a
// reasonable effort has been made to complete it.
//
// (If the server implements some manner of evergreen challenge which never
// goes invalid, we don't want to retry forever as the means of completing the
// challenge may not be setup, so we only try once. Retries after spurious
// errors can be handled by the higher levels which invoke this, e.g. at the
// next invocation of acmetool — we probably can't reliably ascertain whether
// an error is spurious ourselves, so we just try once and assume that retries
// will be handled by our invoker.)
//
// Returns in one of two states:
// - Success: err == nil -- OK
// Challenge was successfully completed; authorization should now be
// final-valid.
// - Fail: err != nil -- Challenge was attempted one time and failed, authorization MAY OR MAY NOT be final-invalid
// Challenge was not successfully completed. This may or may not have
// caused the authorization to transition to final-invalid; for example,
// some challenges may fail before making any request to the ACME server
// at all, for example if they detect that they have not been configured
// (e.g. DNS challenges without any DNS hooks installed). By not assuming
// the authorization has become invalid we can avoid creating unnecessary
// orders.
//
// As an optimization, we return whether we reloaded the authorization after
// any possible status changes, which means the caller doesn't need to reload
// it again.
func orderCompleteChallenge(ctx context.Context, rc *acmeapi.RealmClient, acct *acmeapi.Account, authz *acmeapi.Authorization, challengeURL string, ccfg *responder.ChallengeConfig) (authWasLoaded bool, err error) {
oldCh, ok := findChallengeByURL(authz, challengeURL)
if !ok {
err = fmt.Errorf("challenge %q does not appear in authorization %q", challengeURL, authz.URL)
return
}
// A challenge might remain pending after we fail to complete it if the
// server is still willing to retry it. Since we want to limit how long we
// wait for a challenge to complete, we count the number of errors listed for
// the challenge by the server. When the number of errors increase (or the
// challenge goes valid), we consider that to be one attempt and stop.
oldCount := countErrors(&oldCh)
// Get responder ready.
r, err := responder.New(responder.Config{
Type: oldCh.Type,
Token: oldCh.Token,
AccountKey: acct.PrivateKey,
Hostname: authz.Identifier.Value,
ChallengeConfig: *ccfg,
})
if err != nil {
log.Debuge(err, "challenge instantiation failed")
return
}
err = r.Start()
if err != nil {
log.Debuge(err, "challenge start failed")
return
}
defer r.Stop()
// RESPOND
err = rc.RespondToChallenge(ctx, acct, &oldCh, r.Validation()) //r.ValidationSigningKey()
if err != nil {
return
}
b := denet.Backoff{
InitialDelay: 5 * time.Second,
MaxDelay: 30 * time.Second,
}
for {
// Wait until we have some suspicion that the challenge may have been
// completed.
log.Debugf("challenge %q (%q): waiting to poll", oldCh.URL, oldCh.Type)
select {
case <-ctx.Done():
err = ctx.Err()
return
case <-r.RequestDetectedChan():
log.Debugf("challenge %q (%q): request detected", oldCh.URL, oldCh.Type)
case <-time.After(b.NextDelay()):
log.Debugf("challenge %q (%q): periodically checking", oldCh.URL, oldCh.Type)
}
// We could reload just the challenge, but there's not much point, since
// the challenges are embedded inline in the authorization, and this keeps
// the authorization object up-to-date too.
log.Debugf("challenge %q (%q): querying status", oldCh.URL, oldCh.Type)
err = rc.WaitLoadAuthorization(ctx, acct, authz)
if err != nil {
return
}
authWasLoaded = true
updatedCh, ok := findChallengeByURL(authz, challengeURL)
if !ok {
err = fmt.Errorf("challenge %q has disappeared from authorization %q", challengeURL, authz.URL)
return
}
if updatedCh.Status == acmeapi.ChallengeValid {
// Challenge is valid, we're done here.
err = nil
return
}
if updatedCh.Status.IsFinal() {
// The challenge is final but not valid; there is no further prospect of
// completing this challenge.
err = util.NewWrapError(updatedCh.Error, "authorization %q challenge %q failed into final non-valid status %v", authz.URL, challengeURL, updatedCh.Status)
log.Infoe(err, "unsuccessful challenge")
return
}
// TODO: allow number of error-tries to be tolerated before bailing to be
// configured; currently fix it at 1.
if countErrors(&updatedCh) != oldCount {
err = util.NewWrapError(updatedCh.Error, "authorization %q challenge %q failed", authz.URL, challengeURL)
log.Infoe(err, "unsuccessful challenge")
return
}
}
}
func findChallengeByURL(authz *acmeapi.Authorization, challengeURL string) (acmeapi.Challenge, bool) {
for i := range authz.Challenges {
if authz.Challenges[i].URL == challengeURL {
return authz.Challenges[i], true
}
}
return acmeapi.Challenge{}, false
}
func countErrors(ch *acmeapi.Challenge) int {
if ch == nil || ch.Error == nil {
return 0
}
n := len(ch.Error.Subproblem)
if n == 0 {
return 1
}
return n
}
|