1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962
|
# encoding: utf-8
# Copyright (C) 2017 Lucas Hoffmann
# Copyright © 2017 Dylan Baker
# This file is released under the GNU GPL, version 3 or a later revision.
# For further details see the COPYING file
import base64
import codecs
import email
import email.header
import email.mime.application
import email.mime.multipart
import email.policy
import email.utils
from email.message import EmailMessage
import os
import os.path
from pathlib import Path
import shutil
import tempfile
import unittest
from unittest import mock
import gpg
from alot import crypto
from alot.db import utils
from alot.errors import GPGProblem
from alot.account import Account
from ..utilities import make_key, make_uid, TestCaseClassCleanup
def set_basic_headers(mail):
mail['Subject'] = 'Test email'
mail['To'] = 'foo@example.com'
mail['From'] = 'bar@example.com'
def message_from_binary_file(filename):
with (Path("tests/static/mail") / filename).open("rb") as file:
return email.message_from_binary_file(
file, _class=email.message.EmailMessage)
class TestGetParams(unittest.TestCase):
mailstring = '\n'.join([
'From: me',
'To: you',
'Subject: header field capitalisation',
'Content-type: text/plain; charset=utf-8',
'X-Header: param=one; and=two; or=three',
"X-Quoted: param=utf-8''%C3%9Cmlaut; second=plain%C3%9C",
'X-UPPERCASE: PARAM1=ONE; PARAM2=TWO'
'\n',
'content'
])
mail = email.message_from_string(mailstring)
def test_returns_content_type_parameters_by_default(self):
actual = utils.get_params(self.mail)
expected = {'text/plain': '', 'charset': 'utf-8'}
self.assertDictEqual(actual, expected)
def test_can_return_params_of_any_header_field(self):
actual = utils.get_params(self.mail, header='x-header')
expected = {'param': 'one', 'and': 'two', 'or': 'three'}
self.assertDictEqual(actual, expected)
@unittest.expectedFailure
def test_parameters_are_decoded(self):
actual = utils.get_params(self.mail, header='x-quoted')
expected = {'param': 'Ümlaut', 'second': 'plain%C3%9C'}
self.assertDictEqual(actual, expected)
def test_parameters_names_are_converted_to_lowercase(self):
actual = utils.get_params(self.mail, header='x-uppercase')
expected = {'param1': 'ONE', 'param2': 'TWO'}
self.assertDictEqual(actual, expected)
def test_returns_empty_dict_if_header_not_present(self):
actual = utils.get_params(self.mail, header='x-header-not-present')
self.assertDictEqual(actual, dict())
def test_returns_failobj_if_header_not_present(self):
failobj = [('my special failobj for the test', 'needs to be a pair!')]
actual = utils.get_params(self.mail, header='x-header-not-present',
failobj=failobj)
expected = dict(failobj)
self.assertEqual(actual, expected)
class TestIsSubdirOf(unittest.TestCase):
def test_both_paths_absolute_matching(self):
superpath = '/a/b'
subpath = '/a/b/c/d.rst'
result = utils.is_subdir_of(subpath, superpath)
self.assertTrue(result)
def test_both_paths_absolute_not_matching(self):
superpath = '/a/z'
subpath = '/a/b/c/d.rst'
result = utils.is_subdir_of(subpath, superpath)
self.assertFalse(result)
def test_both_paths_relative_matching(self):
superpath = 'a/b'
subpath = 'a/b/c/d.rst'
result = utils.is_subdir_of(subpath, superpath)
self.assertTrue(result)
def test_both_paths_relative_not_matching(self):
superpath = 'a/z'
subpath = 'a/b/c/d.rst'
result = utils.is_subdir_of(subpath, superpath)
self.assertFalse(result)
def test_relative_path_and_absolute_path_matching(self):
superpath = 'a/b'
subpath = os.path.join(os.getcwd(), 'a/b/c/d.rst')
result = utils.is_subdir_of(subpath, superpath)
self.assertTrue(result)
class TestExtractHeader(unittest.TestCase):
mailstring = '\n'.join([
'From: me',
'To: you',
'Subject: header field capitalisation',
'Content-type: text/plain; charset=utf-8',
'X-Header: param=one; and=two; or=three',
"X-Quoted: param=utf-8''%C3%9Cmlaut; second=plain%C3%9C",
'X-UPPERCASE: PARAM1=ONE; PARAM2=TWO'
'\n',
'content'
])
mail = email.message_from_string(mailstring)
def test_default_arguments_yield_all_headers(self):
actual = utils.extract_headers(self.mail)
# collect all lines until the first empty line, hence all header lines
expected = []
for line in self.mailstring.splitlines():
if not line:
break
expected.append(line)
expected = '\n'.join(expected) + '\n'
self.assertEqual(actual, expected)
def test_single_headers_can_be_retrieved(self):
actual = utils.extract_headers(self.mail, ['from'])
expected = 'from: me\n'
self.assertEqual(actual, expected)
def test_multible_headers_can_be_retrieved_in_predevined_order(self):
headers = ['x-header', 'to', 'x-uppercase']
actual = utils.extract_headers(self.mail, headers)
expected = 'x-header: param=one; and=two; or=three\nto: you\n' \
'x-uppercase: PARAM1=ONE; PARAM2=TWO\n'
self.assertEqual(actual, expected)
def test_headers_can_be_retrieved_multible_times(self):
headers = ['from', 'from']
actual = utils.extract_headers(self.mail, headers)
expected = 'from: me\nfrom: me\n'
self.assertEqual(actual, expected)
def test_case_is_prserved_in_header_keys_but_irelevant(self):
headers = ['FROM', 'from']
actual = utils.extract_headers(self.mail, headers)
expected = 'FROM: me\nfrom: me\n'
self.assertEqual(actual, expected)
@unittest.expectedFailure
def test_header_values_are_not_decoded(self):
actual = utils.extract_headers(self.mail, ['x-quoted'])
expected = "x-quoted: param=utf-8''%C3%9Cmlaut; second=plain%C3%9C\n",
self.assertEqual(actual, expected)
class TestDecodeHeader(unittest.TestCase):
@staticmethod
def _quote(unicode_string, encoding):
"""Turn a unicode string into a RFC2047 quoted ascii string
:param unicode_string: the string to encode
:type unicode_string: unicode
:param encoding: the encoding to use, 'utf-8', 'iso-8859-1', ...
:type encoding: str
:returns: the encoded string
:rtype: str
"""
string = unicode_string.encode(encoding)
output = b'=?' + encoding.encode('ascii') + b'?Q?'
for byte in string:
output += b'=' + codecs.encode(bytes([byte]), 'hex').upper()
return (output + b'?=').decode('ascii')
@staticmethod
def _base64(unicode_string, encoding):
"""Turn a unicode string into a RFC2047 base64 encoded ascii string
:param unicode_string: the string to encode
:type unicode_string: unicode
:param encoding: the encoding to use, 'utf-8', 'iso-8859-1', ...
:type encoding: str
:returns: the encoded string
:rtype: str
"""
string = unicode_string.encode(encoding)
b64 = base64.encodebytes(string).strip()
result_bytes = b'=?' + encoding.encode('utf-8') + b'?B?' + b64 + b'?='
result = result_bytes.decode('ascii')
return result
def _test(self, teststring, expected):
actual = utils.decode_header(teststring)
self.assertEqual(actual, expected)
def test_non_ascii_strings_are_returned_as_unicode_directly(self):
text = 'Nön ÄSCII string¡'
self._test(text, text)
def test_basic_utf_8_quoted(self):
expected = 'ÄÖÜäöü'
text = self._quote(expected, 'utf-8')
self._test(text, expected)
def test_basic_iso_8859_1_quoted(self):
expected = 'ÄÖÜäöü'
text = self._quote(expected, 'iso-8859-1')
self._test(text, expected)
def test_basic_windows_1252_quoted(self):
expected = 'ÄÖÜäöü'
text = self._quote(expected, 'windows-1252')
self._test(text, expected)
def test_basic_utf_8_base64(self):
expected = 'ÄÖÜäöü'
text = self._base64(expected, 'utf-8')
self._test(text, expected)
def test_basic_iso_8859_1_base64(self):
expected = 'ÄÖÜäöü'
text = self._base64(expected, 'iso-8859-1')
self._test(text, expected)
def test_basic_iso_1252_base64(self):
expected = 'ÄÖÜäöü'
text = self._base64(expected, 'windows-1252')
self._test(text, expected)
def test_quoted_words_can_be_interrupted(self):
part = 'ÄÖÜäöü'
text = self._base64(part, 'utf-8') + ' and ' + \
self._quote(part, 'utf-8')
expected = 'ÄÖÜäöü and ÄÖÜäöü'
self._test(text, expected)
def test_different_encodings_can_be_mixed(self):
part = 'ÄÖÜäöü'
text = 'utf-8: ' + self._base64(part, 'utf-8') + \
' again: ' + self._quote(part, 'utf-8') + \
' latin1: ' + self._base64(part, 'iso-8859-1') + \
' and ' + self._quote(part, 'iso-8859-1')
expected = (
'utf-8: ÄÖÜäöü '
'again: ÄÖÜäöü '
'latin1: ÄÖÜäöü and ÄÖÜäöü'
)
self._test(text, expected)
def test_tabs_are_expanded_to_align_with_eigth_spaces(self):
text = 'tab: \t'
expected = 'tab: '
self._test(text, expected)
def test_newlines_are_not_touched_by_default(self):
text = 'first\nsecond\n third\n fourth'
expected = 'first\nsecond\n third\n fourth'
self._test(text, expected)
def test_continuation_newlines_can_be_normalized(self):
text = 'first\nsecond\n third\n\tfourth\n \t fifth'
expected = 'first\nsecond third fourth fifth'
actual = utils.decode_header(text, normalize=True)
self.assertEqual(actual, expected)
def test_exchange_quotes_remain(self):
# issue #1347
expected = '"Mouse, Michaël" <x@y.z>'
text = self._quote(expected, 'utf-8')
self._test(text, expected)
class TestAddSignatureHeaders(unittest.TestCase):
class FakeMail(object):
def __init__(self):
self.headers = []
def add_header(self, header, value):
self.headers.append((header, value))
def check(self, key, valid, error_msg=''):
mail = self.FakeMail()
with mock.patch('alot.db.utils.crypto.get_key',
mock.Mock(return_value=key)), \
mock.patch('alot.db.utils.crypto.check_uid_validity',
mock.Mock(return_value=valid)):
utils.add_signature_headers(mail, [mock.Mock(fpr='')], error_msg)
return mail
def test_length_0(self):
mail = self.FakeMail()
utils.add_signature_headers(mail, [], '')
self.assertIn((utils.X_SIGNATURE_VALID_HEADER, 'False'), mail.headers)
self.assertIn(
(utils.X_SIGNATURE_MESSAGE_HEADER, 'Invalid: no signature found'),
mail.headers)
def test_valid(self):
key = make_key()
mail = self.check(key, True)
self.assertIn((utils.X_SIGNATURE_VALID_HEADER, 'True'), mail.headers)
self.assertIn(
(utils.X_SIGNATURE_MESSAGE_HEADER, 'Valid: mocked'), mail.headers)
def test_untrusted(self):
key = make_key()
mail = self.check(key, False)
self.assertIn((utils.X_SIGNATURE_VALID_HEADER, 'True'), mail.headers)
self.assertIn(
(utils.X_SIGNATURE_MESSAGE_HEADER, 'Untrusted: mocked'),
mail.headers)
def test_unicode_as_bytes(self):
mail = self.FakeMail()
key = make_key()
key.uids = [make_uid('andreá@example.com', uid='Andreá')]
mail = self.check(key, True)
self.assertIn((utils.X_SIGNATURE_VALID_HEADER, 'True'), mail.headers)
self.assertIn(
(utils.X_SIGNATURE_MESSAGE_HEADER, 'Valid: Andreá'),
mail.headers)
def test_error_message_unicode(self):
mail = self.check(mock.Mock(), mock.Mock(), 'error message')
self.assertIn((utils.X_SIGNATURE_VALID_HEADER, 'False'), mail.headers)
self.assertIn(
(utils.X_SIGNATURE_MESSAGE_HEADER, 'Invalid: error message'),
mail.headers)
def test_get_key_fails(self):
mail = self.FakeMail()
with mock.patch('alot.db.utils.crypto.get_key',
mock.Mock(side_effect=GPGProblem('', 0))):
utils.add_signature_headers(mail, [mock.Mock(fpr='')], '')
self.assertIn((utils.X_SIGNATURE_VALID_HEADER, 'False'), mail.headers)
self.assertIn(
(utils.X_SIGNATURE_MESSAGE_HEADER, 'Untrusted: '),
mail.headers)
class TestMessageFromFile(TestCaseClassCleanup):
@classmethod
def setUpClass(cls):
home = tempfile.mkdtemp()
cls.addClassCleanup(lambda : shutil.rmtree(home, ignore_errors=True))
mock_home = mock.patch.dict(os.environ, {'GNUPGHOME': home})
mock_home.start()
cls.addClassCleanup(mock_home.stop)
with gpg.core.Context() as ctx:
search_dir = os.path.join(os.path.dirname(__file__),
'../static/gpg-keys')
for each in os.listdir(search_dir):
if os.path.splitext(each)[1] == '.gpg':
with open(os.path.join(search_dir, each)) as f:
ctx.op_import(f)
cls.keys = [
ctx.get_key("DD19862809A7573A74058FF255937AFBB156245D")]
def test_erase_alot_header_signature_valid(self):
"""Alot uses special headers for passing certain kinds of information,
it's important that information isn't passed in from the original
message as a way to trick the user.
"""
m = email.message.Message()
m.add_header(utils.X_SIGNATURE_VALID_HEADER, 'Bad')
message = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIs(message.get(utils.X_SIGNATURE_VALID_HEADER), None)
def test_erase_alot_header_message(self):
m = email.message.Message()
m.add_header(utils.X_SIGNATURE_MESSAGE_HEADER, 'Bad')
message = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIs(message.get(utils.X_SIGNATURE_MESSAGE_HEADER), None)
def test_plain_mail(self):
m = email.mime.text.MIMEText('This is some text', 'plain', 'utf-8')
m['Subject'] = 'test'
m['From'] = 'me'
m['To'] = 'Nobody'
message = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertEqual(message.get_payload(), 'This is some text')
def _make_signed(self):
"""Create a signed message that is multipart/signed."""
text = b'This is some text'
t = email.mime.text.MIMEText(text, 'plain', 'utf-8')
_, sig = crypto.detached_signature_for(
t.as_bytes(policy=email.policy.SMTP), self.keys)
s = email.mime.application.MIMEApplication(
sig, 'pgp-signature', email.encoders.encode_7or8bit)
m = email.mime.multipart.MIMEMultipart('signed', None, [t, s])
m.set_param('protocol', 'application/pgp-signature')
m.set_param('micalg', 'pgp-sha256')
return m
def test_signed_headers_included(self):
"""Headers are added to the message."""
m = self._make_signed()
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn(utils.X_SIGNATURE_VALID_HEADER, m)
self.assertIn(utils.X_SIGNATURE_MESSAGE_HEADER, m)
def test_signed_valid(self):
"""Test that the signature is valid."""
m = self._make_signed()
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertEqual(m[utils.X_SIGNATURE_VALID_HEADER], 'True')
def test_signed_correct_from(self):
"""Test that the signature is valid."""
m = self._make_signed()
m = utils.decrypted_message_from_bytes(m.as_bytes())
# Don't test for valid/invalid since that might change
self.assertIn(
'ambig <ambig@example.com>', m[utils.X_SIGNATURE_MESSAGE_HEADER])
def test_signed_wrong_mimetype_second_payload(self):
m = self._make_signed()
m.get_payload(1).set_type('text/plain')
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn('expected Content-Type: ',
m[utils.X_SIGNATURE_MESSAGE_HEADER])
def test_signed_wrong_micalg(self):
m = self._make_signed()
m.set_param('micalg', 'foo')
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn('expected micalg=pgp-...',
m[utils.X_SIGNATURE_MESSAGE_HEADER])
def test_signed_micalg_cap(self):
"""The micalg parameter should be normalized to lower case.
From RFC 3156 § 5
The "micalg" parameter for the "application/pgp-signature" protocol
MUST contain exactly one hash-symbol of the format "pgp-<hash-
identifier>", where <hash-identifier> identifies the Message
Integrity Check (MIC) algorithm used to generate the signature.
Hash-symbols are constructed from the text names registered in [1]
or according to the mechanism defined in that document by
converting the text name to lower case and prefixing it with the
four characters "pgp-".
The spec is pretty clear that this is supposed to be lower cased.
"""
m = self._make_signed()
m.set_param('micalg', 'PGP-SHA1')
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn('expected micalg=pgp-',
m[utils.X_SIGNATURE_MESSAGE_HEADER])
def test_signed_more_than_two_messages(self):
"""Per the spec only 2 payloads may be encapsulated inside the
multipart/signed payload, while it might be nice to cover more than 2
payloads (Postel's law), it would introduce serious complexity
since we would also need to cover those payloads being misordered.
Since getting the right number of payloads and getting them in the
right order should be fairly easy to implement correctly enforcing that
there are only two payloads seems reasonable.
"""
m = self._make_signed()
m.attach(email.mime.text.MIMEText('foo'))
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn('expected exactly two messages, got 3',
m[utils.X_SIGNATURE_MESSAGE_HEADER])
# TODO: The case of more than two payloads, or the payloads being out of
# order. Also for the encrypted case.
def _make_encrypted(self, signed=False):
"""Create an encrypted (and optionally signed) message."""
if signed:
t = self._make_signed()
else:
text = b'This is some text'
t = email.mime.text.MIMEText(text, 'plain', 'utf-8')
enc = crypto.encrypt(t.as_bytes(policy=email.policy.SMTP), self.keys)
e = email.mime.application.MIMEApplication(
enc, 'octet-stream', email.encoders.encode_7or8bit)
f = email.mime.application.MIMEApplication(
b'Version: 1', 'pgp-encrypted', email.encoders.encode_7or8bit)
m = email.mime.multipart.MIMEMultipart('encrypted', None, [f, e])
m.set_param('protocol', 'application/pgp-encrypted')
return m
def test_encrypted_length(self):
# It seems string that we just attach the unsigned message to the end
# of the mail, rather than replacing the whole encrypted payload with
# it's unencrypted equivalent
m = self._make_encrypted()
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertEqual(len(m.get_payload()), 3)
def test_encrypted_unsigned_is_decrypted(self):
m = self._make_encrypted()
m = utils.decrypted_message_from_bytes(m.as_bytes())
# Check using m.walk, since we're not checking for ordering, just
# existence.
self.assertIn('This is some text', [n.get_payload() for n in m.walk()])
def test_encrypted_unsigned_doesnt_add_signed_headers(self):
"""Since the message isn't signed, it shouldn't have headers saying
that there is a signature.
"""
m = self._make_encrypted()
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertNotIn(utils.X_SIGNATURE_VALID_HEADER, m)
self.assertNotIn(utils.X_SIGNATURE_MESSAGE_HEADER, m)
def test_encrypted_signed_is_decrypted(self):
m = self._make_encrypted(True)
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn('This is some text', [n.get_payload() for n in m.walk()])
def test_encrypted_signed_headers(self):
"""Since the message is signed, it should have headers saying that
there is a signature.
"""
m = self._make_encrypted(True)
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn(utils.X_SIGNATURE_MESSAGE_HEADER, m)
self.assertIn(
'ambig <ambig@example.com>', m[utils.X_SIGNATURE_MESSAGE_HEADER])
# TODO: tests for the RFC 2440 style combined signed/encrypted blob
def test_encrypted_wrong_mimetype_first_payload(self):
m = self._make_encrypted()
m.get_payload(0).set_type('text/plain')
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn('Malformed OpenPGP message:',
m.get_payload(2).get_payload())
def test_encrypted_wrong_mimetype_second_payload(self):
m = self._make_encrypted()
m.get_payload(1).set_type('text/plain')
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn('Malformed OpenPGP message:',
m.get_payload(2).get_payload())
def test_signed_in_multipart_mixed(self):
"""It is valid to encapsulate a multipart/signed payload inside a
multipart/mixed payload, verify that works.
"""
s = self._make_signed()
m = email.mime.multipart.MIMEMultipart('mixed', None, [s])
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertEqual(m[utils.X_SIGNATURE_VALID_HEADER], 'True')
self.assertIn(utils.X_SIGNATURE_MESSAGE_HEADER, m)
def test_signed_in_multipart_mixed_other_mua(self):
"""It is valid to encapsulate a multipart/signed payload inside a
multipart/mixed payload, verify that works.
The signature being sensitive to the way the multipart message
was assembled (with blank lines between parts, ...),
we need to make sure that we're able to validate messages generated
by other MUAs as well.
"""
mb = Path('tests/static/mail/protonmail-signed.eml').read_bytes()
m = utils.decrypted_message_from_bytes(mb)
self.assertEqual(m[utils.X_SIGNATURE_VALID_HEADER], 'True')
self.assertIn(utils.X_SIGNATURE_MESSAGE_HEADER, m)
def test_encrypted_unsigned_in_multipart_mixed(self):
"""It is valid to encapsulate a multipart/encrypted payload inside a
multipart/mixed payload, verify that works.
"""
s = self._make_encrypted()
m = email.mime.multipart.MIMEMultipart('mixed', None, [s])
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn('This is some text', [n.get_payload() for n in m.walk()])
self.assertNotIn(utils.X_SIGNATURE_VALID_HEADER, m)
self.assertNotIn(utils.X_SIGNATURE_MESSAGE_HEADER, m)
def test_encrypted_signed_in_multipart_mixed(self):
"""It is valid to encapsulate a multipart/encrypted payload inside a
multipart/mixed payload, verify that works when the multipart/encrypted
contains a multipart/signed.
"""
s = self._make_encrypted(True)
m = email.mime.multipart.MIMEMultipart('mixed', None, [s])
m = utils.decrypted_message_from_bytes(m.as_bytes())
self.assertIn('This is some text', [n.get_payload() for n in m.walk()])
self.assertIn(utils.X_SIGNATURE_VALID_HEADER, m)
self.assertIn(utils.X_SIGNATURE_MESSAGE_HEADER, m)
class TestGetBodyPart(unittest.TestCase):
def _make_mixed_plain_html(self):
mail = EmailMessage()
set_basic_headers(mail)
mail.set_content('This is an email')
mail.add_alternative(
'<!DOCTYPE html><html><body>This is an html email</body></html>',
subtype='html')
return mail
@mock.patch('alot.db.utils.settings.get', mock.Mock(return_value=True))
def test_prefer_plaintext_mixed(self):
expected = "text/plain"
mail = self._make_mixed_plain_html()
actual = utils.get_body_part(mail).get_content_type()
self.assertEqual(actual, expected)
# Mock the handler to cat, so that no transformations of the html are made
# making the result non-deterministic
@mock.patch('alot.db.utils.settings.get', mock.Mock(return_value=False))
@mock.patch('alot.db.utils.settings.mailcap_find_match',
mock.Mock(return_value=(None, {'view': 'cat'})))
def test_prefer_html_mixed(self):
expected = 'text/html'
mail = self._make_mixed_plain_html()
actual = utils.get_body_part(mail).get_content_type()
self.assertEqual(actual, expected)
def _make_html_only(self):
mail = EmailMessage()
set_basic_headers(mail)
mail.set_content(
'<!DOCTYPE html><html><body>This is an html email</body></html>',
subtype='html')
return mail
@mock.patch('alot.db.utils.settings.get', mock.Mock(return_value=True))
@mock.patch('alot.db.utils.settings.mailcap_find_match',
mock.Mock(return_value=(None, {'view': 'cat'})))
def test_prefer_plaintext_only(self):
expected = 'text/html'
mail = self._make_html_only()
actual = utils.get_body_part(mail).get_content_type()
self.assertEqual(actual, expected)
# Mock the handler to cat, so that no transformations of the html are made
# making the result non-deterministic
@mock.patch('alot.db.utils.settings.get', mock.Mock(return_value=False))
@mock.patch('alot.db.utils.settings.mailcap_find_match',
mock.Mock(return_value=(None, {'view': 'cat'})))
def test_prefer_html_only(self):
expected = 'text/html'
mail = self._make_html_only()
actual = utils.get_body_part(mail).get_content_type()
self.assertEqual(actual, expected)
@mock.patch('alot.db.utils.settings.get', mock.Mock(return_value=False))
def test_prefer_html_set_mimetype_plain(self):
expected = "text/plain"
mail = self._make_mixed_plain_html()
actual = utils.get_body_part(mail, 'plain').get_content_type()
self.assertEqual(actual, expected)
@mock.patch('alot.db.utils.settings.get', mock.Mock(return_value=True))
def test_prefer_plaintext_set_mimetype_html(self):
expected = 'text/html'
mail = self._make_mixed_plain_html()
actual = utils.get_body_part(mail, 'html').get_content_type()
self.assertEqual(actual, expected)
class TestExtractBodyPart(unittest.TestCase):
def test_single_text_plain(self):
mail = EmailMessage()
set_basic_headers(mail)
mail.set_content('This is an email')
body_part = utils.get_body_part(mail)
actual = utils.extract_body_part(body_part)
expected = 'This is an email\n'
self.assertEqual(actual, expected)
@unittest.expectedFailure
# This makes no sense
def test_two_text_plain(self):
mail = email.mime.multipart.MIMEMultipart()
set_basic_headers(mail)
mail.attach(email.mime.text.MIMEText('This is an email'))
mail.attach(email.mime.text.MIMEText('This is a second part'))
body_part = utils.get_body_part(mail)
actual = utils.extract_body_part(body_part)
expected = 'This is an email\n\nThis is a second part'
self.assertEqual(actual, expected)
def test_simple_japanese_file(self):
mail = message_from_binary_file('japanese.eml')
actual = utils.extract_body_part(mail)
expected = "MA-EYESご利用者各位\n\nBIRD-BOの河和です。お疲れ様です。\n"
self.assertEqual(actual, expected)
def test_simple_iso_8859_1_mail(self):
mail = message_from_binary_file("iso-8859-1-qp.eml")
actual = utils.extract_body_part(mail)
expected = "müßig\nfleißig\n"
self.assertEqual(actual, expected)
def test_text_plain_with_attachment_text(self):
mail = EmailMessage()
set_basic_headers(mail)
mail.set_content('This is an email')
mail.add_attachment('this shouldnt be displayed')
body_part = utils.get_body_part(mail)
actual = utils.extract_body_part(body_part)
expected = 'This is an email\n'
self.assertEqual(actual, expected)
@mock.patch('alot.db.utils.settings.mailcap_find_match',
mock.Mock(return_value=(None, None)))
def test_simple_utf8_file(self):
mail = message_from_binary_file('utf8.eml')
body_part = utils.get_body_part(mail)
actual = utils.extract_body_part(body_part)
expected = "Liebe Grüße!\n"
self.assertEqual(actual, expected)
@mock.patch('alot.db.utils.settings.mailcap_find_match',
mock.Mock(return_value=(None, None)))
def test_simple_iso_8859_1_file(self):
mail = message_from_binary_file('iso-8859-1.eml')
body_part = utils.get_body_part(mail)
actual = utils.extract_body_part(body_part)
expected = "Liebe Grüße!\n"
self.assertEqual(actual, expected)
@mock.patch('alot.db.utils.settings.mailcap_find_match',
mock.Mock(return_value=(
None, {'view': 'sed "s/!/?/"'})))
def test_utf8_plaintext_mailcap(self):
"""
Handle unicode correctly in the presence of a text/plain mailcap entry.
https://github.com/pazz/alot/issues/1522
"""
mail = message_from_binary_file('utf8.eml')
body_part = utils.get_body_part(mail)
actual = utils.extract_body_part(body_part)
expected = "Liebe Grüße?\n"
self.assertEqual(actual, expected)
@mock.patch('alot.db.utils.settings.get', mock.Mock(return_value=True))
@mock.patch('alot.db.utils.settings.mailcap_find_match',
mock.Mock(return_value=(
None, {'view': 'sed "s/ is/ was/"'})))
def test_plaintext_mailcap(self):
expected = 'This was an email\n'
mail = EmailMessage()
set_basic_headers(mail)
mail.set_content('This is an email')
body_part = utils.get_body_part(mail)
actual = utils.extract_body_part(body_part)
self.assertEqual(actual, expected)
@mock.patch('alot.db.utils.settings.mailcap_find_match',
mock.Mock(return_value=(None, {'view': 'cat'})))
def test_plaintext_mailcap_wo_content_type(self):
with open('tests/static/mail/basic.eml') as fp:
mail = email.message_from_file(fp,
_class=email.message.EmailMessage)
body_part = utils.get_body_part(mail)
actual = utils.extract_body_part(body_part)
expected = 'test body\n'
self.assertEqual(actual, expected)
def test_partial_quoted_printable_encoding(self):
# this file contains a byte that should be quoted printable escaped but
# is not
with open("tests/static/mail/partial-quoted-printable.eml") as fp:
mail = email.message_from_file(fp,
_class=email.message.EmailMessage)
body_part = utils.get_body_part(mail)
actual = utils.extract_body_part(body_part)
expected = "Some zwnj chars: \\u200c \u200c ‌\n"
self.assertEqual(actual, expected)
class TestRemoveCte(unittest.TestCase):
def test_char_vs_cte_mismatch(self): # #1291
with open('tests/static/mail/broken-utf8.eml') as fp:
mail = email.message_from_file(fp)
# This should not raise an UnicodeDecodeError.
with self.assertLogs(level='DEBUG') as cm: # keep logs
utils.remove_cte(mail, as_string=True)
# We expect no Exceptions but a complaint in the log
logmsg = 'DEBUG:root:Decoding failure: \'utf-8\' codec can\'t decode '\
'byte 0xa1 in position 14: invalid start byte'
self.assertIn(logmsg, cm.output)
def test_malformed_cte_value(self):
with open('tests/static/mail/malformed-header-CTE.eml') as fp:
mail = email.message_from_file(fp)
with self.assertLogs(level='INFO') as cm: # keep logs
utils.remove_cte(mail, as_string=True)
# We expect no Exceptions but a complaint in the log
logmsg = 'INFO:root:Unknown Content-Transfer-Encoding: "7bit;"'
self.assertEqual(cm.output, [logmsg])
def test_unknown_cte_value(self):
with open('tests/static/mail/malformed-header-CTE-2.eml') as fp:
mail = email.message_from_file(fp)
with self.assertLogs(level='DEBUG') as cm: # keep logs
utils.remove_cte(mail, as_string=True)
# We expect no Exceptions but a complaint in the log
logmsg = 'INFO:root:Unknown Content-Transfer-Encoding: "normal"'
self.assertIn(logmsg, cm.output)
class Test_ensure_unique_address(unittest.TestCase):
foo = 'foo <foo@example.com>'
foo2 = 'foo the fanzy <foo@example.com>'
bar = 'bar <bar@example.com>'
baz = 'baz <baz@example.com>'
def test_unique_lists_are_unchanged(self):
expected = sorted([self.foo, self.bar])
actual = utils.ensure_unique_address(expected)
self.assertListEqual(actual, expected)
def test_equal_entries_are_detected(self):
actual = utils.ensure_unique_address(
[self.foo, self.bar, self.foo])
expected = sorted([self.foo, self.bar])
self.assertListEqual(actual, expected)
def test_same_address_with_different_name_is_detected(self):
actual = utils.ensure_unique_address(
[self.foo, self.foo2])
expected = [self.foo2]
self.assertListEqual(actual, expected)
class _AccountTestClass(Account):
"""Implements stubs for ABC methods."""
def send_mail(self, mail):
pass
class TestClearMyAddress(unittest.TestCase):
me1 = 'me@example.com'
me2 = 'ME@example.com'
me3 = 'me+label@example.com'
me4 = 'ME+label@example.com'
me_regex = r'me\+.*@example.com'
me_named = 'alot team <me@example.com>'
you = 'you@example.com'
named = 'somebody you know <somebody@example.com>'
imposter = 'alot team <imposter@example.com>'
mine = _AccountTestClass(
address=me1, aliases=[], alias_regexp=me_regex, case_sensitive_username=True)
def test_empty_input_returns_empty_list(self):
self.assertListEqual(
utils.clear_my_address(self.mine, []), [])
def test_only_my_emails_result_in_empty_list(self):
expected = []
actual = utils.clear_my_address(
self.mine, [self.me1, self.me3, self.me_named])
self.assertListEqual(actual, expected)
def test_other_emails_are_untouched(self):
input_ = [self.you, self.me1, self.me_named, self.named]
expected = [self.you, self.named]
actual = utils.clear_my_address(self.mine, input_)
self.assertListEqual(actual, expected)
def test_case_matters(self):
input_ = [self.me1, self.me2, self.me3, self.me4]
expected = [self.me2, self.me4]
actual = utils.clear_my_address(self.mine, input_)
self.assertListEqual(actual, expected)
def test_same_address_with_different_real_name_is_removed(self):
input_ = [self.me_named, self.you]
expected = [self.you]
actual = utils.clear_my_address(self.mine, input_)
self.assertListEqual(actual, expected)
class TestFormataddr(unittest.TestCase):
address = 'me@example.com'
test_data = [
(address, ("", address)),
("Me <me@example.com>", ("Me", address)),
("\"Last, Name\" <me@example.com>", ("Last, Name", address)),
('"me@example.com" <me@example.com>', (address, address)),
('"Ö, Ä" <a@b.c>', ("Ö, Ä", "a@b.c")),
("'single quote' <me@example.com>", ("'single quote'", address)),
('"open list:RISC-V ARCHITECTURE:Keyword:riscv" <linux-riscv@lists.infradead.org>',
("open list:RISC-V ARCHITECTURE:Keyword:riscv", "linux-riscv@lists.infradead.org"))
]
def test_simple_cases(self):
for formatted, args in self.test_data:
with self.subTest(formatted=formatted):
self.assertEqual(utils.formataddr(args), formatted)
self.assertEqual(utils.formataddr(email.utils.parseaddr(formatted)), formatted)
self.assertEqual(email.utils.parseaddr(utils.formataddr(args)), args)
|