1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
|
/*
* Copyright (C) 2014 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "base/arena_allocator.h"
#include "base/macros.h"
#include "builder.h"
#include "dex/dex_file.h"
#include "dex/dex_instruction.h"
#include "nodes.h"
#include "optimizing_unit_test.h"
#include "pretty_printer.h"
#include "ssa_liveness_analysis.h"
#include "gtest/gtest.h"
namespace art HIDDEN {
class FindLoopsTest : public CommonCompilerTest, public OptimizingUnitTestHelper {};
TEST_F(FindLoopsTest, CFG1) {
// Constant is not used.
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::RETURN_VOID);
HGraph* graph = CreateCFG(data);
for (HBasicBlock* block : graph->GetBlocks()) {
ASSERT_EQ(block->GetLoopInformation(), nullptr);
}
}
TEST_F(FindLoopsTest, CFG2) {
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::RETURN);
HGraph* graph = CreateCFG(data);
for (HBasicBlock* block : graph->GetBlocks()) {
ASSERT_EQ(block->GetLoopInformation(), nullptr);
}
}
TEST_F(FindLoopsTest, CFG3) {
const std::vector<uint16_t> data = TWO_REGISTERS_CODE_ITEM(
Instruction::CONST_4 | 3 << 12 | 0,
Instruction::CONST_4 | 4 << 12 | 1 << 8,
Instruction::ADD_INT_2ADDR | 1 << 12,
Instruction::GOTO | 0x100,
Instruction::RETURN);
HGraph* graph = CreateCFG(data);
for (HBasicBlock* block : graph->GetBlocks()) {
ASSERT_EQ(block->GetLoopInformation(), nullptr);
}
}
TEST_F(FindLoopsTest, CFG4) {
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::IF_EQ, 4,
Instruction::CONST_4 | 4 << 12 | 0,
Instruction::GOTO | 0x200,
Instruction::CONST_4 | 5 << 12 | 0,
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
for (HBasicBlock* block : graph->GetBlocks()) {
ASSERT_EQ(block->GetLoopInformation(), nullptr);
}
}
TEST_F(FindLoopsTest, CFG5) {
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::IF_EQ, 3,
Instruction::CONST_4 | 4 << 12 | 0,
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
for (HBasicBlock* block : graph->GetBlocks()) {
ASSERT_EQ(block->GetLoopInformation(), nullptr);
}
}
static void TestBlock(HGraph* graph,
uint32_t block_id,
bool is_loop_header,
uint32_t parent_loop_header_id,
const int* blocks_in_loop = nullptr,
size_t number_of_blocks = 0) {
HBasicBlock* block = graph->GetBlocks()[block_id];
ASSERT_EQ(block->IsLoopHeader(), is_loop_header);
if (parent_loop_header_id == kInvalidBlockId) {
ASSERT_EQ(block->GetLoopInformation(), nullptr);
} else {
ASSERT_EQ(block->GetLoopInformation()->GetHeader()->GetBlockId(), parent_loop_header_id);
}
if (blocks_in_loop != nullptr) {
HLoopInformation* info = block->GetLoopInformation();
const BitVector& blocks = info->GetBlocks();
ASSERT_EQ(blocks.NumSetBits(), number_of_blocks);
for (size_t i = 0; i < number_of_blocks; ++i) {
ASSERT_TRUE(blocks.IsBitSet(blocks_in_loop[i]));
}
} else {
ASSERT_FALSE(block->IsLoopHeader());
}
}
TEST_F(FindLoopsTest, Loop1) {
// Simple loop with one preheader and one back edge.
// var a = 0;
// while (a == a) {
// }
// return;
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::IF_EQ, 3,
Instruction::GOTO | 0xFE00,
Instruction::RETURN_VOID);
HGraph* graph = CreateCFG(data);
TestBlock(graph, 0, false, kInvalidBlockId); // entry block
TestBlock(graph, 1, false, kInvalidBlockId); // pre header
const int blocks2[] = {2, 3};
TestBlock(graph, 2, true, 2, blocks2, 2); // loop header
TestBlock(graph, 3, false, 2); // block in loop
TestBlock(graph, 4, false, kInvalidBlockId); // return block
TestBlock(graph, 5, false, kInvalidBlockId); // exit block
}
TEST_F(FindLoopsTest, Loop2) {
// Make sure we support a preheader of a loop not being the first predecessor
// in the predecessor list of the header.
// var a = 0;
// while (a == a) {
// }
// return a;
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::GOTO | 0x400,
Instruction::IF_EQ, 4,
Instruction::GOTO | 0xFE00,
Instruction::GOTO | 0xFD00,
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
TestBlock(graph, 0, false, kInvalidBlockId); // entry block
TestBlock(graph, 1, false, kInvalidBlockId); // goto block
const int blocks2[] = {2, 3};
TestBlock(graph, 2, true, 2, blocks2, 2); // loop header
TestBlock(graph, 3, false, 2); // block in loop
TestBlock(graph, 4, false, kInvalidBlockId); // pre header
TestBlock(graph, 5, false, kInvalidBlockId); // return block
TestBlock(graph, 6, false, kInvalidBlockId); // exit block
}
TEST_F(FindLoopsTest, Loop3) {
// Make sure we create a preheader of a loop when a header originally has two
// incoming blocks and one back edge.
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::IF_EQ, 3,
Instruction::GOTO | 0x100,
Instruction::IF_EQ, 3,
Instruction::GOTO | 0xFE00,
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
TestBlock(graph, 0, false, kInvalidBlockId); // entry block
TestBlock(graph, 1, false, kInvalidBlockId); // goto block
TestBlock(graph, 2, false, kInvalidBlockId);
const int blocks2[] = {3, 4};
TestBlock(graph, 3, true, 3, blocks2, 2); // loop header
TestBlock(graph, 4, false, 3); // block in loop
TestBlock(graph, 5, false, kInvalidBlockId); // pre header
TestBlock(graph, 6, false, kInvalidBlockId); // return block
TestBlock(graph, 7, false, kInvalidBlockId); // exit block
TestBlock(graph, 8, false, kInvalidBlockId); // synthesized pre header
}
TEST_F(FindLoopsTest, Loop4) {
// Test loop with originally two back edges.
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::IF_EQ, 6,
Instruction::IF_EQ, 3,
Instruction::GOTO | 0xFC00,
Instruction::GOTO | 0xFB00,
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
TestBlock(graph, 0, false, kInvalidBlockId); // entry block
TestBlock(graph, 1, false, kInvalidBlockId); // pre header
const int blocks2[] = {2, 3, 4, 5};
TestBlock(graph, 2, true, 2, blocks2, arraysize(blocks2)); // loop header
TestBlock(graph, 3, false, 2); // block in loop
TestBlock(graph, 4, false, 2); // back edge
TestBlock(graph, 5, false, 2); // back edge
TestBlock(graph, 6, false, kInvalidBlockId); // return block
TestBlock(graph, 7, false, kInvalidBlockId); // exit block
}
TEST_F(FindLoopsTest, Loop5) {
// Test loop with two exit edges.
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::IF_EQ, 6,
Instruction::IF_EQ, 3,
Instruction::GOTO | 0x0200,
Instruction::GOTO | 0xFB00,
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
TestBlock(graph, 0, false, kInvalidBlockId); // entry block
TestBlock(graph, 1, false, kInvalidBlockId); // pre header
const int blocks2[] = {2, 3, 5};
TestBlock(graph, 2, true, 2, blocks2, 3); // loop header
TestBlock(graph, 3, false, 2); // block in loop
TestBlock(graph, 4, false, kInvalidBlockId); // loop exit
TestBlock(graph, 5, false, 2); // back edge
TestBlock(graph, 6, false, kInvalidBlockId); // return block
TestBlock(graph, 7, false, kInvalidBlockId); // exit block
TestBlock(graph, 8, false, kInvalidBlockId); // synthesized block at the loop exit
}
TEST_F(FindLoopsTest, InnerLoop) {
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::IF_EQ, 6,
Instruction::IF_EQ, 3,
Instruction::GOTO | 0xFE00, // inner loop
Instruction::GOTO | 0xFB00,
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
TestBlock(graph, 0, false, kInvalidBlockId); // entry block
TestBlock(graph, 1, false, kInvalidBlockId); // pre header of outer loop
const int blocks2[] = {2, 3, 4, 5, 8};
TestBlock(graph, 2, true, 2, blocks2, 5); // outer loop header
const int blocks3[] = {3, 4};
TestBlock(graph, 3, true, 3, blocks3, 2); // inner loop header
TestBlock(graph, 4, false, 3); // back edge on inner loop
TestBlock(graph, 5, false, 2); // back edge on outer loop
TestBlock(graph, 6, false, kInvalidBlockId); // return block
TestBlock(graph, 7, false, kInvalidBlockId); // exit block
TestBlock(graph, 8, false, 2); // synthesized block as pre header of inner loop
ASSERT_TRUE(graph->GetBlocks()[3]->GetLoopInformation()->IsIn(
*graph->GetBlocks()[2]->GetLoopInformation()));
ASSERT_FALSE(graph->GetBlocks()[2]->GetLoopInformation()->IsIn(
*graph->GetBlocks()[3]->GetLoopInformation()));
}
TEST_F(FindLoopsTest, TwoLoops) {
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::IF_EQ, 3,
Instruction::GOTO | 0xFE00, // first loop
Instruction::IF_EQ, 3,
Instruction::GOTO | 0xFE00, // second loop
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
TestBlock(graph, 0, false, kInvalidBlockId); // entry block
TestBlock(graph, 1, false, kInvalidBlockId); // pre header of first loop
const int blocks2[] = {2, 3};
TestBlock(graph, 2, true, 2, blocks2, 2); // first loop header
TestBlock(graph, 3, false, 2); // back edge of first loop
const int blocks4[] = {4, 5};
TestBlock(graph, 4, true, 4, blocks4, 2); // second loop header
TestBlock(graph, 5, false, 4); // back edge of second loop
TestBlock(graph, 6, false, kInvalidBlockId); // return block
TestBlock(graph, 7, false, kInvalidBlockId); // exit block
ASSERT_FALSE(graph->GetBlocks()[4]->GetLoopInformation()->IsIn(
*graph->GetBlocks()[2]->GetLoopInformation()));
ASSERT_FALSE(graph->GetBlocks()[2]->GetLoopInformation()->IsIn(
*graph->GetBlocks()[4]->GetLoopInformation()));
}
TEST_F(FindLoopsTest, NonNaturalLoop) {
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::IF_EQ, 3,
Instruction::GOTO | 0x0100,
Instruction::IF_EQ, 3,
Instruction::GOTO | 0xFD00,
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
ASSERT_TRUE(graph->GetBlocks()[3]->IsLoopHeader());
HLoopInformation* info = graph->GetBlocks()[3]->GetLoopInformation();
ASSERT_EQ(1u, info->NumberOfBackEdges());
ASSERT_FALSE(info->GetHeader()->Dominates(info->GetBackEdges()[0]));
}
TEST_F(FindLoopsTest, DoWhileLoop) {
const std::vector<uint16_t> data = ONE_REGISTER_CODE_ITEM(
Instruction::CONST_4 | 0 | 0,
Instruction::GOTO | 0x0100,
Instruction::IF_EQ, 0xFFFF,
Instruction::RETURN | 0 << 8);
HGraph* graph = CreateCFG(data);
TestBlock(graph, 0, false, kInvalidBlockId); // entry block
TestBlock(graph, 1, false, kInvalidBlockId); // pre header of first loop
const int blocks2[] = {2, 3, 6};
TestBlock(graph, 2, true, 2, blocks2, 3); // loop header
TestBlock(graph, 3, false, 2); // back edge of first loop
TestBlock(graph, 4, false, kInvalidBlockId); // return block
TestBlock(graph, 5, false, kInvalidBlockId); // exit block
TestBlock(graph, 6, false, 2); // synthesized block to avoid a critical edge
}
} // namespace art
|
