1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
|
/*
* Copyright (C) 2018 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "select_generator.h"
#include "base/arena_allocator.h"
#include "base/macros.h"
#include "builder.h"
#include "nodes.h"
#include "optimizing_unit_test.h"
#include "side_effects_analysis.h"
namespace art HIDDEN {
class SelectGeneratorTest : public OptimizingUnitTest {
protected:
void InitGraphAndParameters() {
InitGraph();
AddParameter(new (GetAllocator()) HParameterValue(graph_->GetDexFile(),
dex::TypeIndex(0),
0,
DataType::Type::kInt32));
}
void ConstructBasicGraphForSelect(HInstruction* instr) {
HBasicBlock* if_block = AddNewBlock();
HBasicBlock* then_block = AddNewBlock();
HBasicBlock* else_block = AddNewBlock();
entry_block_->ReplaceSuccessor(return_block_, if_block);
if_block->AddSuccessor(then_block);
if_block->AddSuccessor(else_block);
then_block->AddSuccessor(return_block_);
else_block->AddSuccessor(return_block_);
HParameterValue* bool_param = new (GetAllocator()) HParameterValue(graph_->GetDexFile(),
dex::TypeIndex(0),
1,
DataType::Type::kBool);
entry_block_->AddInstruction(bool_param);
HIntConstant* const1 = graph_->GetIntConstant(1);
if_block->AddInstruction(new (GetAllocator()) HIf(bool_param));
then_block->AddInstruction(instr);
then_block->AddInstruction(new (GetAllocator()) HGoto());
else_block->AddInstruction(new (GetAllocator()) HGoto());
HPhi* phi = new (GetAllocator()) HPhi(GetAllocator(), 0, 0, DataType::Type::kInt32);
return_block_->AddPhi(phi);
phi->AddInput(instr);
phi->AddInput(const1);
}
bool CheckGraphAndTrySelectGenerator() {
graph_->BuildDominatorTree();
EXPECT_TRUE(CheckGraph());
SideEffectsAnalysis side_effects(graph_);
side_effects.Run();
return HSelectGenerator(graph_, /*handles*/ nullptr, /*stats*/ nullptr).Run();
}
};
// HDivZeroCheck might throw and should not be hoisted from the conditional to an unconditional.
TEST_F(SelectGeneratorTest, testZeroCheck) {
InitGraphAndParameters();
HDivZeroCheck* instr = new (GetAllocator()) HDivZeroCheck(parameters_[0], 0);
ConstructBasicGraphForSelect(instr);
ArenaVector<HInstruction*> current_locals({parameters_[0], graph_->GetIntConstant(1)},
GetAllocator()->Adapter(kArenaAllocInstruction));
ManuallyBuildEnvFor(instr, ¤t_locals);
EXPECT_FALSE(CheckGraphAndTrySelectGenerator());
}
// Test that SelectGenerator succeeds with HAdd.
TEST_F(SelectGeneratorTest, testAdd) {
InitGraphAndParameters();
HAdd* instr = new (GetAllocator()) HAdd(DataType::Type::kInt32,
parameters_[0],
parameters_[0], 0);
ConstructBasicGraphForSelect(instr);
EXPECT_TRUE(CheckGraphAndTrySelectGenerator());
}
} // namespace art
|
