1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390
|
/*
* Copyright (C) 2019 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.lock_checker;
import android.util.Log;
import dalvik.system.AnnotatedStackTraceElement;
import dalvik.system.VMStack;
import java.io.PrintWriter;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.atomic.AtomicInteger;
class OnThreadLockChecker implements LockHook.LockChecker {
private static final String TAG = "LockCheckOnThread";
private static final boolean SKIP_RECURSIVE = true;
private final Thread mChecker;
private final AtomicInteger mNumDetected = new AtomicInteger();
private final AtomicInteger mNumDetectedUnique = new AtomicInteger();
// Queue for possible violations, to handle them on the sChecker thread.
private final LinkedBlockingQueue<Violation> mQueue = new LinkedBlockingQueue<>();
// The stack of locks held on the current thread.
private final ThreadLocal<List<Object>> mHeldLocks = ThreadLocal
.withInitial(() -> new ArrayList<>(10));
// A cached stacktrace hasher for each thread. The hasher caches internal objects and is not
// thread-safe.
private final ThreadLocal<LockHook.StacktraceHasher> mStacktraceHasher = ThreadLocal
.withInitial(() -> new LockHook.StacktraceHasher());
// A map of stacktrace hashes we have seen.
private final ConcurrentMap<String, Boolean> mDumpedStacktraceHashes =
new ConcurrentHashMap<>();
OnThreadLockChecker() {
mChecker = new Thread(() -> checker());
mChecker.setName(TAG);
mChecker.setPriority(Thread.MIN_PRIORITY);
mChecker.start();
}
private static class LockPair {
// Consider WeakReference. It will require also caching the String
// description for later reporting, though.
Object mFirst;
Object mSecond;
private int mCachedHashCode;
LockPair(Object first, Object second) {
mFirst = first;
mSecond = second;
computeHashCode();
}
public void set(Object newFirst, Object newSecond) {
mFirst = newFirst;
mSecond = newSecond;
computeHashCode();
}
private void computeHashCode() {
final int prime = 31;
int result = 1;
result = prime * result + ((mFirst == null) ? 0 : System.identityHashCode(mFirst));
result = prime * result + ((mSecond == null) ? 0 : System.identityHashCode(mSecond));
mCachedHashCode = result;
}
@Override
public int hashCode() {
return mCachedHashCode;
}
@Override
public boolean equals(Object obj) {
if (this == obj) {
return true;
}
if (obj == null) {
return false;
}
if (getClass() != obj.getClass()) {
return false;
}
LockPair other = (LockPair) obj;
return mFirst == other.mFirst && mSecond == other.mSecond;
}
}
private static class OrderData {
final int mTid;
final String mThreadName;
final AnnotatedStackTraceElement[] mStack;
OrderData(int tid, String threadName, AnnotatedStackTraceElement[] stack) {
this.mTid = tid;
this.mThreadName = threadName;
this.mStack = stack;
}
}
private static ConcurrentMap<LockPair, OrderData> sLockOrderMap = new ConcurrentHashMap<>();
@Override
public void pre(Object lock) {
handlePre(Thread.currentThread(), lock);
}
@Override
public void post(Object lock) {
handlePost(Thread.currentThread(), lock);
}
private void handlePre(Thread self, Object lock) {
List<Object> heldLocks = mHeldLocks.get();
LockHook.updateDeepestNest(heldLocks.size() + 1);
heldLocks.add(lock);
if (heldLocks.size() == 1) {
return;
}
// Data about this location. Cached and lazily initialized.
AnnotatedStackTraceElement[] annotatedStack = null;
OrderData orderData = null;
// Reused tmp pair;
LockPair tmp = new LockPair(lock, lock);
int size = heldLocks.size() - 1;
for (int i = 0; i < size; i++) {
Object alreadyHeld = heldLocks.get(i);
if (SKIP_RECURSIVE && lock == alreadyHeld) {
return;
}
// Check if we've already seen alreadyHeld -> lock.
tmp.set(alreadyHeld, lock);
if (sLockOrderMap.containsKey(tmp)) {
continue; // Already seen.
}
// Note: could insert the OrderData now. This would mean we only
// report one instance for each order violation, but it avoids
// the expensive hashing in handleViolation for duplicate stacks.
// Locking alreadyHeld -> lock, check whether the inverse exists.
tmp.set(lock, alreadyHeld);
// We technically need a critical section here. Add synchronized and
// skip
// instrumenting this class. For now, a concurrent hash map is good
// enough.
OrderData oppositeData = sLockOrderMap.getOrDefault(tmp, null);
if (oppositeData != null) {
if (annotatedStack == null) {
annotatedStack = VMStack.getAnnotatedThreadStackTrace(self);
}
postViolation(self, alreadyHeld, lock, annotatedStack, oppositeData);
continue;
}
// Enter our occurrence.
if (annotatedStack == null) {
annotatedStack = VMStack.getAnnotatedThreadStackTrace(self);
}
if (orderData == null) {
orderData = new OrderData((int) self.getId(), self.getName(), annotatedStack);
}
sLockOrderMap.putIfAbsent(new LockPair(alreadyHeld, lock), orderData);
// Check again whether we might have raced with the opposite.
oppositeData = sLockOrderMap.getOrDefault(tmp, null);
if (oppositeData != null) {
postViolation(self, alreadyHeld, lock, annotatedStack, oppositeData);
}
}
}
private void handlePost(Thread self, Object lock) {
List<Object> heldLocks = mHeldLocks.get();
if (heldLocks.isEmpty()) {
Log.wtf("LockCheckMine", "Empty thread list on post()");
return;
}
int index = heldLocks.size() - 1;
if (heldLocks.get(index) != lock) {
Log.wtf("LockCheckMine", "post(" + Violation.describeLock(lock) + ") vs [..., "
+ Violation.describeLock(heldLocks.get(index)) + "]");
return;
}
heldLocks.remove(index);
}
private static class Violation implements LockHook.Violation {
int mSelfTid;
String mSelfName;
Object mAlreadyHeld;
Object mLock;
AnnotatedStackTraceElement[] mStack;
OrderData mOppositeData;
private static final int STACK_OFFSET = 4;
Violation(Thread self, Object alreadyHeld, Object lock,
AnnotatedStackTraceElement[] stack, OrderData oppositeData) {
this.mSelfTid = (int) self.getId();
this.mSelfName = self.getName();
this.mAlreadyHeld = alreadyHeld;
this.mLock = lock;
this.mStack = stack;
this.mOppositeData = oppositeData;
}
private static String getAnnotatedStackString(AnnotatedStackTraceElement[] stackTrace,
int skip, String extra, int prefixAfter, String prefix) {
StringBuilder sb = new StringBuilder();
for (int i = skip; i < stackTrace.length; i++) {
AnnotatedStackTraceElement element = stackTrace[i];
sb.append(" ").append(i >= prefixAfter ? prefix : "").append("at ")
.append(element.getStackTraceElement()).append('\n');
if (i == skip && extra != null) {
sb.append(" ").append(extra).append('\n');
}
if (element.getHeldLocks() != null) {
for (Object held : element.getHeldLocks()) {
sb.append(" ").append(i >= prefixAfter ? prefix : "")
.append(describeLocking(held, "locked")).append('\n');
}
}
}
return sb.toString();
}
private static String describeLocking(Object lock, String action) {
return String.format("- %s %s", action, describeLock(lock));
}
private static int getTo(AnnotatedStackTraceElement[] stack, Object searchFor) {
// Extract the range of the annotated stack.
int to = stack.length - 1;
for (int i = 0; i < stack.length; i++) {
Object[] locks = stack[i].getHeldLocks();
if (locks != null) {
for (Object heldLock : locks) {
if (heldLock == searchFor) {
to = i;
break;
}
}
}
}
return to;
}
private static String describeLock(Object lock) {
return String.format("<0x%08x> (a %s)", System.identityHashCode(lock),
lock.getClass().getName());
}
// Synthesize an exception.
public Throwable getException() {
RuntimeException inner = new RuntimeException("Previously locked");
inner.setStackTrace(synthesizeStackTrace(mOppositeData.mStack));
RuntimeException outer = new RuntimeException(toString(), inner);
outer.setStackTrace(synthesizeStackTrace(mStack));
return outer;
}
private StackTraceElement[] synthesizeStackTrace(AnnotatedStackTraceElement[] stack) {
StackTraceElement[] out = new StackTraceElement[stack.length - STACK_OFFSET];
for (int i = 0; i < out.length; i++) {
out[i] = stack[i + STACK_OFFSET].getStackTraceElement();
}
return out;
}
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("Lock inversion detected!\n");
sb.append(" Locked ");
sb.append(describeLock(mLock));
sb.append(" -> ");
sb.append(describeLock(mAlreadyHeld));
sb.append(" on thread ").append(mOppositeData.mTid).append(" (")
.append(mOppositeData.mThreadName).append(")");
sb.append(" at:\n");
sb.append(getAnnotatedStackString(mOppositeData.mStack, STACK_OFFSET,
describeLocking(mAlreadyHeld, "will lock"), getTo(mOppositeData.mStack, mLock)
+ 1, " | "));
sb.append(" Locking ");
sb.append(describeLock(mAlreadyHeld));
sb.append(" -> ");
sb.append(describeLock(mLock));
sb.append(" on thread ").append(mSelfTid).append(" (").append(mSelfName).append(")");
sb.append(" at:\n");
sb.append(getAnnotatedStackString(mStack, STACK_OFFSET,
describeLocking(mLock, "will lock"),
getTo(mStack, mAlreadyHeld) + 1, " | "));
return sb.toString();
}
}
private void postViolation(Thread self, Object alreadyHeld, Object lock,
AnnotatedStackTraceElement[] annotatedStack, OrderData oppositeData) {
mQueue.offer(new Violation(self, alreadyHeld, lock, annotatedStack, oppositeData));
}
private void handleViolation(Violation v) {
mNumDetected.incrementAndGet();
// Extract the range of the annotated stack.
int to = Violation.getTo(v.mStack, v.mAlreadyHeld);
if (LockHook.shouldDumpStacktrace(mStacktraceHasher.get(), mDumpedStacktraceHashes,
Boolean.TRUE, v.mStack, 0, to)) {
mNumDetectedUnique.incrementAndGet();
LockHook.addViolation(v);
}
}
private void checker() {
LockHook.doCheckOnThisThread(false);
for (;;) {
try {
Violation v = mQueue.take();
handleViolation(v);
} catch (InterruptedException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
}
}
@Override
public int getNumDetected() {
return mNumDetected.get();
}
@Override
public int getNumDetectedUnique() {
return mNumDetectedUnique.get();
}
@Override
public String getCheckerName() {
return "Standard LockChecker";
}
@Override
public void dump(PrintWriter pw) {
pw.print(getCheckerName());
pw.print(": d=");
pw.print(getNumDetected());
pw.print(" du=");
pw.print(getNumDetectedUnique());
}
}
|