1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270
|
/*
* Copyright (C) 2022 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "task_profiles.h"
#include <android-base/logging.h>
#include <android-base/strings.h>
#include <gtest/gtest.h>
#include <mntent.h>
#include <processgroup/processgroup.h>
#include <stdio.h>
#include <unistd.h>
#include <fstream>
using ::android::base::ERROR;
using ::android::base::LogFunction;
using ::android::base::LogId;
using ::android::base::LogSeverity;
using ::android::base::SetLogger;
using ::android::base::Split;
using ::android::base::VERBOSE;
using ::testing::TestWithParam;
using ::testing::Values;
namespace {
bool IsCgroupV2MountedRw() {
std::unique_ptr<FILE, int (*)(FILE*)> mnts(setmntent("/proc/mounts", "re"), endmntent);
if (!mnts) {
LOG(ERROR) << "Failed to open /proc/mounts";
return false;
}
struct mntent* mnt;
while ((mnt = getmntent(mnts.get()))) {
if (strcmp(mnt->mnt_type, "cgroup2") != 0) {
continue;
}
const std::vector<std::string> options = Split(mnt->mnt_opts, ",");
return std::count(options.begin(), options.end(), "ro") == 0;
}
return false;
}
class ScopedLogCapturer {
public:
struct log_args {
LogId log_buffer_id;
LogSeverity severity;
std::string tag;
std::string file;
unsigned int line;
std::string message;
};
// Constructor. Installs a new logger and saves the currently active logger.
ScopedLogCapturer() {
saved_severity_ = SetMinimumLogSeverity(android::base::VERBOSE);
saved_logger_ = SetLogger([this](LogId log_buffer_id, LogSeverity severity, const char* tag,
const char* file, unsigned int line, const char* message) {
if (saved_logger_) {
saved_logger_(log_buffer_id, severity, tag, file, line, message);
}
log_.emplace_back(log_args{.log_buffer_id = log_buffer_id,
.severity = severity,
.tag = tag,
.file = file,
.line = line,
.message = message});
});
}
// Destructor. Restores the original logger and log level.
~ScopedLogCapturer() {
SetLogger(std::move(saved_logger_));
SetMinimumLogSeverity(saved_severity_);
}
ScopedLogCapturer(const ScopedLogCapturer&) = delete;
ScopedLogCapturer& operator=(const ScopedLogCapturer&) = delete;
// Returns the logged lines.
const std::vector<log_args>& Log() const { return log_; }
private:
LogSeverity saved_severity_;
LogFunction saved_logger_;
std::vector<log_args> log_;
};
// cgroup attribute at the top level of the cgroup hierarchy.
class ProfileAttributeMock : public IProfileAttribute {
public:
ProfileAttributeMock(const std::string& file_name) : file_name_(file_name) {}
~ProfileAttributeMock() override = default;
void Reset(const CgroupController& controller, const std::string& file_name,
const std::string& file_v2_name) override {
CHECK(false);
}
const CgroupController* controller() const override {
CHECK(false);
return {};
}
const std::string& file_name() const override { return file_name_; }
bool GetPathForProcess(uid_t uid, pid_t pid, std::string* path) const override {
return GetPathForTask(pid, path);
}
bool GetPathForTask(int tid, std::string* path) const override {
#ifdef __ANDROID__
CHECK(CgroupGetControllerPath(CGROUPV2_CONTROLLER_NAME, path));
CHECK_GT(path->length(), 0);
if (path->rbegin()[0] != '/') {
*path += "/";
}
#else
// Not Android.
*path = "/sys/fs/cgroup/";
#endif
*path += file_name_;
return true;
};
bool GetPathForUID(uid_t, std::string*) const override { return false; }
private:
const std::string file_name_;
};
struct TestParam {
const char* attr_name;
const char* attr_value;
bool optional_attr;
bool result;
LogSeverity log_severity;
const char* log_prefix;
const char* log_suffix;
};
class SetAttributeFixture : public TestWithParam<TestParam> {
public:
~SetAttributeFixture() = default;
};
TEST_P(SetAttributeFixture, SetAttribute) {
// Treehugger runs host tests inside a container either without cgroupv2
// support or with the cgroup filesystem mounted read-only.
if (!IsCgroupV2MountedRw()) {
GTEST_SKIP();
return;
}
const TestParam params = GetParam();
ScopedLogCapturer captured_log;
ProfileAttributeMock pa(params.attr_name);
SetAttributeAction a(&pa, params.attr_value, params.optional_attr);
EXPECT_EQ(a.ExecuteForProcess(getuid(), getpid()), params.result);
auto log = captured_log.Log();
if (params.log_prefix || params.log_suffix) {
ASSERT_EQ(log.size(), 1);
EXPECT_EQ(log[0].severity, params.log_severity);
if (params.log_prefix) {
EXPECT_EQ(log[0].message.find(params.log_prefix), 0);
}
if (params.log_suffix) {
EXPECT_NE(log[0].message.find(params.log_suffix), std::string::npos);
}
} else {
ASSERT_EQ(log.size(), 0);
}
}
class TaskProfileFixture : public TestWithParam<TestParam> {
public:
~TaskProfileFixture() = default;
};
TEST_P(TaskProfileFixture, TaskProfile) {
// Treehugger runs host tests inside a container without cgroupv2 support.
if (!IsCgroupV2MountedRw()) {
GTEST_SKIP();
return;
}
const TestParam params = GetParam();
ProfileAttributeMock pa(params.attr_name);
// Test simple profile with one action
std::shared_ptr<TaskProfile> tp = std::make_shared<TaskProfile>("test_profile");
tp->Add(std::make_unique<SetAttributeAction>(&pa, params.attr_value, params.optional_attr));
EXPECT_EQ(tp->IsValidForProcess(getuid(), getpid()), params.result);
EXPECT_EQ(tp->IsValidForTask(getpid()), params.result);
// Test aggregate profile
TaskProfile tp2("meta_profile");
std::vector<std::shared_ptr<TaskProfile>> profiles = {tp};
tp2.Add(std::make_unique<ApplyProfileAction>(profiles));
EXPECT_EQ(tp2.IsValidForProcess(getuid(), getpid()), params.result);
EXPECT_EQ(tp2.IsValidForTask(getpid()), params.result);
}
// Test the four combinations of optional_attr {false, true} and cgroup attribute { does not exist,
// exists }.
INSTANTIATE_TEST_SUITE_P(
SetAttributeTestSuite, SetAttributeFixture,
Values(
// Test that attempting to write into a non-existing cgroup attribute fails and also
// that an error message is logged.
TestParam{.attr_name = "no-such-attribute",
.attr_value = ".",
.optional_attr = false,
.result = false,
.log_severity = ERROR,
.log_prefix = "No such cgroup attribute"},
// Test that attempting to write into an optional non-existing cgroup attribute
// results in the return value 'true' and also that no messages are logged.
TestParam{.attr_name = "no-such-attribute",
.attr_value = ".",
.optional_attr = true,
.result = true},
// Test that attempting to write an invalid value into an existing optional cgroup
// attribute fails and also that it causes an error
// message to be logged.
TestParam{.attr_name = "cgroup.procs",
.attr_value = "-1",
.optional_attr = true,
.result = false,
.log_severity = ERROR,
.log_prefix = "Failed to write",
.log_suffix = geteuid() == 0 ? "Invalid argument" : "Permission denied"},
// Test that attempting to write into an existing optional read-only cgroup
// attribute fails and also that it causes an error message to be logged.
TestParam{
.attr_name = "cgroup.controllers",
.attr_value = ".",
.optional_attr = false,
.result = false,
.log_severity = ERROR,
.log_prefix = "Failed to write",
.log_suffix = geteuid() == 0 ? "Invalid argument" : "Permission denied"}));
// Test TaskProfile IsValid calls.
INSTANTIATE_TEST_SUITE_P(
TaskProfileTestSuite, TaskProfileFixture,
Values(
// Test operating on non-existing cgroup attribute fails.
TestParam{.attr_name = "no-such-attribute",
.attr_value = ".",
.optional_attr = false,
.result = false},
// Test operating on optional non-existing cgroup attribute succeeds.
TestParam{.attr_name = "no-such-attribute",
.attr_value = ".",
.optional_attr = true,
.result = true},
// Test operating on existing cgroup attribute succeeds.
TestParam{.attr_name = "cgroup.procs",
.attr_value = ".",
.optional_attr = false,
.result = true},
// Test operating on optional existing cgroup attribute succeeds.
TestParam{.attr_name = "cgroup.procs",
.attr_value = ".",
.optional_attr = true,
.result = true}));
} // namespace
|