1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
|
/*
* Copyright 2021 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#undef LOG_TAG
#define LOG_TAG "FlagManagerTest"
#include <common/FlagManager.h>
#include <common/test/FlagUtils.h>
#include <gmock/gmock.h>
#include <gtest/gtest.h>
#include <log/log.h>
#include <com_android_graphics_surfaceflinger_flags.h>
namespace android {
using namespace com::android::graphics::surfaceflinger;
using testing::Return;
class TestableFlagManager : public FlagManager {
public:
TestableFlagManager() : FlagManager(ConstructorTag{}) { markBootCompleted(); }
~TestableFlagManager() = default;
MOCK_METHOD(std::optional<bool>, getBoolProperty, (const char*), (const, override));
MOCK_METHOD(bool, getServerConfigurableFlag, (const char*), (const, override));
void markBootIncomplete() { mBootCompleted = false; }
};
class FlagManagerTest : public testing::Test {
public:
FlagManagerTest() {
const ::testing::TestInfo* const test_info =
::testing::UnitTest::GetInstance()->current_test_info();
ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name());
}
~FlagManagerTest() override {
const ::testing::TestInfo* const test_info =
::testing::UnitTest::GetInstance()->current_test_info();
ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name());
}
TestableFlagManager mFlagManager;
};
TEST_F(FlagManagerTest, isSingleton) {
EXPECT_EQ(&FlagManager::getInstance(), &FlagManager::getInstance());
}
TEST_F(FlagManagerTest, legacyCreashesIfQueriedBeforeBoot) {
mFlagManager.markBootIncomplete();
EXPECT_DEATH(FlagManager::getInstance().test_flag(), "");
}
TEST_F(FlagManagerTest, legacyReturnsOverride) {
EXPECT_CALL(mFlagManager, getBoolProperty).WillOnce(Return(true));
EXPECT_EQ(true, mFlagManager.test_flag());
EXPECT_CALL(mFlagManager, getBoolProperty).WillOnce(Return(false));
EXPECT_EQ(false, mFlagManager.test_flag());
}
TEST_F(FlagManagerTest, legacyReturnsValue) {
EXPECT_CALL(mFlagManager, getBoolProperty).WillRepeatedly(Return(std::nullopt));
EXPECT_CALL(mFlagManager, getServerConfigurableFlag).WillOnce(Return(true));
EXPECT_EQ(true, mFlagManager.test_flag());
EXPECT_CALL(mFlagManager, getServerConfigurableFlag).WillOnce(Return(false));
EXPECT_EQ(false, mFlagManager.test_flag());
}
TEST_F(FlagManagerTest, creashesIfQueriedBeforeBoot) {
mFlagManager.markBootIncomplete();
EXPECT_DEATH(FlagManager::getInstance()
.refresh_rate_overlay_on_external_display(), "");
}
TEST_F(FlagManagerTest, returnsOverrideTrue) {
mFlagManager.markBootCompleted();
SET_FLAG_FOR_TEST(flags::refresh_rate_overlay_on_external_display, false);
// This is stored in a static variable, so this test depends on the fact
// that this flag has not been read in this process.
EXPECT_CALL(mFlagManager, getBoolProperty).WillOnce(Return(true));
EXPECT_TRUE(mFlagManager.refresh_rate_overlay_on_external_display());
// Further calls will not result in further calls to getBoolProperty.
EXPECT_TRUE(mFlagManager.refresh_rate_overlay_on_external_display());
}
TEST_F(FlagManagerTest, returnsOverrideReadonly) {
SET_FLAG_FOR_TEST(flags::add_sf_skipped_frames_to_trace, false);
// This is stored in a static variable, so this test depends on the fact
// that this flag has not been read in this process.
EXPECT_CALL(mFlagManager, getBoolProperty).WillOnce(Return(true));
EXPECT_TRUE(mFlagManager.add_sf_skipped_frames_to_trace());
}
// disabling this test since we need to use a unique flag for this test,
// but we only one server flag currently. Re-enable once we have a new flag
// and change this test to use a unique flag.
TEST_F(FlagManagerTest, DISABLED_returnsOverrideFalse) {
mFlagManager.markBootCompleted();
SET_FLAG_FOR_TEST(flags::refresh_rate_overlay_on_external_display, true);
// This is stored in a static variable, so this test depends on the fact
// that this flag has not been read in this process.
EXPECT_CALL(mFlagManager, getBoolProperty).WillOnce(Return(false));
EXPECT_FALSE(mFlagManager.refresh_rate_overlay_on_external_display());
}
TEST_F(FlagManagerTest, ignoresOverrideInUnitTestMode) {
mFlagManager.setUnitTestMode();
SET_FLAG_FOR_TEST(flags::multithreaded_present, true);
// If this has not been called in this process, it will be called.
// Regardless, the result is ignored.
EXPECT_CALL(mFlagManager, getBoolProperty).WillRepeatedly(Return(false));
EXPECT_EQ(true, mFlagManager.multithreaded_present());
}
TEST_F(FlagManagerTest, returnsValue) {
mFlagManager.setUnitTestMode();
EXPECT_CALL(mFlagManager, getBoolProperty).WillRepeatedly(Return(std::nullopt));
{
SET_FLAG_FOR_TEST(flags::refresh_rate_overlay_on_external_display, true);
EXPECT_EQ(true, mFlagManager.refresh_rate_overlay_on_external_display());
}
{
SET_FLAG_FOR_TEST(flags::refresh_rate_overlay_on_external_display, false);
EXPECT_EQ(false, mFlagManager.refresh_rate_overlay_on_external_display());
}
}
TEST_F(FlagManagerTest, readonlyReturnsValue) {
mFlagManager.setUnitTestMode();
EXPECT_CALL(mFlagManager, getBoolProperty).WillRepeatedly(Return(std::nullopt));
{
SET_FLAG_FOR_TEST(flags::misc1, true);
EXPECT_EQ(true, mFlagManager.misc1());
}
{
SET_FLAG_FOR_TEST(flags::misc1, false);
EXPECT_EQ(false, mFlagManager.misc1());
}
}
} // namespace android
|
