1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
|
#!/usr/bin/python3
# ----------------------------------------------------------------------
# Copyright (C) 2023 Christian Boltz <apparmor@cboltz.de>
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of version 2 of the GNU General Public
# License as published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# ----------------------------------------------------------------------
import unittest
from collections import namedtuple
import apparmor.severity as severity
from apparmor.common import AppArmorBug, AppArmorException
from apparmor.rule.all import AllRule, AllRuleset
from apparmor.translations import init_translation
from common_test import AATest, setup_all_loops
_ = init_translation()
exp = namedtuple(
'exp', ('audit', 'allow_keyword', 'deny', 'comment',
# no localvars
))
# --- tests for single AllRule --- #
class AllTest(AATest):
def _compare_obj(self, obj, expected):
self.assertEqual(expected.allow_keyword, obj.allow_keyword)
self.assertEqual(expected.audit, obj.audit)
self.assertEqual(expected.deny, obj.deny)
self.assertEqual(expected.comment, obj.comment)
class AllTestParse(AllTest):
tests = (
# rawrule audit allow deny comment
('all,', exp(False, False, False, '')),
('deny all, # comment', exp(False, False, True, ' # comment')),
('audit allow all,', exp(True, True, False, '')),
('audit allow all,', exp(True, True, False, '')),
)
def _run_test(self, rawrule, expected):
self.assertTrue(AllRule.match(rawrule))
obj = AllRule.create_instance(rawrule)
self.assertEqual(rawrule.strip(), obj.raw_rule)
self._compare_obj(obj, expected)
class AllTestParseInvalid(AllTest):
tests = (
('all -> ,', AppArmorException),
('owner all,', AppArmorException),
('all foo ,', AppArmorException),
)
def _run_test(self, rawrule, expected):
self.assertFalse(AllRule.match(rawrule))
with self.assertRaises(expected):
AllRule.create_instance(rawrule)
# we won't ever support converting a log event to an 'all,' rule
# class AllTestParseFromLog(AllTest):
class AllFromInit(AllTest):
tests = (
# AllRule object audit allow deny comment
(AllRule(deny=True), exp(False, False, True, '')),
(AllRule(), exp(False, False, False, '')),
)
def _run_test(self, obj, expected):
self._compare_obj(obj, expected)
# no localvars -> no way to hand over invalid values, or to miss a required parameter
# class InvalidAllInit(AATest):
class InvalidAllTest(AATest):
def _check_invalid_rawrule(self, rawrule):
obj = None
self.assertFalse(AllRule.match(rawrule))
with self.assertRaises(AppArmorException):
obj = AllRule.create_instance(rawrule)
self.assertIsNone(obj, 'AllRule handed back an object unexpectedly')
def test_invalid_net_missing_comma(self):
self._check_invalid_rawrule('all') # missing comma
def test_invalid_net_non_AllRule(self):
self._check_invalid_rawrule('dbus,') # not a all rule
# no localvars, therefore we can't break anything inside the class variables
# def test_empty_all_data_1(self):
class WriteAllTestAATest(AATest):
tests = (
# raw rule clean rule
(' all , # foo ', 'all, # foo'),
(' audit all ,', 'audit all,'),
(' deny all ,# foo bar', 'deny all, # foo bar'),
(' allow all ,# foo bar', 'allow all, # foo bar'),
(' allow all ,', 'allow all,'),
(' priority = -2 allow all ,', 'priority=-2 allow all,'),
)
def _run_test(self, rawrule, expected):
self.assertTrue(AllRule.match(rawrule))
obj = AllRule.create_instance(rawrule)
clean = obj.get_clean()
raw = obj.get_raw()
self.assertEqual(expected.strip(), clean, 'unexpected clean rule')
self.assertEqual(rawrule.strip(), raw, 'unexpected raw rule')
def test_write_manually(self):
obj = AllRule(allow_keyword=True)
expected = ' allow all,'
self.assertEqual(expected, obj.get_clean(2), 'unexpected clean rule')
self.assertEqual(expected, obj.get_raw(2), 'unexpected raw rule')
class AllCoveredTest(AATest):
def _run_test(self, param, expected):
obj = AllRule.create_instance(self.rule)
check_obj = AllRule.create_instance(param)
self.assertTrue(AllRule.match(param))
self.assertEqual(obj.is_equal(check_obj), expected[0], 'Mismatch in is_equal, expected {}'.format(expected[0]))
self.assertEqual(obj.is_equal(check_obj, True), expected[1], 'Mismatch in is_equal/strict, expected {}'.format(expected[1]))
self.assertEqual(obj.is_covered(check_obj), expected[2], 'Mismatch in is_covered, expected {}'.format(expected[2]))
self.assertEqual(obj.is_covered(check_obj, True, True), expected[3], 'Mismatch in is_covered/exact, expected {}'.format(expected[3]))
class AllCoveredTest_01(AllCoveredTest):
rule = 'all,'
tests = (
# rule equal strict equal covered covered exact
(' all,', (True, True, True, True)),
(' allow all,', (True, False, True, True)),
('audit all,', (False, False, False, False)),
('audit deny all,', (False, False, False, False)),
(' deny all,', (False, False, False, False)),
)
class AllCoveredTest_02(AllCoveredTest):
rule = 'audit all,'
tests = (
# rule equal strict equal covered covered exact
(' all,', (False, False, True, False)),
('audit all,', (True, True, True, True)),
)
class AllCoveredTest_03(AllCoveredTest):
rule = 'deny all,'
tests = (
# rule equal strict equal covered covered exact
(' deny all,', (True, True, True, True)),
('audit deny all,', (False, False, False, False)),
(' all,', (False, False, False, False)), # XXX should covered be true here?
)
class AllCoveredTest_Invalid(AATest):
def test_invalid_is_covered(self):
raw_rule = 'all,'
class SomeOtherClass(AllRule):
pass
obj = AllRule.create_instance(raw_rule)
testobj = SomeOtherClass.create_instance(raw_rule) # different type
with self.assertRaises(AppArmorBug):
obj.is_covered(testobj)
def test_invalid_is_equal(self):
raw_rule = 'all,'
class SomeOtherClass(AllRule):
pass
obj = AllRule.create_instance(raw_rule)
testobj = SomeOtherClass.create_instance(raw_rule) # different type
with self.assertRaises(AppArmorBug):
obj.is_equal(testobj)
class AllSeverityTest(AATest):
tests = (
('all,', 10),
)
def _run_test(self, params, expected):
sev_db = severity.Severity('../severity.db', 'unknown')
obj = AllRule.create_instance(params)
rank = obj.severity(sev_db)
self.assertEqual(rank, expected)
class AllLogprofHeaderTest(AATest):
tests = (
('all,', [ 'All', _('Allow everything')]), # noqa: E201
('deny all,', [_('Qualifier'), 'deny', 'All', _('Allow everything')]),
('allow all,', [_('Qualifier'), 'allow', 'All', _('Allow everything')]),
('audit deny all,', [_('Qualifier'), 'audit deny', 'All', _('Allow everything')]),
)
def _run_test(self, params, expected):
obj = AllRule.create_instance(params)
self.assertEqual(obj.logprof_header(), expected)
# --- tests for AllRuleset --- #
class AllRulesTest(AATest):
def test_empty_ruleset(self):
ruleset = AllRuleset()
ruleset_2 = AllRuleset()
self.assertEqual([], ruleset.get_raw(2))
self.assertEqual([], ruleset.get_clean(2))
self.assertEqual([], ruleset_2.get_raw(2))
self.assertEqual([], ruleset_2.get_clean(2))
def test_ruleset_1(self):
ruleset = AllRuleset()
rules = (
'all,',
'all,',
)
expected_raw = [
'all,',
'all,',
'',
]
expected_clean = [
'all,',
'all,',
'',
]
for rule in rules:
ruleset.add(AllRule.create_instance(rule))
self.assertEqual(expected_raw, ruleset.get_raw())
self.assertEqual(expected_clean, ruleset.get_clean())
def test_ruleset_2(self):
ruleset = AllRuleset()
rules = (
'all,',
'allow all,',
'deny all, # example comment',
)
expected_raw = [
' all,',
' allow all,',
' deny all, # example comment',
'',
]
expected_clean = [
' deny all, # example comment',
'',
' all,',
' allow all,',
'',
]
for rule in rules:
ruleset.add(AllRule.create_instance(rule))
self.assertEqual(expected_raw, ruleset.get_raw(1))
self.assertEqual(expected_clean, ruleset.get_clean(1))
class AllGlobTestAATest(AATest):
def setUp(self):
self.ruleset = AllRuleset()
def test_glob(self):
with self.assertRaises(NotImplementedError):
# get_glob is not available for all rules
self.ruleset.get_glob('all,')
def test_glob_ext(self):
with self.assertRaises(NotImplementedError):
# get_glob_ext is not available for all rules
self.ruleset.get_glob_ext('all,')
class AllDeleteTestAATest(AATest):
pass
setup_all_loops(__name__)
if __name__ == '__main__':
unittest.main(verbosity=1)
|
