1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426
|
#!/usr/bin/env python3
# Copyright (c) 2023-2024 Arm Limited.
#
# SPDX-License-Identifier: MIT
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to
# deal in the Software without restriction, including without limitation the
# rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
# sell copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in all
# copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
import argparse
import datetime
import difflib
import filecmp
import logging
import os
import re
import subprocess
import sys
from modules.Shell import Shell
logger = logging.getLogger("format_code")
# List of directories to exclude
exceptions = [
"src/core/NEON/kernels/assembly/gemm",
"src/core/NEON/kernels/assembly/arm",
"/winograd/",
"/convolution/",
"/arm_gemm/",
"/arm_conv/",
"SConscript",
"SConstruct"
]
def adjust_copyright_year(copyright_years, curr_year):
ret_copyright_year = str()
# Read last year in the Copyright
last_year = int(copyright_years[-4:])
if last_year == curr_year:
ret_copyright_year = copyright_years
elif last_year == (curr_year - 1):
# Create range if latest year on the copyright is the previous
if len(copyright_years) > 4 and copyright_years[-5] == "-":
# Range already exists, update year to current
ret_copyright_year = copyright_years[:-5] + "-" + str(curr_year)
else:
# Create a new range
ret_copyright_year = copyright_years + "-" + str(curr_year)
else:
ret_copyright_year = copyright_years + ", " + str(curr_year)
return ret_copyright_year
def check_copyright( filename ):
f = open(filename, "r")
content = f.readlines()
f.close()
f = open(filename, "w")
year = datetime.datetime.now().year
ref = open("scripts/copyright_mit.txt","r").readlines()
# Need to handle python files separately
if("SConstruct" in filename or "SConscript" in filename):
start = 2
if("SConscript" in filename):
start = 3
m = re.match(r"(# Copyright \(c\) )(.*\d{4})( [Arm|ARM].*)", content[start])
line = m.group(1)
if m.group(2): # Is there a year already?
# Yes: adjust accordingly
line += adjust_copyright_year(m.group(2), year)
else:
# No: add current year
line += str(year)
line += m.group(3).replace("ARM", "Arm")
if("SConscript" in filename):
f.write('#!/usr/bin/python\n')
f.write('# -*- coding: utf-8 -*-\n\n')
f.write(line+"\n")
# Copy the rest of the file's content:
f.write("".join(content[start + 1:]))
f.close()
return
# This only works until year 9999
m = re.match(r"(.*Copyright \(c\) )(.*\d{4})( [Arm|ARM].*)", content[1])
start =len(ref)+2
if content[0] != "/*\n" or not m:
start = 0
f.write("/*\n * Copyright (c) %d Arm Limited.\n" % year)
else:
logger.debug("Found Copyright start")
logger.debug("\n\t".join([ g or "" for g in m.groups()]))
line = m.group(1)
if m.group(2): # Is there a year already?
# Yes: adjust accordingly
line += adjust_copyright_year(m.group(2), year)
else:
# No: add current year
line += str(year)
line += m.group(3).replace("ARM", "Arm")
f.write("/*\n"+line+"\n")
logger.debug(line)
# Write out the rest of the Copyright header:
for i in range(1, len(ref)):
line = ref[i]
f.write(" *")
if line.rstrip() != "":
f.write(" %s" % line)
else:
f.write("\n")
f.write(" */\n")
# Copy the rest of the file's content:
f.write("".join(content[start:]))
f.close()
def check_license(filename):
"""
Check that the license file is up-to-date
"""
f = open(filename, "r")
content = f.readlines()
f.close()
f = open(filename, "w")
f.write("".join(content[:3]))
year = datetime.datetime.now().year
# This only works until year 9999
m = re.match(r"(.*FileCopyrightText: )(.*\d{4})( [arm|Arm|ARM].*)", content[3])
if not m:
f.write("# SPDX-FileCopyrightText: {} Arm Limited\n#\n".format(year))
else:
updated_year = adjust_copyright_year(m.group(2), year)
f.write("# SPDX-FileCopyrightText: {} Arm Limited\n".format(updated_year))
# Copy the rest of the file's content:
f.write("".join(content[4:]))
f.close()
class OtherChecksRun:
def __init__(self, folder, error_diff=False, strategy="all"):
self.folder = folder
self.error_diff=error_diff
self.strategy = strategy
def error_on_diff(self, msg):
retval = 0
if self.error_diff:
diff = self.shell.run_single_to_str("git diff")
if len(diff) > 0:
retval = -1
logger.error(diff)
logger.error("\n"+msg)
return retval
def run(self):
retval = 0
self.shell = Shell()
self.shell.save_cwd()
this_dir = os.path.dirname(__file__)
self.shell.cd(self.folder)
self.shell.prepend_env("PATH","%s/../bin" % this_dir)
to_check = ""
if self.strategy != "all":
to_check, skip_copyright = FormatCodeRun.get_files(self.folder, self.strategy)
#FIXME: Exclude shaders!
logger.info("Running ./scripts/format_doxygen.py")
logger.debug(self.shell.run_single_to_str("./scripts/format_doxygen.py %s" % " ".join(to_check)))
retval = self.error_on_diff("Doxygen comments badly formatted (check above diff output for more details) try to run ./scripts/format_doxygen.py on your patch and resubmit")
if retval == 0:
logger.info("Running ./scripts/include_functions_kernels.py")
logger.debug(self.shell.run_single_to_str("python ./scripts/include_functions_kernels.py"))
retval = self.error_on_diff("Some kernels or functions are not included in their corresponding master header (check above diff output to see which includes are missing)")
if retval == 0:
try:
logger.info("Running ./scripts/check_bad_style.sh")
logger.debug(self.shell.run_single_to_str("./scripts/check_bad_style.sh"))
#logger.debug(self.shell.run_single_to_str("./scripts/check_bad_style.sh %s" % " ".join(to_check)))
except subprocess.CalledProcessError as e:
logger.error("Command %s returned:\n%s" % (e.cmd, e.output))
retval -= 1
if retval != 0:
raise Exception("format-code failed with error code %d" % retval)
class FormatCodeRun:
@staticmethod
def get_files(folder, strategy="git-head"):
shell = Shell()
shell.cd(folder)
skip_copyright = False
if strategy == "git-head":
cmd = "git diff-tree --no-commit-id --name-status -r HEAD | grep \"^[AMRT]\" | cut -f 2"
elif strategy == "git-diff":
cmd = "git diff --name-status --cached -r HEAD | grep \"^[AMRT]\" | rev | cut -f 1 | rev"
else:
cmd = "git ls-tree -r HEAD --name-only"
# Skip copyright checks when running on all files because we don't know when they were last modified
# Therefore we can't tell if their copyright dates are correct
skip_copyright = True
grep_folder = "grep -e \"^\\(arm_compute\\|src\\|examples\\|tests\\|utils\\|support\\)/\""
grep_extension = "grep -e \"\\.\\(cpp\\|h\\|hh\\|inl\\|cl\\|cs\\|hpp\\)$\""
list_files = shell.run_single_to_str(cmd+" | { "+ grep_folder+" | "+grep_extension + " || true; }")
to_check = [ f for f in list_files.split("\n") if len(f) > 0]
# Check for scons files as they are excluded from the above list
list_files = shell.run_single_to_str(cmd+" | { grep -e \"SC\" || true; }")
to_check += [ f for f in list_files.split("\n") if len(f) > 0]
return (to_check, skip_copyright)
def __init__(self, files, folder, error_diff=False, skip_copyright=False):
self.files = files
self.folder = folder
self.skip_copyright = skip_copyright
self.error_diff=error_diff
def error_on_diff(self, msg):
retval = 0
if self.error_diff:
diff = self.shell.run_single_to_str("git diff")
if len(diff) > 0:
retval = -1
logger.error(diff)
logger.error("\n"+msg)
return retval
def run(self):
if len(self.files) < 1:
logger.debug("No file: early exit")
retval = 0
self.shell = Shell()
self.shell.save_cwd()
this_dir = os.path.dirname(__file__)
try:
self.shell.cd(self.folder)
self.shell.prepend_env("PATH","%s/../bin" % this_dir)
for f in self.files:
if not self.skip_copyright:
check_copyright(f)
skip_this_file = False
for e in exceptions:
if e in f:
logger.warning("Skipping '%s' file: %s" % (e,f))
skip_this_file = True
break
if skip_this_file:
continue
logger.info("Formatting %s" % f)
check_license("LICENSES/MIT.txt")
except subprocess.CalledProcessError as e:
retval = -1
logger.error(e)
logger.error("OUTPUT= %s" % e.output)
retval += self.error_on_diff("See above for clang-tidy errors")
if retval != 0:
raise Exception("format-code failed with error code %d" % retval)
class GenerateAndroidBP:
def __init__(self, folder):
self.folder = folder
self.bp_output_file = "Generated_Android.bp"
def run(self):
retval = 0
self.shell = Shell()
self.shell.save_cwd()
this_dir = os.path.dirname(__file__)
logger.debug("Running Android.bp check")
try:
self.shell.cd(self.folder)
cmd = "%s/generate_android_bp.py --folder %s --output_file %s" % (this_dir, self.folder, self.bp_output_file)
output = self.shell.run_single_to_str(cmd)
if len(output) > 0:
logger.info(output)
except subprocess.CalledProcessError as e:
retval = -1
logger.error(e)
logger.error("OUTPUT= %s" % e.output)
# Compare the genereated file with the one in the review
if not filecmp.cmp(self.bp_output_file, self.folder + "/Android.bp"):
is_mismatched = True
with open(self.bp_output_file, 'r') as generated_file:
with open(self.folder + "/Android.bp", 'r') as review_file:
diff = list(difflib.unified_diff(generated_file.readlines(), review_file.readlines(),
fromfile='Generated_Android.bp', tofile='Android.bp'))
# If the only mismatch in Android.bp file is the copyright year,
# the content of the file is considered unchanged and we don't need to update
# the copyright year. This will resolve the issue that emerges every new year.
num_added_lines = 0
num_removed_lines = 0
last_added_line = ""
last_removed_line = ""
expect_add_line = False
for line in diff:
if line.startswith("-") and not line.startswith("---"):
num_removed_lines += 1
if num_removed_lines > 1:
break
last_removed_line = line
expect_add_line = True
elif line.startswith("+") and not line.startswith("+++"):
num_added_lines += 1
if num_added_lines > 1:
break
if expect_add_line:
last_added_line = line
else:
expect_add_line = False
if num_added_lines == 1 and num_removed_lines == 1:
re_copyright = re.compile("^(?:\+|\-)// Copyright © ([0-9]+)\-([0-9]+) Arm Ltd. All rights reserved.\n$")
generated_matches = re_copyright.search(last_removed_line)
review_matches = re_copyright.search(last_added_line)
if generated_matches is not None and review_matches is not None:
if generated_matches.group(1) == review_matches.group(1) and \
int(generated_matches.group(2)) > int(review_matches.group(2)):
is_mismatched = False
if is_mismatched:
logger.error("Lines with '-' need to be added to Android.bp")
logger.error("Lines with '+' need to be removed from Android.bp")
for line in diff:
logger.error(line.rstrip())
if is_mismatched:
raise Exception("Android bp file is not updated")
if retval != 0:
raise Exception("generate Android bp file failed with error code %d" % retval)
def run_fix_code_formatting( files="git-head", folder=".", num_threads=1, error_on_diff=True):
try:
retval = 0
# Genereate Android.bp file and test it
gen_android_bp = GenerateAndroidBP(folder)
gen_android_bp.run()
to_check, skip_copyright = FormatCodeRun.get_files(folder, files)
other_checks = OtherChecksRun(folder,error_on_diff, files)
other_checks.run()
logger.debug(to_check)
num_files = len(to_check)
per_thread = max( num_files / num_threads,1)
start=0
logger.info("Files to format:\n\t%s" % "\n\t".join(to_check))
for i in range(num_threads):
if i == num_threads -1:
end = num_files
else:
end= min(start+per_thread, num_files)
sub = to_check[start:end]
logger.debug("[%d] [%d,%d] %s" % (i, start, end, sub))
start = end
format_code_run = FormatCodeRun(sub, folder, skip_copyright=skip_copyright)
format_code_run.run()
return retval
except Exception as e:
logger.error("Exception caught in run_fix_code_formatting: %s" % e)
return -1
if __name__ == "__main__":
parser = argparse.ArgumentParser(
formatter_class=argparse.RawDescriptionHelpFormatter,
description="Build & run pre-commit tests",
)
file_sources=["git-diff","git-head","all"]
parser.add_argument("-D", "--debug", action='store_true', help="Enable script debugging output")
parser.add_argument("--error_on_diff", action='store_true', help="Show diff on error and stop")
parser.add_argument("--files", nargs='?', metavar="source", choices=file_sources, help="Which files to run fix_code_formatting on, choices=%s" % file_sources, default="git-head")
parser.add_argument("--folder", metavar="path", help="Folder in which to run fix_code_formatting", default=".")
args = parser.parse_args()
logging_level = logging.INFO
if args.debug:
logging_level = logging.DEBUG
logging.basicConfig(level=logging_level)
logger.debug("Arguments passed: %s" % str(args.__dict__))
exit(run_fix_code_formatting(args.files, args.folder, 1, error_on_diff=args.error_on_diff))
|