1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
|
/*
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/
#include "s2n_test.h"
#include "testlib/s2n_testlib.h"
#include "tls/extensions/s2n_client_renegotiation_info.h"
#include "tls/s2n_tls.h"
int s2n_parse_client_hello(struct s2n_connection *conn);
int main(int argc, char **argv)
{
BEGIN_TEST();
EXPECT_SUCCESS(s2n_disable_tls13_in_test());
const uint8_t renegotiation_info_scsv_iana[] = { TLS_EMPTY_RENEGOTIATION_INFO_SCSV };
const uint8_t client_verify_data[] = "client verify data";
DEFER_CLEANUP(struct s2n_cert_chain_and_key *chain_and_key = NULL, s2n_cert_chain_and_key_ptr_free);
EXPECT_SUCCESS(s2n_test_cert_chain_and_key_new(&chain_and_key,
S2N_DEFAULT_TEST_CERT_CHAIN, S2N_DEFAULT_TEST_PRIVATE_KEY));
DEFER_CLEANUP(struct s2n_config *config = s2n_config_new(), s2n_config_ptr_free);
EXPECT_NOT_NULL(config);
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(config, chain_and_key));
/* Test receive - too much data */
{
struct s2n_connection *conn = NULL;
EXPECT_NOT_NULL(conn = s2n_connection_new(S2N_SERVER));
struct s2n_stuffer stuffer = { 0 };
EXPECT_SUCCESS(s2n_stuffer_growable_alloc(&stuffer, 0));
EXPECT_SUCCESS(s2n_stuffer_write_uint16(&stuffer, 0));
EXPECT_FAILURE_WITH_ERRNO(s2n_client_renegotiation_info_extension.recv(conn, &stuffer),
S2N_ERR_NON_EMPTY_RENEGOTIATION_INFO);
EXPECT_FALSE(conn->secure_renegotiation);
EXPECT_SUCCESS(s2n_stuffer_free(&stuffer));
EXPECT_SUCCESS(s2n_connection_free(conn));
};
/* Test receive - value not 0
*
*= https://www.rfc-editor.org/rfc/rfc5746#3.6
*= type=test
*# The server MUST then verify
*# that the length of the "renegotiated_connection" field is zero,
*# and if it is not, MUST abort the handshake.
*/
{
struct s2n_connection *conn = NULL;
EXPECT_NOT_NULL(conn = s2n_connection_new(S2N_SERVER));
struct s2n_stuffer stuffer = { 0 };
EXPECT_SUCCESS(s2n_stuffer_growable_alloc(&stuffer, 0));
EXPECT_SUCCESS(s2n_stuffer_write_uint8(&stuffer, 1));
EXPECT_FAILURE_WITH_ERRNO(s2n_client_renegotiation_info_extension.recv(conn, &stuffer),
S2N_ERR_NON_EMPTY_RENEGOTIATION_INFO);
EXPECT_FALSE(conn->secure_renegotiation);
EXPECT_SUCCESS(s2n_stuffer_free(&stuffer));
EXPECT_SUCCESS(s2n_connection_free(conn));
};
/* Test receive */
{
struct s2n_connection *conn = NULL;
EXPECT_NOT_NULL(conn = s2n_connection_new(S2N_SERVER));
struct s2n_stuffer stuffer = { 0 };
EXPECT_SUCCESS(s2n_stuffer_growable_alloc(&stuffer, 0));
EXPECT_SUCCESS(s2n_stuffer_write_uint8(&stuffer, 0));
EXPECT_SUCCESS(s2n_client_renegotiation_info_extension.recv(conn, &stuffer));
EXPECT_TRUE(conn->secure_renegotiation);
EXPECT_SUCCESS(s2n_stuffer_free(&stuffer));
EXPECT_SUCCESS(s2n_connection_free(conn));
};
/* Test receive when using SSLv3
*
*= https://www.rfc-editor.org/rfc/rfc5746#4.5
*= type=test
*# TLS servers that support secure renegotiation and support SSLv3 MUST accept SCSV or the
*# "renegotiation_info" extension and respond as described in this
*# specification even if the offered client version is {0x03, 0x00}.
**/
{
DEFER_CLEANUP(struct s2n_connection *server_conn = s2n_connection_new(S2N_SERVER),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(server_conn);
DEFER_CLEANUP(struct s2n_stuffer extension = { 0 }, s2n_stuffer_free);
EXPECT_SUCCESS(s2n_stuffer_growable_alloc(&extension, 0));
EXPECT_SUCCESS(s2n_stuffer_write_uint8(&extension, 0));
server_conn->server_protocol_version = S2N_SSLv3;
server_conn->actual_protocol_version = S2N_SSLv3;
EXPECT_SUCCESS(s2n_client_renegotiation_info_extension.recv(server_conn, &extension));
EXPECT_TRUE(server_conn->secure_renegotiation);
};
/*
*= https://www.rfc-editor.org/rfc/rfc5746#3.4
*= type=test
*# o The client MUST include either an empty "renegotiation_info"
*# extension, or the TLS_EMPTY_RENEGOTIATION_INFO_SCSV signaling
*# cipher suite value in the ClientHello. Including both is NOT
*# RECOMMENDED.
*/
{
DEFER_CLEANUP(struct s2n_connection *client_conn = s2n_connection_new(S2N_CLIENT),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(client_conn);
DEFER_CLEANUP(struct s2n_connection *server_conn = s2n_connection_new(S2N_SERVER),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(server_conn);
/* Process the client hello on the server */
EXPECT_SUCCESS(s2n_client_hello_send(client_conn));
EXPECT_SUCCESS(s2n_stuffer_copy(&client_conn->handshake.io, &server_conn->handshake.io,
s2n_stuffer_data_available(&client_conn->handshake.io)));
EXPECT_SUCCESS(s2n_parse_client_hello(server_conn));
/* Expect TLS_EMPTY_RENEGOTIATION_INFO_SCSV */
bool found_renegotiation_info_scsv = false;
for (size_t i = 0; i < server_conn->client_hello.cipher_suites.size; i += S2N_TLS_CIPHER_SUITE_LEN) {
uint8_t *iana = server_conn->client_hello.cipher_suites.data + i;
if (memcmp(iana, renegotiation_info_scsv_iana, S2N_TLS_CIPHER_SUITE_LEN) == 0) {
found_renegotiation_info_scsv = true;
}
}
EXPECT_TRUE(found_renegotiation_info_scsv);
/* Do NOT expect "renegotiation_info" extension */
s2n_extension_type_id extension_id = 0;
EXPECT_SUCCESS(s2n_extension_supported_iana_value_to_id(
s2n_client_renegotiation_info_extension.iana_value, &extension_id));
s2n_parsed_extension *extension = &server_conn->client_hello.extensions.parsed_extensions[extension_id];
EXPECT_EQUAL(extension->extension.size, 0);
EXPECT_EQUAL(extension->extension_type, 0);
};
/**
*= https://www.rfc-editor.org/rfc/rfc5746#3.6
*= type=test
*# o The server MUST check if the "renegotiation_info" extension is
*# included in the ClientHello.
*/
{
DEFER_CLEANUP(struct s2n_connection *client_conn = s2n_connection_new(S2N_CLIENT),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(client_conn);
DEFER_CLEANUP(struct s2n_connection *server_conn = s2n_connection_new(S2N_SERVER),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(server_conn);
/* s2n-tls clients do not send the "renegotiation_info" extension.
* Instead, they send the TLS_EMPTY_RENEGOTIATION_INFO_SCSV cipher suite.
* See previous test.
*/
EXPECT_SUCCESS(s2n_client_hello_send(client_conn));
/* Process the extensions on the server */
EXPECT_SUCCESS(s2n_stuffer_copy(&client_conn->handshake.io, &server_conn->handshake.io,
s2n_stuffer_data_available(&client_conn->handshake.io)));
EXPECT_SUCCESS(s2n_parse_client_hello(server_conn));
EXPECT_SUCCESS(s2n_extension_list_process(S2N_EXTENSION_LIST_CLIENT_HELLO, server_conn,
&server_conn->client_hello.extensions));
/* Expect secure renegotiation to still be false: no extension received */
EXPECT_FALSE(server_conn->secure_renegotiation);
/* Manually append the "renegotiation_info" extension to the original list. */
uint8_t extension[] = {
0xff, 0x01, /* extension type: renegotiation_info */
0x00, 0x01, /* extension length: 1 */
0x00, /* renegotiated_connection length: 0 */
};
size_t client_hello_size = server_conn->client_hello.raw_message.size;
size_t old_extensions_size = server_conn->client_hello.extensions.raw.size;
size_t new_extensions_size = old_extensions_size + sizeof(extension);
EXPECT_SUCCESS(s2n_stuffer_rewrite(&client_conn->handshake.io));
EXPECT_SUCCESS(s2n_stuffer_skip_write(&client_conn->handshake.io,
client_hello_size - old_extensions_size - sizeof(uint16_t)));
EXPECT_SUCCESS(s2n_stuffer_write_uint16(&client_conn->handshake.io, new_extensions_size));
EXPECT_SUCCESS(s2n_stuffer_skip_write(&client_conn->handshake.io, old_extensions_size));
EXPECT_SUCCESS(s2n_stuffer_write_bytes(&client_conn->handshake.io, extension, sizeof(extension)));
/* Process the extensions on the server again */
EXPECT_SUCCESS(s2n_connection_wipe(server_conn));
EXPECT_SUCCESS(s2n_stuffer_copy(&client_conn->handshake.io, &server_conn->handshake.io,
s2n_stuffer_data_available(&client_conn->handshake.io)));
EXPECT_SUCCESS(s2n_parse_client_hello(server_conn));
EXPECT_SUCCESS(s2n_extension_list_process(S2N_EXTENSION_LIST_CLIENT_HELLO, server_conn,
&server_conn->client_hello.extensions));
/* Expect secure renegotiation to be true: extension received */
EXPECT_TRUE(server_conn->secure_renegotiation);
};
/* Test: should_send during renegotiation handshake
*
*= https://www.rfc-editor.org/rfc/rfc5746#3.5
*= type=test
*# o The client MUST include the "renegotiation_info" extension in the
*# ClientHello
*/
{
DEFER_CLEANUP(struct s2n_connection *conn = s2n_connection_new(S2N_CLIENT),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(conn);
/* Not included by default */
EXPECT_FALSE(s2n_client_renegotiation_info_extension.should_send(conn));
/* Included if renegotiation enabled */
conn->handshake.renegotiation = true;
EXPECT_TRUE(s2n_client_renegotiation_info_extension.should_send(conn));
};
/* Test: send during renegotiation handshake
*
*= https://www.rfc-editor.org/rfc/rfc5746#3.5
*= type=test
*# o The client MUST include the "renegotiation_info" extension in the
*# ClientHello, containing the saved client_verify_data.
*/
{
/* Send client_verify_data */
{
DEFER_CLEANUP(struct s2n_connection *conn = s2n_connection_new(S2N_CLIENT),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(conn);
conn->handshake.renegotiation = true;
/* Setup client_verify_data */
EXPECT_MEMCPY_SUCCESS(conn->handshake.client_finished,
client_verify_data, sizeof(client_verify_data));
conn->handshake.finished_len = sizeof(client_verify_data);
/* Error if secure renegotiation not supported */
{
conn->secure_renegotiation = false;
DEFER_CLEANUP(struct s2n_stuffer out = { 0 }, s2n_stuffer_free);
EXPECT_SUCCESS(s2n_stuffer_growable_alloc(&out, 0));
EXPECT_FAILURE_WITH_ERRNO(s2n_client_renegotiation_info_extension.send(conn, &out),
S2N_ERR_NO_RENEGOTIATION);
};
/* Success if secure renegotiation supported */
{
conn->secure_renegotiation = true;
DEFER_CLEANUP(struct s2n_stuffer out = { 0 }, s2n_stuffer_free);
EXPECT_SUCCESS(s2n_stuffer_growable_alloc(&out, 0));
EXPECT_SUCCESS(s2n_client_renegotiation_info_extension.send(conn, &out));
uint8_t actual_len = 0;
EXPECT_SUCCESS(s2n_stuffer_read_uint8(&out, &actual_len));
EXPECT_EQUAL(actual_len, sizeof(client_verify_data));
uint8_t *actual_data = s2n_stuffer_raw_read(&out, actual_len);
EXPECT_BYTEARRAY_EQUAL(actual_data, client_verify_data, actual_len);
};
};
/*
*= https://www.rfc-editor.org/rfc/rfc5746#3.5
*= type=test
*# The SCSV MUST NOT be included.
*/
{
DEFER_CLEANUP(struct s2n_connection *conn = s2n_connection_new(S2N_CLIENT),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(conn);
conn->secure_renegotiation = true;
conn->handshake.renegotiation = true;
/* Setup client_verify_data */
EXPECT_MEMCPY_SUCCESS(conn->handshake.client_finished,
client_verify_data, sizeof(client_verify_data));
conn->handshake.finished_len = sizeof(client_verify_data);
EXPECT_SUCCESS(s2n_client_hello_send(conn));
EXPECT_SUCCESS(s2n_parse_client_hello(conn));
/* Expect TLS_EMPTY_RENEGOTIATION_INFO_SCSV */
bool found_renegotiation_info_scsv = false;
for (size_t i = 0; i < conn->client_hello.cipher_suites.size; i += S2N_TLS_CIPHER_SUITE_LEN) {
uint8_t *iana = conn->client_hello.cipher_suites.data + i;
if (memcmp(iana, renegotiation_info_scsv_iana, S2N_TLS_CIPHER_SUITE_LEN) == 0) {
found_renegotiation_info_scsv = true;
}
}
EXPECT_FALSE(found_renegotiation_info_scsv);
};
};
/* Test: recv during renegotiation handshake
*
*= https://www.rfc-editor.org/rfc/rfc5746#3.7
*= type=test
*# o The server MUST verify that the value of the
*# "renegotiated_connection" field is equal to the saved
*# client_verify_data value; if it is not, the server MUST abort the
*# handshake.
*/
{
DEFER_CLEANUP(struct s2n_connection *client_conn = s2n_connection_new(S2N_SERVER),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(client_conn);
client_conn->handshake.renegotiation = true;
client_conn->secure_renegotiation = true;
DEFER_CLEANUP(struct s2n_connection *server_conn = s2n_connection_new(S2N_SERVER),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(server_conn);
server_conn->handshake.renegotiation = true;
server_conn->secure_renegotiation = true;
DEFER_CLEANUP(struct s2n_stuffer stuffer = { 0 }, s2n_stuffer_free);
EXPECT_SUCCESS(s2n_stuffer_growable_alloc(&stuffer, 0));
EXPECT_MEMCPY_SUCCESS(client_conn->handshake.client_finished,
client_verify_data, sizeof(client_verify_data));
client_conn->handshake.finished_len = sizeof(client_verify_data);
/* Test: client_verify matches */
{
EXPECT_MEMCPY_SUCCESS(server_conn->handshake.client_finished,
client_verify_data, sizeof(client_verify_data));
server_conn->handshake.finished_len = sizeof(client_verify_data);
EXPECT_SUCCESS(s2n_client_renegotiation_info_extension.send(client_conn, &stuffer));
EXPECT_SUCCESS(s2n_client_renegotiation_info_extension.recv(server_conn, &stuffer));
};
/* Test: client_verify does not match */
{
const uint8_t bad_client_verify[] = "not correct";
EXPECT_MEMCPY_SUCCESS(server_conn->handshake.client_finished,
bad_client_verify, sizeof(bad_client_verify));
server_conn->handshake.finished_len = sizeof(bad_client_verify);
EXPECT_SUCCESS(s2n_client_renegotiation_info_extension.send(client_conn, &stuffer));
EXPECT_FAILURE_WITH_ERRNO(s2n_client_renegotiation_info_extension.recv(server_conn, &stuffer),
S2N_ERR_BAD_MESSAGE);
};
/* Test: no secure_renegotiation */
{
server_conn->secure_renegotiation = false;
EXPECT_MEMCPY_SUCCESS(server_conn->handshake.client_finished,
client_verify_data, sizeof(client_verify_data));
server_conn->handshake.finished_len = sizeof(client_verify_data);
EXPECT_SUCCESS(s2n_client_renegotiation_info_extension.send(client_conn, &stuffer));
EXPECT_FAILURE_WITH_ERRNO(s2n_client_renegotiation_info_extension.recv(server_conn, &stuffer),
S2N_ERR_NO_RENEGOTIATION);
};
};
/* Test: if_missing during renegotiation handshake
*
*= https://www.rfc-editor.org/rfc/rfc5746#3.7
*= type=test
*# o The server MUST verify that the "renegotiation_info" extension is
*# present; if it is not, the server MUST abort the handshake.
*/
{
DEFER_CLEANUP(struct s2n_connection *client_conn = s2n_connection_new(S2N_CLIENT),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(client_conn);
client_conn->handshake.renegotiation = false;
DEFER_CLEANUP(struct s2n_connection *server_conn = s2n_connection_new(S2N_SERVER),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(server_conn);
server_conn->handshake.renegotiation = true;
server_conn->secure_renegotiation = true;
EXPECT_SUCCESS(s2n_client_hello_send(client_conn));
EXPECT_SUCCESS(s2n_stuffer_copy(&client_conn->handshake.io, &server_conn->handshake.io,
s2n_stuffer_data_available(&client_conn->handshake.io)));
/* Verify if_missing throws error */
EXPECT_FAILURE_WITH_ERRNO(s2n_client_renegotiation_info_extension.if_missing(server_conn),
S2N_ERR_MISSING_EXTENSION);
/* Verify server marks extension as missing when processing client hello */
EXPECT_FAILURE_WITH_ERRNO(s2n_client_hello_recv(server_conn), S2N_ERR_MISSING_EXTENSION);
};
/* Test: receiving SCSV during renegotiation is an error
*
*= https://www.rfc-editor.org/rfc/rfc5746#3.7
*= type=test
*# o When a ClientHello is received, the server MUST verify that it
*# does not contain the TLS_EMPTY_RENEGOTIATION_INFO_SCSV SCSV. If
*# the SCSV is present, the server MUST abort the handshake.
*/
{
DEFER_CLEANUP(struct s2n_connection *client_conn = s2n_connection_new(S2N_CLIENT),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(client_conn);
client_conn->secure_renegotiation = true;
DEFER_CLEANUP(struct s2n_connection *server_conn = s2n_connection_new(S2N_SERVER),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(server_conn);
EXPECT_SUCCESS(s2n_connection_set_config(server_conn, config));
server_conn->secure_renegotiation = true;
/* Construct a security policy that will write the SCSV like a regular cipher suite */
struct s2n_cipher_suite forced_scsv = {
.available = true,
.iana_value = { TLS_EMPTY_RENEGOTIATION_INFO_SCSV },
};
struct s2n_cipher_suite *cipher_suites[] = {
&forced_scsv,
&s2n_ecdhe_rsa_with_aes_128_gcm_sha256
};
struct s2n_cipher_preferences cipher_preferences = { .suites = cipher_suites, .count = s2n_array_len(cipher_suites) };
struct s2n_security_policy security_policy = *config->security_policy;
security_policy.cipher_preferences = &cipher_preferences;
client_conn->security_policy_override = &security_policy;
/* Succeeds if server expects an initial handshake */
EXPECT_SUCCESS(s2n_client_hello_send(client_conn));
EXPECT_SUCCESS(s2n_stuffer_copy(&client_conn->handshake.io, &server_conn->handshake.io,
s2n_stuffer_data_available(&client_conn->handshake.io)));
EXPECT_SUCCESS(s2n_client_hello_recv(server_conn));
client_conn->handshake.renegotiation = true;
EXPECT_MEMCPY_SUCCESS(client_conn->handshake.client_finished,
client_verify_data, sizeof(client_verify_data));
client_conn->handshake.finished_len = sizeof(client_verify_data);
server_conn->handshake.renegotiation = true;
EXPECT_MEMCPY_SUCCESS(server_conn->handshake.client_finished,
client_verify_data, sizeof(client_verify_data));
server_conn->handshake.finished_len = sizeof(client_verify_data);
/* Fails if server expects renegotiation */
EXPECT_SUCCESS(s2n_client_hello_send(client_conn));
EXPECT_SUCCESS(s2n_stuffer_copy(&client_conn->handshake.io, &server_conn->handshake.io,
s2n_stuffer_data_available(&client_conn->handshake.io)));
EXPECT_FAILURE_WITH_ERRNO(s2n_client_hello_recv(server_conn), S2N_ERR_BAD_MESSAGE);
};
END_TEST();
}
|
