1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
|
/*
This file is part of the KDE Baloo Project
SPDX-FileCopyrightText: 2014 Vishesh Handa <vhanda@kde.org>
SPDX-License-Identifier: LGPL-2.1-or-later
*/
#include "advancedqueryparser.h"
#include <QTest>
Q_DECLARE_METATYPE(Baloo::Term)
using Term = Baloo::Term;
using AdvancedQueryParser = Baloo::AdvancedQueryParser;
class AdvancedQueryParserTest : public QObject
{
Q_OBJECT
private Q_SLOTS:
void testSimpleProperty();
void testSimpleString();
void testStringAndProperty();
void testLogicalOps();
void testNesting();
void testDateTime();
void testOperators();
void testBinaryOperatorMissingFirstArg();
void testNestedParentheses();
void testNestedParentheses_data();
void testOptimizedLogic();
void testOptimizedLogic_data();
void testPhrases();
void testPhrases_data();
void testIncompleteTokens();
void testIncompleteTokens_data();
};
void AdvancedQueryParserTest::testSimpleProperty()
{
AdvancedQueryParser parser;
Term term = parser.parse(QStringLiteral("artist:Coldplay"));
Term expectedTerm(QStringLiteral("artist"), QStringLiteral("Coldplay"));
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testSimpleString()
{
AdvancedQueryParser parser;
Term term = parser.parse(QStringLiteral("Coldplay"));
Term expectedTerm(QString(), QStringLiteral("Coldplay"));
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testStringAndProperty()
{
AdvancedQueryParser parser;
Term term = parser.parse(QStringLiteral("stars artist:Coldplay fire"));
Term expectedTerm(Term::And);
expectedTerm.addSubTerm(Term(QString(), QStringLiteral("stars")));
expectedTerm.addSubTerm(Term(QStringLiteral("artist"), QStringLiteral("Coldplay")));
expectedTerm.addSubTerm(Term(QString(), QStringLiteral("fire")));
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testLogicalOps()
{
// AND
AdvancedQueryParser parser;
Term term = parser.parse(QStringLiteral("artist:Coldplay AND type:song"));
Term expectedTerm(Term::And);
expectedTerm.addSubTerm(Term(QStringLiteral("artist"), QStringLiteral("Coldplay")));
expectedTerm.addSubTerm(Term(QStringLiteral("type"), QStringLiteral("song")));
QCOMPARE(term, expectedTerm);
// OR
term = parser.parse(QStringLiteral("artist:Coldplay OR type:song"));
expectedTerm = Term(Term::Or);
expectedTerm.addSubTerm(Term(QStringLiteral("artist"), QStringLiteral("Coldplay")));
expectedTerm.addSubTerm(Term(QStringLiteral("type"), QStringLiteral("song")));
QCOMPARE(term, expectedTerm);
// AND then OR
term = parser.parse(QStringLiteral("artist:Coldplay AND type:song OR stars"));
expectedTerm = Term(Term::Or);
expectedTerm.addSubTerm(Term(QStringLiteral("artist"), QStringLiteral("Coldplay")) && Term(QStringLiteral("type"), QStringLiteral("song")));
expectedTerm.addSubTerm(Term(QString(), QStringLiteral("stars")));
QCOMPARE(term, expectedTerm);
// OR then AND
term = parser.parse(QStringLiteral("artist:Coldplay OR type:song AND stars"));
expectedTerm = Term(Term::And);
expectedTerm.addSubTerm(Term(QStringLiteral("artist"), QStringLiteral("Coldplay")) || Term(QStringLiteral("type"), QStringLiteral("song")));
expectedTerm.addSubTerm(Term(QString(), QStringLiteral("stars")));
QCOMPARE(term, expectedTerm);
// Multiple ANDs
term = parser.parse(QStringLiteral("artist:Coldplay AND type:song AND stars"));
expectedTerm = Term(Term::And);
expectedTerm.addSubTerm(Term(QStringLiteral("artist"), QStringLiteral("Coldplay")));
expectedTerm.addSubTerm(Term(QStringLiteral("type"), QStringLiteral("song")));
expectedTerm.addSubTerm(Term(QString(), QStringLiteral("stars")));
QCOMPARE(term, expectedTerm);
// Multiple ORs
term = parser.parse(QStringLiteral("artist:Coldplay OR type:song OR stars"));
expectedTerm = Term(Term::Or);
expectedTerm.addSubTerm(Term(QStringLiteral("artist"), QStringLiteral("Coldplay")));
expectedTerm.addSubTerm(Term(QStringLiteral("type"), QStringLiteral("song")));
expectedTerm.addSubTerm(Term(QString(), QStringLiteral("stars")));
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testNesting()
{
AdvancedQueryParser parser;
Term term = parser.parse(QStringLiteral("artist:Coldplay AND (type:song OR stars) fire"));
Term expectedTerm(Term::And);
expectedTerm.addSubTerm(Term(QStringLiteral("artist"), QStringLiteral("Coldplay")));
expectedTerm.addSubTerm(Term(QStringLiteral("type"), QStringLiteral("song")) || Term(QString(), QStringLiteral("stars")));
expectedTerm.addSubTerm(Term(QString(), QStringLiteral("fire")));
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testDateTime()
{
// Integers
AdvancedQueryParser parser;
Term term;
Term expectedTerm;
term = parser.parse(QStringLiteral("modified:2014-12-02"));
expectedTerm = Term(QStringLiteral("modified"), QStringLiteral("2014-12-02"));
QCOMPARE(term, expectedTerm);
term = parser.parse(QStringLiteral("modified:\"2014-12-02T23:22:1\""));
expectedTerm = Term(QStringLiteral("modified"), QStringLiteral("2014-12-02T23:22:1"));
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testOperators()
{
AdvancedQueryParser parser;
Term term;
Term expectedTerm;
term = parser.parse(QStringLiteral("width:500"));
expectedTerm = Term(QStringLiteral("width"), QStringLiteral("500"), Term::Contains);
QCOMPARE(term, expectedTerm);
term = parser.parse(QStringLiteral("width=500"));
expectedTerm = Term(QStringLiteral("width"), QStringLiteral("500"), Term::Equal);
QCOMPARE(term, expectedTerm);
term = parser.parse(QStringLiteral("width<500"));
expectedTerm = Term(QStringLiteral("width"), QStringLiteral("500"), Term::Less);
QCOMPARE(term, expectedTerm);
term = parser.parse(QStringLiteral("width<=500"));
expectedTerm = Term(QStringLiteral("width"), QStringLiteral("500"), Term::LessEqual);
QCOMPARE(term, expectedTerm);
term = parser.parse(QStringLiteral("width>500"));
expectedTerm = Term(QStringLiteral("width"), QStringLiteral("500"), Term::Greater);
QCOMPARE(term, expectedTerm);
term = parser.parse(QStringLiteral("width>=500"));
expectedTerm = Term(QStringLiteral("width"), QStringLiteral("500"), Term::GreaterEqual);
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testBinaryOperatorMissingFirstArg()
{
AdvancedQueryParser parser;
Term term = parser.parse(QStringLiteral("=:2"));
Term expectedTerm;
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testNestedParentheses()
{
QFETCH(QString, searchInput);
QFETCH(QString, failmessage);
QFETCH(Term, expectedTerm);
AdvancedQueryParser parser;
const auto testTerm = parser.parse(searchInput);
qDebug() << " result term" << testTerm;
qDebug() << "expected term" << expectedTerm;
if (!failmessage.isEmpty()) {
QEXPECT_FAIL("", qPrintable(failmessage), Continue);
}
QCOMPARE(testTerm, expectedTerm);
}
void AdvancedQueryParserTest::testNestedParentheses_data()
{
QTest::addColumn<QString>("searchInput");
QTest::addColumn<Term>("expectedTerm");
QTest::addColumn<QString>("failmessage");
QTest::newRow("a AND b AND c AND d")
<< QStringLiteral("a AND b AND c AND d")
<< Term{Term::And, QList<Term>{
Term{QString(), QStringLiteral("a"), Term::Contains},
Term{QString(), QStringLiteral("b"), Term::Contains},
Term{QString(), QStringLiteral("c"), Term::Contains},
Term{QString(), QStringLiteral("d"), Term::Contains},
}}
<< QString()
;
QTest::newRow("(a AND b) AND (c OR d)")
<< QStringLiteral("(a AND b) AND (c OR d)")
<< Term{Term::And, QList<Term>{
Term{QString(), QStringLiteral("a"), Term::Contains},
Term{QString(), QStringLiteral("b"), Term::Contains},
Term{Term::Or, QList<Term>{
Term{QString(), QStringLiteral("c"), Term::Contains},
Term{QString(), QStringLiteral("d"), Term::Contains},
}}
}}
<< QString()
;
QTest::newRow("(a AND (b AND (c AND d)))")
<< QStringLiteral("(a AND (b AND (c AND d)))")
<< Term{Term::And, QList<Term>{
Term{QString(), QStringLiteral("a"), Term::Contains},
Term{QString(), QStringLiteral("b"), Term::Contains},
Term{QString(), QStringLiteral("c"), Term::Contains},
Term{QString(), QStringLiteral("d"), Term::Contains},
}}
<< QString()
;
// Test 1 for BUG: 392620
QTest::newRow("a OR ((b AND c) AND d)")
<< QStringLiteral("a OR ((b AND c) AND d)")
<< Term{Term::Or, QList<Term>{
Term{QString(), QStringLiteral("a"), Term::Contains},
Term{Term::And, QList<Term>{
Term{QString(), QStringLiteral("b"), Term::Contains},
Term{QString(), QStringLiteral("c"), Term::Contains},
Term{QString(), QStringLiteral("d"), Term::Contains}
}}
}}
<< QString()
;
// Test 2 for BUG: 392620
QTest::newRow("a AND ((b OR c) OR d)")
<< QStringLiteral("a AND ((b OR c) OR d)")
<< Term{Term::And, QList<Term>{
Term{QString(), QStringLiteral("a"), Term::Contains},
Term{Term::Or, QList<Term>{
Term{QString(), QStringLiteral("b"), Term::Contains},
Term{QString(), QStringLiteral("c"), Term::Contains},
Term{QString(), QStringLiteral("d"), Term::Contains}
}}
}}
<< QString();
;
}
void AdvancedQueryParserTest::testOptimizedLogic()
{
QFETCH(Term, testTerm);
QFETCH(Term, expectedTerm);
qDebug() << " result term" << testTerm;
qDebug() << "expected term" << expectedTerm;
QCOMPARE(testTerm, expectedTerm);
}
void AdvancedQueryParserTest::testOptimizedLogic_data()
{
QTest::addColumn<Term>("testTerm");
QTest::addColumn<Term>("expectedTerm");
// a && b && c && d can be combined into one AND term with 4 subterms
QTest::addRow("a && b && c && d")
<< (Term{QString(), QStringLiteral("a"), Term::Contains}
&& Term{QString(), QStringLiteral("b"), Term::Contains}
&& Term{QString(), QStringLiteral("c"), Term::Contains}
&& Term{QString(), QStringLiteral("d"), Term::Contains})
<< Term{Term::And, QList<Term>{
Term{QString(), QStringLiteral("a"), Term::Contains},
Term{QString(), QStringLiteral("b"), Term::Contains},
Term{QString(), QStringLiteral("c"), Term::Contains},
Term{QString(), QStringLiteral("d"), Term::Contains},
}}
;
// (a AND b) AND (c OR d) can be merged as (a AND b AND (c OR D)
QTest::addRow("(a && b) && (c || d)")
<< ((Term{QString(), QStringLiteral("a"), Term::Contains}
&& Term{QString(), QStringLiteral("b"), Term::Contains})
&& (Term{QString(), QStringLiteral("c"), Term::Contains}
|| Term{QString(), QStringLiteral("d"), Term::Contains}
))
<< Term{Term::And, QList<Term>{
Term{QString(), QStringLiteral("a"), Term::Contains},
Term{QString(), QStringLiteral("b"), Term::Contains},
Term{Term::Or, QList<Term>{
Term{QString(), QStringLiteral("c"), Term::Contains},
Term{QString(), QStringLiteral("d"), Term::Contains}
}}
}}
;
}
void AdvancedQueryParserTest::testPhrases()
{
QFETCH(QString, input);
QFETCH(Term, expectedTerm);
AdvancedQueryParser parser;
Term term = parser.parse(input);
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testPhrases_data()
{
QTest::addColumn<QString>("input");
QTest::addColumn<Term>("expectedTerm");
auto addRow = [](const QString& input, const Term& term)
{ QTest::addRow("%s", qPrintable(input)) << input << term; };
addRow(QStringLiteral("artist:ColdPlay"), {QStringLiteral("artist"), QStringLiteral("ColdPlay"), Term::Contains});
addRow(QStringLiteral("artist:\"ColdPlay\""), {QStringLiteral("artist"), QStringLiteral("ColdPlay"), Term::Contains});
addRow(QStringLiteral("artist:\"Foo Fighters\""), {QStringLiteral("artist"), QStringLiteral("Foo Fighters"), Term::Contains});
addRow(QStringLiteral("artist:\"Foo Fighters\" OR artist:ColdPlay "), {Term::Or, {
{QStringLiteral("artist"), QStringLiteral("Foo Fighters"), Term::Contains},
{QStringLiteral("artist"), QStringLiteral("ColdPlay"), Term::Contains},
}});
}
void AdvancedQueryParserTest::testIncompleteTokens()
{
QFETCH(QString, input);
QFETCH(Term, expectedTerm);
AdvancedQueryParser parser;
Term term = parser.parse(input);
QCOMPARE(term, expectedTerm);
}
void AdvancedQueryParserTest::testIncompleteTokens_data()
{
QTest::addColumn<QString>("input");
QTest::addColumn<Term>("expectedTerm");
auto addRow = [](const QString& name, const QString& input, const Term& term)
{ QTest::addRow("%s", qPrintable(name)) << input << term; };
addRow(QStringLiteral("ends with quote"), QStringLiteral("foo \""), {QString(), QStringLiteral("foo"), Term::Auto});
addRow(QStringLiteral("ends with comparator"), QStringLiteral("foo>"), {QStringLiteral("foo"), QString(), Term::Contains});
addRow(QStringLiteral("ends with opening parens"), QStringLiteral("foo ("), {QString(), QStringLiteral("foo")});
addRow(QStringLiteral("ends with closing parens"), QStringLiteral("foo ("), {QString(), QStringLiteral("foo")});
}
QTEST_MAIN(AdvancedQueryParserTest)
#include "advancedqueryparsertest.moc"
|
