File: Fix_redundant-move_warning.patch

package info (click to toggle)
bambootracker 0.6.5-1
  • links: PTS, VCS
  • area: main
  • in suites: sid, trixie
  • size: 7,528 kB
  • sloc: cpp: 60,517; ansic: 7,314; sh: 132; python: 32; makefile: 18; xml: 15
file content (29 lines) | stat: -rw-r--r-- 1,068 bytes parent folder | download 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
 
<From 2dd9d0c4ed0e012c2a8e0f8b8d2ed4a1af0b2df0 Mon Sep 17 00:00:00 2001
From: OPNA2608 <opna2608@protonmail.com>
Date: Mon, 10 Mar 2025 21:21:39 +0100
Subject: [PATCH] BambooTracker/playback.cpp: Fix redundant-move warning

playback.cpp: In member function 'void EffectMemory::enqueue(const Effect&)':
playback.cpp:42:41: error: redundant move in initialization [-Werror=redundant-move]
   42 |                 auto autoEnv = std::move(*autoEnvItr);
      |                                ~~~~~~~~~^~~~~~~~~~~~~
playback.cpp:42:41: note: remove 'std::move' call
---
 BambooTracker/playback.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/BambooTracker/playback.cpp b/BambooTracker/playback.cpp
index 6e95222a..f6d119a0 100644
--- a/BambooTracker/playback.cpp
+++ b/BambooTracker/playback.cpp
@@ -39,9 +39,8 @@ void EffectMemory::enqueue(const Effect& eff)
 			return;
 		}
 
-		auto autoEnv = std::move(*autoEnvItr);
 		mem_.erase(autoEnvItr);
-		mem_.push_back(std::move(autoEnv));
+		mem_.push_back(std::move(*autoEnvItr));
 		break;
 	}