1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
|
# This file is part of beets.
# Copyright 2016, Adrian Sampson.
#
# Permission is hereby granted, free of charge, to any person obtaining
# a copy of this software and associated documentation files (the
# "Software"), to deal in the Software without restriction, including
# without limitation the rights to use, copy, modify, merge, publish,
# distribute, sublicense, and/or sell copies of the Software, and to
# permit persons to whom the Software is furnished to do so, subject to
# the following conditions:
#
# The above copyright notice and this permission notice shall be
# included in all copies or substantial portions of the Software.
"""Tests for base utils from the beets.util package."""
import os
import platform
import re
import subprocess
import sys
import unittest
from unittest.mock import Mock, patch
import pytest
from beets import util
from beets.library import Item
from beets.test import _common
class UtilTest(unittest.TestCase):
def test_open_anything(self):
with _common.system_mock("Windows"):
assert util.open_anything() == "start"
with _common.system_mock("Darwin"):
assert util.open_anything() == "open"
with _common.system_mock("Tagada"):
assert util.open_anything() == "xdg-open"
@patch("os.execlp")
@patch("beets.util.open_anything")
def test_interactive_open(self, mock_open, mock_execlp):
mock_open.return_value = "tagada"
util.interactive_open(["foo"], util.open_anything())
mock_execlp.assert_called_once_with("tagada", "tagada", "foo")
mock_execlp.reset_mock()
util.interactive_open(["foo"], "bar")
mock_execlp.assert_called_once_with("bar", "bar", "foo")
def test_sanitize_unix_replaces_leading_dot(self):
with _common.platform_posix():
p = util.sanitize_path("one/.two/three")
assert "." not in p
def test_sanitize_windows_replaces_trailing_dot(self):
with _common.platform_windows():
p = util.sanitize_path("one/two./three")
assert "." not in p
def test_sanitize_windows_replaces_illegal_chars(self):
with _common.platform_windows():
p = util.sanitize_path(':*?"<>|')
assert ":" not in p
assert "*" not in p
assert "?" not in p
assert '"' not in p
assert "<" not in p
assert ">" not in p
assert "|" not in p
def test_sanitize_windows_replaces_trailing_space(self):
with _common.platform_windows():
p = util.sanitize_path("one/two /three")
assert " " not in p
def test_sanitize_path_works_on_empty_string(self):
with _common.platform_posix():
p = util.sanitize_path("")
assert p == ""
def test_sanitize_with_custom_replace_overrides_built_in_sub(self):
with _common.platform_posix():
p = util.sanitize_path("a/.?/b", [(re.compile(r"foo"), "bar")])
assert p == "a/.?/b"
def test_sanitize_with_custom_replace_adds_replacements(self):
with _common.platform_posix():
p = util.sanitize_path("foo/bar", [(re.compile(r"foo"), "bar")])
assert p == "bar/bar"
@unittest.skip("unimplemented: #359")
def test_sanitize_empty_component(self):
with _common.platform_posix():
p = util.sanitize_path("foo//bar", [(re.compile(r"^$"), "_")])
assert p == "foo/_/bar"
@patch("beets.util.subprocess.Popen")
def test_command_output(self, mock_popen):
def popen_fail(*args, **kwargs):
m = Mock(returncode=1)
m.communicate.return_value = "foo", "bar"
return m
mock_popen.side_effect = popen_fail
with pytest.raises(subprocess.CalledProcessError) as exc_info:
util.command_output(["taga", "\xc3\xa9"])
assert exc_info.value.returncode == 1
assert exc_info.value.cmd == "taga \xc3\xa9"
def test_case_sensitive_default(self):
path = util.bytestring_path(
util.normpath(
"/this/path/does/not/exist",
)
)
assert util.case_sensitive(path) == (platform.system() != "Windows")
@unittest.skipIf(sys.platform == "win32", "fs is not case sensitive")
def test_case_sensitive_detects_sensitive(self):
# FIXME: Add tests for more code paths of case_sensitive()
# when the filesystem on the test runner is not case sensitive
pass
@unittest.skipIf(sys.platform != "win32", "fs is case sensitive")
def test_case_sensitive_detects_insensitive(self):
# FIXME: Add tests for more code paths of case_sensitive()
# when the filesystem on the test runner is case sensitive
pass
class PathConversionTest(unittest.TestCase):
def test_syspath_windows_format(self):
with _common.platform_windows():
path = os.path.join("a", "b", "c")
outpath = util.syspath(path)
assert isinstance(outpath, str)
assert outpath.startswith("\\\\?\\")
def test_syspath_windows_format_unc_path(self):
# The \\?\ prefix on Windows behaves differently with UNC
# (network share) paths.
path = "\\\\server\\share\\file.mp3"
with _common.platform_windows():
outpath = util.syspath(path)
assert isinstance(outpath, str)
assert outpath == "\\\\?\\UNC\\server\\share\\file.mp3"
def test_syspath_posix_unchanged(self):
with _common.platform_posix():
path = os.path.join("a", "b", "c")
outpath = util.syspath(path)
assert path == outpath
def _windows_bytestring_path(self, path):
with _common.platform_windows():
return util.bytestring_path(path)
def test_bytestring_path_windows_encodes_utf8(self):
path = "caf\xe9"
outpath = self._windows_bytestring_path(path)
assert path == outpath.decode("utf-8")
def test_bytesting_path_windows_removes_magic_prefix(self):
path = "\\\\?\\C:\\caf\xe9"
outpath = self._windows_bytestring_path(path)
assert outpath == "C:\\caf\xe9".encode()
class TestPathLegalization:
_p = pytest.param
@pytest.fixture(autouse=True)
def _patch_max_filename_length(self, monkeypatch):
monkeypatch.setattr("beets.util.get_max_filename_length", lambda: 5)
@pytest.mark.parametrize(
"path, expected",
[
_p("abcdeX/fgh", "abcde/fgh", id="truncate-parent-dir"),
_p("abcde/fXX.ext", "abcde/f.ext", id="truncate-filename"),
# note that 🎹 is 4 bytes long:
# >>> "🎹".encode("utf-8")
# b'\xf0\x9f\x8e\xb9'
_p("a🎹/a.ext", "a🎹/a.ext", id="unicode-fit"),
_p("ab🎹/a.ext", "ab/a.ext", id="unicode-truncate-fully-one-byte-over-limit"),
_p("f.a.e", "f.a.e", id="persist-dot-in-filename"), # see #5771
],
) # fmt: skip
def test_truncate(self, path, expected):
path = path.replace("/", os.path.sep)
expected = expected.replace("/", os.path.sep)
assert util.truncate_path(path) == expected
@pytest.mark.parametrize(
"replacements, expected_path, expected_truncated",
[ # [ repl before truncation, repl after truncation ]
_p([ ], "_abcd", False, id="default"),
_p([(r"abcdX$", "1ST"), ], ":1ST", False, id="1st_valid"),
_p([(r"abcdX$", "TOO_LONG"), ], ":TOO_", False, id="1st_truncated"),
_p([(r"abcdX$", "1ST"), (r"1ST$", "2ND") ], ":2ND", False, id="both_valid"),
_p([(r"abcdX$", "TOO_LONG"), (r"TOO_$", "2ND") ], ":2ND", False, id="1st_truncated_2nd_valid"),
_p([(r"abcdX$", "1ST"), (r"1ST$", "TOO_LONG") ], ":TOO_", False, id="1st_valid_2nd_truncated"),
# if the logic truncates the path twice, it ends up applying the default replacements
_p([(r"abcdX$", "TOO_LONG"), (r"TOO_$", "TOO_LONG") ], "_TOO_", True, id="both_truncated_default_repl_applied"),
]
) # fmt: skip
def test_replacements(
self, replacements, expected_path, expected_truncated
):
replacements = [(re.compile(pat), repl) for pat, repl in replacements]
assert util.legalize_path(":abcdX", replacements, "") == (
expected_path,
expected_truncated,
)
class TestPlurality:
@pytest.mark.parametrize(
"objs, expected_obj, expected_freq",
[
pytest.param([1, 1, 1, 1], 1, 4, id="consensus"),
pytest.param([1, 1, 2, 1], 1, 3, id="near consensus"),
pytest.param([1, 1, 2, 2, 3], 1, 2, id="conflict-first-wins"),
],
)
def test_plurality(self, objs, expected_obj, expected_freq):
assert (expected_obj, expected_freq) == util.plurality(objs)
def test_empty_sequence_raises_error(self):
with pytest.raises(ValueError, match="must be non-empty"):
util.plurality([])
def test_get_most_common_tags(self):
items = [
Item(albumartist="aartist", label="label 1", album="album"),
Item(albumartist="aartist", label="label 2", album="album"),
Item(albumartist="aartist", label="label 3", album="another album"),
]
likelies, consensus = util.get_most_common_tags(items)
assert likelies["albumartist"] == "aartist"
assert likelies["album"] == "album"
# albumartist consensus overrides artist
assert likelies["artist"] == "aartist"
assert likelies["label"] == "label 1"
assert likelies["year"] == 0
assert consensus["year"]
assert consensus["albumartist"]
assert not consensus["album"]
assert not consensus["label"]
|