1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545
|
# This file is part of beets.
# Copyright 2016, Thomas Scholtes.
#
# Permission is hereby granted, free of charge, to any person obtaining
# a copy of this software and associated documentation files (the
# "Software"), to deal in the Software without restriction, including
# without limitation the rights to use, copy, modify, merge, publish,
# distribute, sublicense, and/or sell copies of the Software, and to
# permit persons to whom the Software is furnished to do so, subject to
# the following conditions:
#
# The above copyright notice and this permission notice shall be
# included in all copies or substantial portions of the Software.
import importlib
import itertools
import logging
import os
import pkgutil
import sys
from unittest.mock import ANY, Mock, patch
import pytest
from mediafile import MediaFile
from beets import config, plugins, ui
from beets.dbcore import types
from beets.importer import (
Action,
ArchiveImportTask,
SentinelImportTask,
SingletonImportTask,
)
from beets.library import Item
from beets.test import helper
from beets.test.helper import (
AutotagStub,
ImportHelper,
PluginMixin,
PluginTestCase,
TerminalImportMixin,
)
from beets.util import displayable_path, syspath
class TestPluginRegistration(PluginTestCase):
class RatingPlugin(plugins.BeetsPlugin):
item_types = {
"rating": types.Float(),
"multi_value": types.MULTI_VALUE_DSV,
}
def __init__(self):
super().__init__()
self.register_listener("write", self.on_write)
@staticmethod
def on_write(item=None, path=None, tags=None):
if tags["artist"] == "XXX":
tags["artist"] = "YYY"
def setUp(self):
super().setUp()
self.register_plugin(self.RatingPlugin)
def test_field_type_registered(self):
assert isinstance(Item._types.get("rating"), types.Float)
def test_duplicate_type(self):
class DuplicateTypePlugin(plugins.BeetsPlugin):
item_types = {"rating": types.INTEGER}
self.register_plugin(DuplicateTypePlugin)
with pytest.raises(
plugins.PluginConflictError, match="already been defined"
):
Item._types
def test_listener_registered(self):
self.RatingPlugin()
item = self.add_item_fixture(artist="XXX")
item.write()
assert MediaFile(syspath(item.path)).artist == "YYY"
def test_multi_value_flex_field_type(self):
item = Item(path="apath", artist="aaa")
item.multi_value = ["one", "two", "three"]
item.add(self.lib)
out = self.run_with_output("ls", "-f", "$multi_value")
delimiter = types.MULTI_VALUE_DSV.delimiter
assert out == f"one{delimiter}two{delimiter}three\n"
class PluginImportTestCase(ImportHelper, PluginTestCase):
def setUp(self):
super().setUp()
self.prepare_album_for_import(2)
class EventsTest(PluginImportTestCase):
def test_import_task_created(self):
self.importer = self.setup_importer(pretend=True)
with helper.capture_log() as logs:
self.importer.run()
# Exactly one event should have been imported (for the album).
# Sentinels do not get emitted.
assert logs.count("Sending event: import_task_created") == 1
logs = [line for line in logs if not line.startswith("Sending event:")]
assert logs == [
f"Album: {displayable_path(os.path.join(self.import_dir, b'album'))}",
f" {displayable_path(self.import_media[0].path)}",
f" {displayable_path(self.import_media[1].path)}",
]
def test_import_task_created_with_plugin(self):
class ToSingletonPlugin(plugins.BeetsPlugin):
def __init__(self):
super().__init__()
self.register_listener(
"import_task_created", self.import_task_created_event
)
def import_task_created_event(self, session, task):
if (
isinstance(task, SingletonImportTask)
or isinstance(task, SentinelImportTask)
or isinstance(task, ArchiveImportTask)
):
return task
new_tasks = []
for item in task.items:
new_tasks.append(SingletonImportTask(task.toppath, item))
return new_tasks
to_singleton_plugin = ToSingletonPlugin
self.register_plugin(to_singleton_plugin)
self.importer = self.setup_importer(pretend=True)
with helper.capture_log() as logs:
self.importer.run()
# Exactly one event should have been imported (for the album).
# Sentinels do not get emitted.
assert logs.count("Sending event: import_task_created") == 1
logs = [line for line in logs if not line.startswith("Sending event:")]
assert logs == [
f"Singleton: {displayable_path(self.import_media[0].path)}",
f"Singleton: {displayable_path(self.import_media[1].path)}",
]
class ListenersTest(PluginTestCase):
def test_register(self):
class DummyPlugin(plugins.BeetsPlugin):
def __init__(self):
super().__init__()
self.register_listener("cli_exit", self.dummy)
self.register_listener("cli_exit", self.dummy)
def dummy(self):
pass
d = DummyPlugin()
assert DummyPlugin._raw_listeners["cli_exit"] == [d.dummy]
d2 = DummyPlugin()
assert DummyPlugin._raw_listeners["cli_exit"] == [d.dummy, d2.dummy]
d.register_listener("cli_exit", d2.dummy)
assert DummyPlugin._raw_listeners["cli_exit"] == [d.dummy, d2.dummy]
def test_events_called(self):
class DummyPlugin(plugins.BeetsPlugin):
def __init__(self):
super().__init__()
self.foo = Mock(__name__="foo")
self.register_listener("event_foo", self.foo)
self.bar = Mock(__name__="bar")
self.register_listener("event_bar", self.bar)
d = DummyPlugin()
plugins.send("event")
d.foo.assert_has_calls([])
d.bar.assert_has_calls([])
plugins.send("event_foo", var="tagada")
d.foo.assert_called_once_with(var="tagada")
d.bar.assert_has_calls([])
def test_listener_params(self):
class DummyPlugin(plugins.BeetsPlugin):
def __init__(self):
super().__init__()
for i in itertools.count(1):
try:
meth = getattr(self, f"dummy{i}")
except AttributeError:
break
self.register_listener(f"event{i}", meth)
def dummy1(self, foo):
assert foo == 5
def dummy2(self, foo=None):
assert foo == 5
def dummy3(self):
# argument cut off
pass
def dummy4(self, bar=None):
# argument cut off
pass
def dummy5(self, bar):
assert not True
# more complex examples
def dummy6(self, foo, bar=None):
assert foo == 5
assert bar is None
def dummy7(self, foo, **kwargs):
assert foo == 5
assert kwargs == {}
def dummy8(self, foo, bar, **kwargs):
assert not True
def dummy9(self, **kwargs):
assert kwargs == {"foo": 5}
DummyPlugin()
plugins.send("event1", foo=5)
plugins.send("event2", foo=5)
plugins.send("event3", foo=5)
plugins.send("event4", foo=5)
with pytest.raises(TypeError):
plugins.send("event5", foo=5)
plugins.send("event6", foo=5)
plugins.send("event7", foo=5)
with pytest.raises(TypeError):
plugins.send("event8", foo=5)
plugins.send("event9", foo=5)
class PromptChoicesTest(TerminalImportMixin, PluginImportTestCase):
def setUp(self):
super().setUp()
self.setup_importer()
self.matcher = AutotagStub(AutotagStub.IDENT).install()
self.addCleanup(self.matcher.restore)
# keep track of ui.input_option() calls
self.input_options_patcher = patch(
"beets.ui.input_options", side_effect=ui.input_options
)
self.mock_input_options = self.input_options_patcher.start()
def tearDown(self):
super().tearDown()
self.input_options_patcher.stop()
def test_plugin_choices_in_ui_input_options_album(self):
"""Test the presence of plugin choices on the prompt (album)."""
class DummyPlugin(plugins.BeetsPlugin):
def __init__(self):
super().__init__()
self.register_listener(
"before_choose_candidate", self.return_choices
)
def return_choices(self, session, task):
return [
ui.commands.PromptChoice("f", "Foo", None),
ui.commands.PromptChoice("r", "baR", None),
]
self.register_plugin(DummyPlugin)
# Default options + extra choices by the plugin ('Foo', 'Bar')
opts = (
"Apply",
"More candidates",
"Skip",
"Use as-is",
"as Tracks",
"Group albums",
"Enter search",
"enter Id",
"aBort",
) + ("Foo", "baR")
self.importer.add_choice(Action.SKIP)
self.importer.run()
self.mock_input_options.assert_called_once_with(
opts, default="a", require=ANY
)
def test_plugin_choices_in_ui_input_options_singleton(self):
"""Test the presence of plugin choices on the prompt (singleton)."""
class DummyPlugin(plugins.BeetsPlugin):
def __init__(self):
super().__init__()
self.register_listener(
"before_choose_candidate", self.return_choices
)
def return_choices(self, session, task):
return [
ui.commands.PromptChoice("f", "Foo", None),
ui.commands.PromptChoice("r", "baR", None),
]
self.register_plugin(DummyPlugin)
# Default options + extra choices by the plugin ('Foo', 'Bar')
opts = (
"Apply",
"More candidates",
"Skip",
"Use as-is",
"Enter search",
"enter Id",
"aBort",
) + ("Foo", "baR")
config["import"]["singletons"] = True
self.importer.add_choice(Action.SKIP)
self.importer.run()
self.mock_input_options.assert_called_with(
opts, default="a", require=ANY
)
def test_choices_conflicts(self):
"""Test the short letter conflict solving."""
class DummyPlugin(plugins.BeetsPlugin):
def __init__(self):
super().__init__()
self.register_listener(
"before_choose_candidate", self.return_choices
)
def return_choices(self, session, task):
return [
ui.commands.PromptChoice("a", "A foo", None), # dupe
ui.commands.PromptChoice("z", "baZ", None), # ok
ui.commands.PromptChoice("z", "Zupe", None), # dupe
ui.commands.PromptChoice("z", "Zoo", None),
] # dupe
self.register_plugin(DummyPlugin)
# Default options + not dupe extra choices by the plugin ('baZ')
opts = (
"Apply",
"More candidates",
"Skip",
"Use as-is",
"as Tracks",
"Group albums",
"Enter search",
"enter Id",
"aBort",
) + ("baZ",)
self.importer.add_choice(Action.SKIP)
self.importer.run()
self.mock_input_options.assert_called_once_with(
opts, default="a", require=ANY
)
def test_plugin_callback(self):
"""Test that plugin callbacks are being called upon user choice."""
class DummyPlugin(plugins.BeetsPlugin):
def __init__(self):
super().__init__()
self.register_listener(
"before_choose_candidate", self.return_choices
)
def return_choices(self, session, task):
return [ui.commands.PromptChoice("f", "Foo", self.foo)]
def foo(self, session, task):
pass
self.register_plugin(DummyPlugin)
# Default options + extra choices by the plugin ('Foo', 'Bar')
opts = (
"Apply",
"More candidates",
"Skip",
"Use as-is",
"as Tracks",
"Group albums",
"Enter search",
"enter Id",
"aBort",
) + ("Foo",)
# DummyPlugin.foo() should be called once
with patch.object(DummyPlugin, "foo", autospec=True) as mock_foo:
with helper.control_stdin("\n".join(["f", "s"])):
self.importer.run()
assert mock_foo.call_count == 1
# input_options should be called twice, as foo() returns None
assert self.mock_input_options.call_count == 2
self.mock_input_options.assert_called_with(
opts, default="a", require=ANY
)
def test_plugin_callback_return(self):
"""Test that plugin callbacks that return a value exit the loop."""
class DummyPlugin(plugins.BeetsPlugin):
def __init__(self):
super().__init__()
self.register_listener(
"before_choose_candidate", self.return_choices
)
def return_choices(self, session, task):
return [ui.commands.PromptChoice("f", "Foo", self.foo)]
def foo(self, session, task):
return Action.SKIP
self.register_plugin(DummyPlugin)
# Default options + extra choices by the plugin ('Foo', 'Bar')
opts = (
"Apply",
"More candidates",
"Skip",
"Use as-is",
"as Tracks",
"Group albums",
"Enter search",
"enter Id",
"aBort",
) + ("Foo",)
# DummyPlugin.foo() should be called once
with helper.control_stdin("f\n"):
self.importer.run()
# input_options should be called once, as foo() returns SKIP
self.mock_input_options.assert_called_once_with(
opts, default="a", require=ANY
)
def get_available_plugins():
"""Get all available plugins in the beetsplug namespace."""
namespace_pkg = importlib.import_module("beetsplug")
return [
m.name
for m in pkgutil.iter_modules(namespace_pkg.__path__)
if not m.name.startswith("_")
]
class TestImportPlugin(PluginMixin):
@pytest.fixture(params=get_available_plugins())
def plugin_name(self, request):
"""Fixture to provide the name of each available plugin."""
name = request.param
# skip gstreamer plugins on windows
gstreamer_plugins = {"bpd", "replaygain"}
if sys.platform == "win32" and name in gstreamer_plugins:
pytest.skip(f"GStreamer is not available on Windows: {name}")
return name
def unload_plugins(self):
"""Unimport plugins before each test to avoid conflicts."""
super().unload_plugins()
for mod in list(sys.modules):
if mod.startswith("beetsplug."):
del sys.modules[mod]
@pytest.fixture(autouse=True)
def cleanup(self):
"""Ensure plugins are unimported before and after each test."""
self.unload_plugins()
yield
self.unload_plugins()
@pytest.mark.skipif(
os.environ.get("GITHUB_ACTIONS") != "true",
reason=(
"Requires all dependencies to be installed, which we can't"
" guarantee in the local environment."
),
)
def test_import_plugin(self, caplog, plugin_name):
"""Test that a plugin is importable without an error."""
caplog.set_level(logging.WARNING)
self.load_plugins(plugin_name)
assert "PluginImportError" not in caplog.text, (
f"Plugin '{plugin_name}' has issues during import."
)
class TestDeprecationCopy:
# TODO: remove this test in Beets 3.0.0
def test_legacy_metadata_plugin_deprecation(self):
"""Test that a MetadataSourcePlugin with 'legacy' data_source
raises a deprecation warning and all function and properties are
copied from the base class.
"""
with pytest.warns(DeprecationWarning, match="LegacyMetadataPlugin"):
class LegacyMetadataPlugin(plugins.BeetsPlugin):
data_source = "legacy"
# Assert all methods are present
assert hasattr(LegacyMetadataPlugin, "albums_for_ids")
assert hasattr(LegacyMetadataPlugin, "tracks_for_ids")
assert hasattr(LegacyMetadataPlugin, "data_source_mismatch_penalty")
assert hasattr(LegacyMetadataPlugin, "_extract_id")
assert hasattr(LegacyMetadataPlugin, "get_artist")
|